Making the correct Parsing
Fix #888 I changed it to parse the right jdk date but however i couldn't make the right jdk date showing in the graph.
Deploy Preview for eclipsefdn-adoptium-trss canceled.
| Name | Link |
|---|---|
| Latest commit | 686bec8f62665a6ad207f8e56348048f4b112562 |
| Latest deploy log | https://app.netlify.com/sites/eclipsefdn-adoptium-trss/deploys/66a01a15b8177600088391c6 |
i had added a test case file could you check it and give me some feedbacks?
@Sangyoon21 Thanks for the test coverage, that's a great start! It probably would be good to add a few more output variants for our common LTS's. e.g., For Java 8
openjdk version "1.8.0_412"
OpenJDK Runtime Environment (Temurin)(build 1.8.0_412-b08)
OpenJDK 64-Bit Server VM (Temurin)(build 25.412-b08, mixed mode)
I think there are some more examples in https://github.com/adoptium/api.adoptium.net/blob/main/adoptium-models-parent/adoptium-api-v3-models/src/test/kotlin/api/VersionParserTest.kt
i had added some more test cases but i am not sure what should be the date for those different version. Could you clarify it please?
@Sangyoon21 You mentioned the dates still look incorrect in the UI though?
i am not sure about it, i cannot check it on my side right now.
i am not sure about it, i cannot check it on my side right now.
Are you not able to build locally?
No, i am working locally but in the localhost3000(when i run ui version) the latest data point that is showing is only 2024-04-26. I cannot see further informations beyond that point.
@llxia - Is that something you can help with?
To clarify, there could be 2 dates in java -version. For example:
16:38:54 =JAVA VERSION OUTPUT BEGIN=
16:38:54 openjdk version "21.0.4-beta" 2024-07-16
16:38:54 OpenJDK Runtime Environment Temurin-21.0.4+6-202406261902 (build 21.0.4-beta+6-ea)
16:38:54 OpenJDK 64-Bit Server VM Temurin-21.0.4+6-202406261902 (build 21.0.4-beta+6-ea, mixed mode, sharing)
16:38:54 =JAVA VERSION OUTPUT END=
- 2024-07-16 - release date
- 202406261902 - build date
The original issue is asking for getting the build date (not the release date). If there is no such a date, set null. We should not set a random date.
I had fixed the changes. Please tell me if i have more things to change or update!!
@Sangyoon21 could you rerun your test? Thanks
I fixed it and here is the result of the test cases. I think it works now!