aqa-test-tools icon indicating copy to clipboard operation
aqa-test-tools copied to clipboard

Read config info for Data Collection Pipeline

Open LongyuZhang opened this issue 4 years ago • 3 comments

Config file (https://github.com/adoptium/aqa-test-tools/pull/480) for Data Collection Pipeline can be loaded in main function in collect_data. This value can be stored as variable config_info, while two important keys in it are trss_servers and GitHub_credentials for now. Related Issue: https://github.com/adoptium/aqa-test-tools/issues/412 https://github.com/adoptium/aqa-test-tools/issues/460

LongyuZhang avatar Jun 28 '21 21:06 LongyuZhang

Does it make sense to have separated files? One contains sensitive information and one does not.

llxia avatar Jun 29 '21 14:06 llxia

Currently two info we need in the config file are trss_servers and GitHub_credentials. For trss_servers, should we take internal trss server link as sensitive info too? Or we store Adoptium trss server in non-sensitive config file, and internal trss server in sensitive info file? Thanks.

Does it make sense to have separated files? One contains sensitive information and one does not.

LongyuZhang avatar Jun 29 '21 14:06 LongyuZhang

Discussed with Lan, we will have two config files:

  • The existing one for trss_servers, should add it to gitignore.file;
  • Create a new one for GitHub credential, and add it to gitignore.file too;
  • With the new config file, update main function of collect_data to read GitHub credential from it if exists.

LongyuZhang avatar Jun 30 '21 19:06 LongyuZhang