aqa-test-tools icon indicating copy to clipboard operation
aqa-test-tools copied to clipboard

Update jdkDate parser for various java version

Open OscarQQ opened this issue 4 years ago • 7 comments

Our current parser looks for yyyymmdd https://github.com/AdoptOpenJDK/openjdk-test-tools/blob/67ae218ec906fb9168bd81a9de87f090d5c2d701/TestResultSummaryService/parsers/Parser.js#L12 while hot spot and corretto has the form yyyy-mm-dd ex. https://ci.adoptopenjdk.net/job/Test_openjdk11_corretto_sanity.perf_x86-64_linux/296/consoleFull

09:43:21  =JAVA VERSION OUTPUT BEGIN=
09:43:21  openjdk version "11.0.11" 2021-04-20
09:43:21  OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.11+1)
09:43:21  OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.11+1, mixed mode)
09:43:21  =JAVA VERSION OUTPUT END=

OscarQQ avatar Feb 16 '21 05:02 OscarQQ

closed by https://github.com/AdoptOpenJDK/openjdk-test-tools/pull/362

OscarQQ avatar Feb 16 '21 19:02 OscarQQ

18:42:33  =JAVA VERSION OUTPUT BEGIN=
18:42:33  openjdk version "11.0.11" 2021-04-20
18:42:33  OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.11+5-202103050214)
18:42:33  Eclipse OpenJ9 VM AdoptOpenJDK (build master-d780e8d8b, JRE 11 Linux amd64-64-Bit Compressed References 20210305_78 (JIT enabled, AOT enabled)
18:42:33  OpenJ9   - d780e8d8b
18:42:33  OMR      - 19483f8eb
18:42:33  JCL      - 83787478bb based on jdk-11.0.11+5)
18:42:33  =JAVA VERSION OUTPUT END=

TRSS will grab 2021-04-20 as jdkDate while 20210305 makes more sense to me, I am wondering how we come up with a java version in the future..

link: internal_jenkins_server/Test_openjdk11_j9_sanity.perf_x86-64_linux/732/consoleFull

OscarQQ avatar Mar 11 '21 00:03 OscarQQ

@smlambert A lot of builds have

openjdk version "11.0.11" 2021-04-20

ex. https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_sanity.perf_x86-64_linux/481/consoleFull https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_sanity.perf_x86-64_linux/478/ https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_sanity.perf_x86-64_linux/477/ where 2021-04-20 hasn't come yet...

OscarQQ avatar Mar 21 '21 22:03 OscarQQ

hs has java version as

13:09:49  =JAVA VERSION OUTPUT BEGIN=
13:09:49  openjdk version "1.8.0_292-internal"
13:09:49  OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_292-internal-202103081818-b05)
13:09:49  OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.292-b05, mixed mode)
13:09:49  =JAVA VERSION OUTPUT END=

example link: https://ci.adoptopenjdk.net/job/Test_openjdk8_hs_sanity.perf_x86-64_linux/674/consoleFull Our TRSS parser regex is /\s([0-9]{4})-?(0[1-9]|1[012])-?(0[1-9]|[12][0-9]|3[01])/ which will look for a space first, which now it should be a '-'

OscarQQ avatar Mar 22 '21 00:03 OscarQQ

where 2021-04-20 hasn't come yet...

That's the release date. 11.0.11 will come out on that day.

aahlenst avatar Mar 22 '21 05:03 aahlenst

is this the same as https://github.com/adoptium/aqa-test-tools/issues/449?

smlambert avatar Jun 26 '21 01:06 smlambert

I think the PR of this issue caused #449.

llxia avatar Jun 28 '21 13:06 llxia