aqa-test-tools icon indicating copy to clipboard operation
aqa-test-tools copied to clipboard

Update PerfNext Delimiters for TRSS Benchmark Parser

Open piyush286 opened this issue 5 years ago • 0 comments

Problem Description

In order for TRSS to extract perf results from Adopt perf builds (https://github.com/AdoptOpenJDK/openjdk-test-tools/issues/136), we had to change the regexes in https://github.com/AdoptOpenJDK/openjdk-test-tools/pull/159 that benchmark parser uses to find different tests within a Jenkins build and extra relevant info such as benchmark name, variant and SDK resource.

Proposed Changes

  • We need to update the hard-coded strings in the snippet below so that Jenkins builds launched by PerfNext can be parsed by TRSS.

https://github.com/AdoptOpenJDK/openjdk-test-tools/blob/be9fbd0d28fb7a0b6a82e85aec4702bee42a9113/PerfNext/app/apis/BenchEngine/parser.js#L329-L345

  • For benchmark test delimiter, we should conform to https://github.com/AdoptOpenJDK/openjdk-test-tools/blob/6454a706534e4a9b089e73fa3ac266746bf32d02/TestResultSummaryService/parsers/Test.js#L2

Running test <Benchmark Name>_<Benchmark Variant> Example: Running test LibertyDayTrader3-9dev-4way-LargeThreadPool

  • For benchmark name and variant, see above. You can also refer to getBenchmarkInfo() in BenchmarkParser.js.

  • For SDK resource, we should conform to const sdkResourceRegex = /.*?SDK_RESOURCE\=(.*)[\r\n]/;. We should use releases, nightly, customized or upstream depending on the build selection. PerfNext doesn't print this info, but it can be added if needed.

piyush286 avatar Jan 14 '20 20:01 piyush286