aqa-test-tools icon indicating copy to clipboard operation
aqa-test-tools copied to clipboard

Show Aggregated Perf Results in Perf Graph View

Open piyush286 opened this issue 6 years ago • 3 comments

Problem Description

With https://github.com/AdoptOpenJDK/openjdk-test-tools/issues/73, we've added the ability to aggregate the perf results from multiple iterations. We should update Perf Graph View to use and display aggregated perf results in order to comply with the new design.

Proposed Changes

Besides the info that's already displayed, show all aggregated data for each build:

  • max
  • min
  • median
  • stddev
  • CI
  • iteration

Assigned Contributors

I'll be working with Sophia (@sophiaxu0424) from my team to add this feature.

piyush286 avatar May 03 '19 20:05 piyush286

We should break this into several steps:

  • [ ] make sure one Perf graph (i.e., ODM, SPECjbb, DT3, etc) works with the updated data structure

  • [ ] Add AcmeAir graph

  • [ ] Simplify the code for all Perf graphs #118

llxia avatar Jun 19 '19 14:06 llxia

  • [ ] make sure one Perf graph (i.e., ODM, SPECjbb, DT3, etc) works with the updated data structure

I have updated ODM.jsx and added extra info from aggregatiInfo set, having a new graph looks as below: Screen Shot 2019-11-14 at 4 38 59 PM

@piyush286 @llxia

sophiaxu0424 avatar Sep 24 '19 19:09 sophiaxu0424

Only ODM and AcmeAir graphs are updated to use aggregated perf results. Liberty and SPECjbb2015 graphs haven't been updated. Since we aren't really using any perf graphs for perf monitoring due to their current limitations, we can probably fix those after working on #118, not requiring any special changes for them.

piyush286 avatar Feb 29 '20 01:02 piyush286