api.adoptium.net icon indicating copy to clipboard operation
api.adoptium.net copied to clipboard

Temurin 23 binary builds not accessible through API

Open zakkak opened this issue 2 years ago • 6 comments

Describe the bug Looking at https://github.com/adoptium/temurin23-binaries/releases/ I see jdk-23+2-ea-beta being present, however when trying to get it using:

wget https://api.adoptium.net/v3/binary/latest/23/ea/linux/x64/jdk/hotspot/normal/eclipse

I get a 404 error.

To Reproduce

$ wget https://api.adoptium.net/v3/binary/latest/23/ea/linux/x64/jdk/hotspot/normal/eclipse

--2023-12-20 11:40:34--  https://api.adoptium.net/v3/binary/latest/23/ea/linux/x64/jdk/hotspot/normal/eclipse
Resolving api.adoptium.net (api.adoptium.net)... 20.62.244.126
Connecting to api.adoptium.net (api.adoptium.net)|20.62.244.126|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2023-12-20 11:40:35 ERROR 404: Not Found.

Expected behavior Get an EA build of JDK 23.

Device (please complete the following information):

  • OS: Linux
  • Browser: GNU Wget
  • Version: 1.21.3 built on linux-gnu

** Additional context **

Last time we faced this issue with JDK 22 it was a matter of redeploying the API endpoint with -DLATEST_JAVA_VERSION=22.

cc @johnoliver @jerboaa

zakkak avatar Dec 20 '23 09:12 zakkak

Last time we faced this issue with JDK 22 it was a matter of redeploying the API endpoint with -DLATEST_JAVA_VERSION=22

Yes. Probably needs a re-deploy with -DLATEST_JAVA_VERSION=23. /cc @sxa

jerboaa avatar Dec 20 '23 10:12 jerboaa

FYI @andrew-m-leonard

sxa avatar Dec 20 '23 13:12 sxa

@sxa @jerboaa @johnoliver I seem to remember the API does not currently support returning "tip" version assets, as I remember handling that condition on the daily Slack status code: https://github.com/adoptium/ci-jenkins-pipelines/blob/cb030764501de888c05ebbf6ac1a030731a3e72a/tools/nightly_build_and_test_stats.groovy#L245

andrew-m-leonard avatar Dec 21 '23 10:12 andrew-m-leonard

I'm not sure that's true. See the comments in #720 where we faced this last time. A redeploy of the API endpoint server with -DLATEST_JAVA_VERSION=23 should do the trick. At least it did it last time.

jerboaa avatar Dec 21 '23 12:12 jerboaa

should be there now

johnoliver avatar Jan 02 '24 13:01 johnoliver

@johnoliver Can you clarify what was done to fix this? We should have this documented as part of https://github.com/adoptium/temurin-build/wiki/Setting-up-new-build-jobs,-mirrors,...-when-a-new-openjdk-version-is-branched-from-jdk(head)

sxa avatar Jan 03 '24 10:01 sxa

@johnoliver Looks like we need the same fix for JDK 24 now. See #1077.

jerboaa avatar Jun 24 '24 14:06 jerboaa

@johnoliver Is there a way we can make this code dynamic? https://github.com/adoptium/api.adoptium.net/blob/9b536a207a01db1e8d3be0585504391bf439d03a/adoptium-models-parent/adoptium-api-v3-models/src/main/kotlin/net/adoptium/api/v3/models/Versions.kt#L5

eg.

  • by querying openjdk/jdk git "tags"
  • make Versions.version a dynamic list rather than a fixed Array
  • ditto Versions.ltsVersions

andrew-m-leonard avatar Jun 24 '24 15:06 andrew-m-leonard

@johnoliver Is there a way we can make this code dynamic?

https://github.com/adoptium/api.adoptium.net/blob/9b536a207a01db1e8d3be0585504391bf439d03a/adoptium-models-parent/adoptium-api-v3-models/src/main/kotlin/net/adoptium/api/v3/models/Versions.kt#L5

eg.

* by querying openjdk/jdk git "tags"

* make Versions.version a dynamic list rather than a fixed Array

* ditto Versions.ltsVersions

I've created #1083 to track this work.

jerboaa avatar Jul 03 '24 14:07 jerboaa

I'm closing this. If we need some documentation, we should use the newest one, which is #1077.

jerboaa avatar Jul 03 '24 14:07 jerboaa