TKG
TKG copied to clipboard
Mode definition inconsistencies in modes.xml
Some modes have inconsistent definitions of clArg and envVar, as shown below:
Mode 122 and 622: The optlevel is warm in clArg, while envVar specifies hot:
- https://github.com/adoptium/TKG/blob/9db2f4162fc930a8a6980c685c5a7466cda63ee9/resources/modes.xml#L506-L507
- https://github.com/adoptium/TKG/blob/9db2f4162fc930a8a6980c685c5a7466cda63ee9/resources/modes.xml#L4038-L4039
Mode 208: Only envVar has -Xgcthreads${MAX_GC_THREADS}:
- https://github.com/adoptium/TKG/blob/9db2f4162fc930a8a6980c685c5a7466cda63ee9/resources/modes.xml#L2144-L2145
Those modes are unchanged since the initial contribution.
I am not going to fix this issue because I don't know the original intension of these modes. They don't seem to be used by OpenJ9 functional tests.
Yes, modes.xml was initially inherited from the Axxon system. From what I can see, only clArg is used and set via TKG. envVar is not used.
https://github.com/search?q=repo%3Aadoptium%2FTKG+clArg&type=code https://github.com/search?q=repo%3Aadoptium%2FTKG+envVar&type=code https://github.com/search?q=repo%3Aadoptium%2FTKG+OPENJ9_JAVA_OPTIONS&type=code