TKG icon indicating copy to clipboard operation
TKG copied to clipboard

Add maven dependency

Open jasonkatonica opened this issue 1 year ago • 1 comments

This update adds maven as a dependency to build and test the OpenJCEPlus project. As part of this effort other dependencies that were used in the past for this project have been removed.

Signed-off-by: Jason Katonica [email protected]

jasonkatonica avatar Jul 30 '24 20:07 jasonkatonica

This update is dependent upon https://github.com/adoptium/aqa-tests/pull/5479

jasonkatonica avatar Aug 01 '24 14:08 jasonkatonica

Checksum is skipped.

downloading https://dlcdn.apache.org/maven/maven-3/3.9.8/binaries/apache-maven-3.9.8-bin.tar.gz
--> file downloaded to ./apache-maven-bin.tar.gz
Checksum verification skipped for ./apache-maven-bin.tar.gz

Internal job

sha512 is wrong as there is no logic checking for sha512. https://github.com/adoptium/TKG/blob/8a8b966894abd79eedc5b304e110012d5e52e3aa/scripts/getDependencies.pl#L190

I think we should do something similar to https://github.com/adoptium/TKG/blob/8a8b966894abd79eedc5b304e110012d5e52e3aa/scripts/getDependencies.pl#L130-L132 change shaalg => '256' to shaalg => '512'

llxia avatar Aug 22 '24 19:08 llxia

Hi @llxia I attempted via commits https://github.com/adoptium/TKG/pull/591/commits/d07ba4683be0a6506aba6177bef289638b8739ea and https://github.com/adoptium/TKG/pull/591/commits/6867f76a6890eea07cbceb211291967daf58d902 and https://github.com/adoptium/TKG/pull/591/commits/a00e9f801164c87fca0ba45eb50a5c96983c688f to directly use the SHA512 hash file published on the website ran into issues with it recognizing either the hash value or the value of the file itself. My guess is that the URL does not end in .txt and is using 512 making it different ? In the end I simply placed the sha1 hash of the file into script for validation which seems to work now when I run it:

07:52:47       [exec] --------------------------------------------
07:52:47       [exec] Starting download third party dependent jars
07:52:47       [exec] --------------------------------------------
07:52:47       [exec] downloading dependent third party jars to C:/Users/jenkins/testDependency/lib
07:52:47       [exec] downloading https://dlcdn.apache.org/maven/maven-3/3.9.8/binaries/apache-maven-3.9.8-bin.tar.gz
07:52:47       [exec] --> file downloaded to C:/Users/jenkins/testDependency/lib/apache-maven-bin.tar.gz
07:52:47       [exec] downloaded dependent third party jars successfully

jasonkatonica avatar Aug 23 '24 11:08 jasonkatonica

Thanks for making it work.

llxia avatar Aug 23 '24 12:08 llxia

https://openj9-jenkins.osuosl.org/job/test.getDependency/1211/

llxia avatar Aug 23 '24 19:08 llxia