TKG icon indicating copy to clipboard operation
TKG copied to clipboard

Fetch jars and shas from same location

Open adamfarley opened this issue 1 year ago • 3 comments

If we are getting our third party dependent shas from a custom URL, then the jars should also come from the same location.

Resolves https://github.com/adoptium/aqa-tests/issues/5427

adamfarley avatar Jul 09 '24 12:07 adamfarley

Resolves https://github.com/adoptium/aqa-tests/issues/5427

adamfarley avatar Jul 09 '24 12:07 adamfarley

run tests

adamfarley avatar Jul 09 '24 12:07 adamfarley

PR needs some sample Grinders run

smlambert avatar Jul 13 '24 11:07 smlambert

@adamfarley Are there any updates on this PR?

llxia avatar Sep 04 '24 12:09 llxia

@adamfarley Are there any updates on this PR?

Hi Lan. Thanks for waiting. 🙂

I've included your requested change into the code, and I'm testing now. Link.

adamfarley avatar Sep 04 '24 14:09 adamfarley

Thanks @adamfarley

llxia avatar Sep 04 '24 14:09 llxia

Updated my code, resolved a merge conflict, and tested the change with a custom aqa-tests branch that cleans up the dependencies before trying to redownload them.

Ready for reviews and merge. 🙂

adamfarley avatar Sep 05 '24 14:09 adamfarley