TKG icon indicating copy to clipboard operation
TKG copied to clipboard

SPEC for hotspot IMPL JDK setting by AUTO_DETECT as without _cmprssptrs

Open sophia-guo opened this issue 5 years ago • 3 comments

Running with github action or running in developer's local environment without export SPEC EnvDetector will generate autoGenEnv.mk to setting DETECTED_SPEC. And DETECTED_SPEC will be set as SPEC as nodefine SPEC. https://github.com/AdoptOpenJDK/TKG/blob/master/envSettings.mk#L25

For non-openj9 JDK, DETECTED_SPEC will be set as without _cmprssptrs. https://github.com/AdoptOpenJDK/TKG/blob/master/src/org/openj9/envInfo/JavaInfo.java#L75

This is inconsistent with jenkins story, which set SPEC per platform. All non large heap 64 platforms is setting as _cmprssptrs. https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/buildenv/jenkins/openjdk_tests

Also this inconsistence is hidden by the check https://github.com/AdoptOpenJDK/TKG/blob/master/envSettings.mk#L33

sophia-guo avatar Mar 18 '20 20:03 sophia-guo

If we'd like hotspot impl jdk to run functional tests for compressedref the SPEC should be set as *_cmprssptrs? If that is the case I can update JavaInfo.java and envSettings.mk so nothing would be done on run-aqa action side.

sophia-guo avatar Mar 18 '20 20:03 sophia-guo

Also related to this is the work at OpenJ9 project to combine compressedrefs and non-compressedrefs SPECS into the same build (as is the case for hs and ibm sdks), not sure how soon its coming, but it will impact TKG and perhaps simplify what needs to be done from a test setup perspective. (see https://github.com/eclipse/openj9/pull/8906 as one PR, still looking to find the overall issue that describes this effort).

smlambert avatar Mar 18 '20 21:03 smlambert

(as is the case for hs and ibm sdks)

This is not the case for IBM SDKs - they are packaged with two VMs.

There is no overall issue for this work.

gacholio avatar Mar 19 '20 00:03 gacholio