Modifiers: using this.args is deprecated

[edflips]

Describe the bug We are seeing multiple deprecation warnings running:

• ember-sortable 2.2.3
• Ember 4.4.0
• ember-modifier 3.2.7

using this.args is deprecated. Access positional and named arguments directly in the modify hook instead. [deprecation id: ember-modifier.no-args-property] This will be removed in Ember 4.0.0.

To Reproduce Steps to reproduce the behavior:

1. Install the above packages
2. Implement a sortable list
3. Observe the modifier warnings

Expected behavior No warnings

[NullVoxPopuli]

Does the same happen with ember-sortable v4?

[barryofguilder]

@NullVoxPopuli I just installed v4 in my Ember 4.6 project and I'm seeing the modifier deprecation warnings.

[NullVoxPopuli]

makes sense -- I don't think anyone has submitted a PR to clean those up

[kaermorchen]

I have caught this deprecation too.

[email protected] [email protected]

Look like #487 should resolve this issue.