ember-pikaday icon indicating copy to clipboard operation
ember-pikaday copied to clipboard

Published 20 hours ago • verified publisher icon adopted-ember-addons

Update ember-modifier to allow 4.x

Open cah-brian-gantzler opened this issue 1 year ago • 6 comments

Please extend the range of ember modifier to use 3.x and 4.x

cah-brian-gantzler avatar Apr 18 '23 20:04 cah-brian-gantzler

I just wasted way too much time troubleshooting why ember-pikaday broke during my Ember 4 upgrade only to discover this fix has been committed to master but a new version has not been released. A version 4.0.1 would be really nice.

tythewebguy avatar Oct 05 '23 15:10 tythewebguy

:) Pretty sure I asked already a couple times to have a new release. You said ember 4, but think you mean ember-modifier 4 and yes, waiting on the same thing.

cah-brian-gantzler avatar Oct 05 '23 16:10 cah-brian-gantzler

I'm in the process of upgrading our project to Ember 4 and yes, ember-pikaday broke because of the ember-modifier version. Your post here helped me figure out the problem and get it fixed. You saved me a lot frustration—THANK YOU!

tythewebguy avatar Oct 05 '23 16:10 tythewebguy

It would be a real pleasure to see this problem resolved. This seems to be already fixed in master. Is this just a release that needs to be done?

Can we help in any way?

cloutierlp avatar Oct 30 '23 18:10 cloutierlp

Does the latest release fix this?

herzzanu avatar Jan 29 '24 22:01 herzzanu

I believe it does.

However now the `@ember/test-helpers' could use its range extended to include 3

cah-brian-gantzler avatar Feb 10 '24 17:02 cah-brian-gantzler