ember-light-table icon indicating copy to clipboard operation
ember-light-table copied to clipboard

fix(lt-body): scrollToRow before render

Open FalkF opened this issue 4 years ago • 1 comments

When changing the scrollToRow before newly added rows are rendered targetScrollOffset can not be calculated:

this.table.addRows(data);
const targetRow = this.table.rows.find(element => element.get('name') === 'target');
set(this, 'scrollToRow', targetRow);

This can be worked around by changing scrollToRow in the next runloop, but it would be cool to just make it work.

FalkF avatar Mar 25 '20 19:03 FalkF

@FalkF Thanks for the PR! We've recently made a lot of significant changes to ember-light-table. Can you please rebase your PR and make sure everything is still working as intended? If this PR is no longer necessary after the new changes, please close it. Thanks!

RobbieTheWagner avatar Jul 19 '22 14:07 RobbieTheWagner