ember-file-upload icon indicating copy to clipboard operation
ember-file-upload copied to clipboard

Published 20 hours ago • verified publisher icon adopted-ember-addons

feat(test-support): allow selectFiles input to be an element or a css selector

Open gvdp opened this issue 2 years ago • 2 comments

Using the test support helpers in our own projects we had the need to have the input of this method be an element instead of a string selector, so I added the option.

gvdp avatar Aug 05 '22 12:08 gvdp

Hey @gvdp thanks for opening this 👋🏻

I'd be happy to accept this enhancement with a few additions:

  • make the same change to all test helper functions exported from this file
  • update the JSDoc comments for all test helpers also

gilest avatar Aug 08 '22 11:08 gilest

Thanks for the feedback @gilest !

I implemented the change for all the methods in the test-support file. Not super familiar with JSDoc, I hope I did that right. Should I maybe also add an example of the HTMLElement input option?

gvdp avatar Aug 10 '22 14:08 gvdp

Was finished in #840

gilest avatar Aug 30 '22 07:08 gilest

Was finished in #840

Great! Thanks for picking this up 👍

gvdp avatar Sep 01 '22 07:09 gvdp