ember-data-model-fragments icon indicating copy to clipboard operation
ember-data-model-fragments copied to clipboard

Array attribute typing seems to be wrong

Open canrozanes opened this issue 2 years ago • 1 comments

The following line suggest that array attribute takes in two arguments, type and options. https://github.com/adopted-ember-addons/ember-data-model-fragments/blob/cfa5e5e1716d2508a13a0e973cf5b51c45bedb79/addon/attributes.js#L151

Whereas the existing type information defined in the line below suggest array attribute does not take any arguments: https://github.com/adopted-ember-addons/ember-data-model-fragments/blob/cfa5e5e1716d2508a13a0e973cf5b51c45bedb79/attributes.d.ts#L33

canrozanes avatar Feb 15 '23 17:02 canrozanes

Looks like the types need updating, since the options are used for { defaultValue }. https://github.com/adopted-ember-addons/ember-data-model-fragments/blame/cfa5e5e1716d2508a13a0e973cf5b51c45bedb79/addon/attributes.js#L129

knownasilya avatar Feb 15 '23 17:02 knownasilya