ember-data-model-fragments icon indicating copy to clipboard operation
ember-data-model-fragments copied to clipboard

RangeError: Maximum call stack size exceeded with ED 3.14

Open IAmJulianAcosta opened this issue 5 years ago • 7 comments

Tested on brand new Ember install:

DEBUG: -------------------------------
DEBUG: Ember           : 3.14.1
DEBUG: Ember Data      : 3.14.0
DEBUG: Model Fragments : 4.0.0
DEBUG: -------------------------------
Uncaught (in promise) RangeError: Maximum call stack size exceeded
    at new CoreStore (-private.js:12583)
    at new Store (-private.js:15820)
    at Function.create (core_object.js:673)
    at FactoryManager.create (index.js:552)
    at instantiateFactory (index.js:362)
    at lookup (index.js:290)
    at processInjections (index.js:403)
    at buildInjections (index.js:419)
    at injectionsFor (index.js:434)
    at FactoryManager.create (index.js:499)

The problem is in CoreStore constructor

IAmJulianAcosta avatar Nov 18 '19 16:11 IAmJulianAcosta

Same issue here...

gwak avatar Nov 19 '19 17:11 gwak

Ember-Data 3.13+ isn't supported yet. There is a WIP PR at https://github.com/lytics/ember-data-model-fragments/pull/339 and an issue at https://github.com/lytics/ember-data-model-fragments/issues/338

jakesjews avatar Nov 19 '19 17:11 jakesjews

Thanks @jakesjews , I'm aware of this and downgraded to 3.12, just wanted to make sure that this was tracked

IAmJulianAcosta avatar Nov 19 '19 23:11 IAmJulianAcosta

no problem @IAmJulianAcosta! This ticket reminded me that I needed to update the readme so it was helpful.

jakesjews avatar Nov 20 '19 00:11 jakesjews

@jakesjews Would be awesome if you add an assertion that Ember Data is 3.12 or less. Maybe just a peerDependency? This error is hard to debug as the error is thrown very early and does not contain any helpful information.

jelhan avatar Nov 29 '19 12:11 jelhan

I was getting this error on what appeared to be compatible versions: https://github.com/lytics/ember-data-model-fragments/issues/224#issuecomment-573101228

    "ember-data": "^3.11.0",
    "ember-data-model-fragments": "^4.0.0",
    "ember-source": "~3.7.3",

^ I'm playing around with versions and I'm still seeing this. Here's my pull package json: https://github.com/NYCPlanning/ceqr-app/blob/548-fragments-for-transportation-planning-factors-model/package.json

RangeError: Maximum call stack size exceeded at new DefaultStore (http://localhost:4200/assets/vendor.js:154064:3) at Function.create (http://localhost:4200/assets/vendor.js:39430:22) at FactoryManager.create (http://localhost:4200/assets/vendor.js:16274:39) at instantiateFactory (http://localhost:4200/assets/vendor.js:16134:69) at lookup (http://localhost:4200/assets/vendor.js:16093:16) at processInjections (http://localhost:4200/assets/vendor.js:16159:34) at buildInjections (http://localhost:4200/assets/vendor.js:16172:13) at injectionsFor (http://localhost:4200/assets/vendor.js:16184:16) at FactoryManager.create (http://localhost:4200/assets/vendor.js:16232:49) at instantiateFactory (http://localhost:4200/assets/vendor.js:16134:69)

RangeError: Maximum call stack size exceeded at Arguments.values () at Registry.resolve (http://localhost:4200/assets/vendor.js:16445:41) at has (http://localhost:4200/assets/vendor.js:16826:25) at Registry.has (http://localhost:4200/assets/vendor.js:16527:20) at Registry.proto.validateInjections (http://localhost:4200/assets/vendor.js:16776:35) at processInjections (http://localhost:4200/assets/vendor.js:16148:36) at buildInjections (http://localhost:4200/assets/vendor.js:16172:13) at injectionsFor (http://localhost:4200/assets/vendor.js:16184:16) at FactoryManager.create (http://localhost:4200/assets/vendor.js:16232:49) at instantiateFactory (http://localhost:4200/assets/vendor.js:16134:69)

This is weird, I'm completely stuck. Switching around versions doesn't seem to do anything. I still see this error everywhere. When I remove the addon, it goes away. It's bizarre that I was able to develop a feature with it with no problem. When I upgraded yarn, however, a large number of things were changed in the generated yarn.lock. I don't know what caused them or why, but it could be that some version drift somewhere changed some nuance and now simply having the addon in the app breaks it.

allthesignals avatar Jan 10 '20 17:01 allthesignals

This is fixed in ED 3.17.1 and 3.18. It was a bug in the ED store.

BryanCrotaz avatar May 07 '20 00:05 BryanCrotaz