[bug] ensure that SassCompiler is not run on files that are not (.scss|.sass|.css)

[gabrielcsapo]

Motivation

#214 #178

The sass compiler has an unintended overhead when running in projects as it rebuilds when it is not necessary.

What happens after this change?

When changing a .scss file

> When changing a non `.scss` file

screenshot produced using broccoli-inspector

This results in a net savings for rebuilds of 50%!

Change itself

• Why was broccoli-sass-source-maps copied into the project? I was hoping to have a discussion around this change before opening up two PRs. In the context of ember it might make sense to care about the buildStart time where as in the more generic broccoli-sass-source-maps it would be better to not have a filter between file changes. Sass is different thenjs and hbs where the build output is the result of running sass on the top level input file. hbs and js can be altered and combined at the end of the build.

[gabrielcsapo]

@simonexmachina would you be able to review this?

[gabrielcsapo]

@rwjblue updated based on your suggestions and also broke up the node upgrade as a separate PR. https://github.com/adopted-ember-addons/ember-cli-sass/pull/216

[gabrielcsapo]

@rwjblue this seems to be plaguing many others would you be able to see if we can merge this?

[robclancy]

This is just not cared about anymore? Is there a version I can revert to for this?

[vlascik]

Any chance this will get merged soon? This PR seems to have worked, SassCompiler is gone from e-cli rebuild slowest nodes list.

I'm still having a pretty slow entry for Concat: Vendor Styles/assets/vendor.css (1) | 838ms when rebuilding .js/.ts.

Is this also caused by this addon, or does it come from somewhere else?

[knownasilya]

Looks like there is still some feedback that needs to be addressed before this can be merged.