ember-cli-sass icon indicating copy to clipboard operation
ember-cli-sass copied to clipboard

"sassOptions should be moved to your ember-cli-build" deprecation warning should be removed

Open minusfive opened this issue 7 years ago • 3 comments

When used as a nested addon, and sassOptions are passed through the config() addon hook, this deprecation warning is still shown, even though it seems like the correct way of doing it, no?

minusfive avatar Oct 19 '17 15:10 minusfive

I'm not working with Ember at the moment, so I can't really say. PRs are welcome though. @stefanpenner might be able to advise?

simonexmachina avatar Oct 20 '17 01:10 simonexmachina

Wanted to bring this back up; I'm using this in a nested addon as well, and there's no way around it. I can ignore the warning for now, but I'd like for it to be considered "officially ok" behavior :)

deanpapastrat avatar Feb 04 '19 07:02 deanpapastrat

@deanpapastrat I agree. I am the author of ember-cli-mdc. One of the reasons I wrote my own sass wrapper for ember-cli-mdc several years ago was because of this very issue. I have decided to migrate back to ember-cli-sass, and this behavior still exists. It would be great if this warning could be removed when using ember-cli-sass from within an add-on.

hilljh82 avatar Jan 12 '21 20:01 hilljh82