ember-cli-hot-loader icon indicating copy to clipboard operation
ember-cli-hot-loader copied to clipboard

Published 20 hours ago • verified publisher icon adopted-ember-addons

Support for ember-cli v3.4

Open toranb opened this issue 6 years ago • 6 comments

Ember 3.4 stable was released today and seems to be working fine w/ ember-cli v3.3.0

https://github.com/toranb/ember-hot-reload-demo/commit/3d25f9d9485ded7ca590bde96b3e42ba8d16aabe

That said, I manually tested with ember-cli v3.4.0-beta.3 today and it's not live/or hot reloading at the moment (maybe? because of this PR that landed recently)

toranb avatar Aug 29 '18 23:08 toranb

A little follow up - found that I need to craft a web socket connection to push an event to the client w/ the changed information we sent previously over http as shown below. I'll dive into this after my talk next week :)

http://localhost:7020/changed?files=/foo/bar

toranb avatar Sep 16 '18 14:09 toranb

I have the same issue. Any update?

GCorbel avatar Oct 13 '18 18:10 GCorbel

@GCorbel thanks for keeping me honest! I’ve got Friday the 19th off and plan to dive in before lunch (as I’ve ignored this otherwise). Thanks for bringing it to my attention today!

toranb avatar Oct 13 '18 23:10 toranb

Thanks, let me know if I can help.

GCorbel avatar Oct 14 '18 16:10 GCorbel

I've also noticed a break when using the latest ember-resolver v5.0.1 (looking into that along w/ the web socket issue). This commit specifically broke the world (for reference).

toranb avatar Oct 19 '18 16:10 toranb

@GCorbel I burned a good deal of the day just looking into the resolver issues and came away empty handed. I think this addon now has 2 defects worth tracking that need fixed to get this functional again for ember-cli > 3.3

I'll open an issue for the resolver work but if you have some bandwidth to help triage and fix this web socket regression I'd welcome it. I don't set aside much OSS time for this addon anymore personally but I still think it offers a lot of raw productivity when it is functional.

I'm happy to hand this off to you/ or anyone else who might have more dedicated time to restore it. I've also reached out to someone within a bigger company to pitch them on taking it over (and giving it the dedication it needs to survive).

Apologies for my lack of finish today -let me know if you decide to jump in and hack away on this

toranb avatar Oct 19 '18 20:10 toranb