ember-cli-hot-loader icon indicating copy to clipboard operation
ember-cli-hot-loader copied to clipboard

Published 20 hours ago • verified publisher icon adopted-ember-addons

Components not wrapped in HMR container

Open joshkadis opened this issue 6 years ago • 4 comments

Howdy, thanks @toranb and crew for your work on this! I'm finding that my components are not being wrapped in the HMR containing element. Any thoughts on why this would be the case?

I imagine you'd need some additional info in order to answer that; I'm new to Ember so let me know what details I can provide. Thanks 🙌

joshkadis avatar Dec 03 '18 17:12 joshkadis

@joshkadis hey thanks for writing! This addon only works with ember-cli < 3.4 :) so assuming you are between ember 2.12-3.3 .... did you run the ember install command? As part of that execution did you say "yes" or "no" to the question about updating your resolver?

toranb avatar Dec 03 '18 23:12 toranb

Using ember-cli: 3.1.3, installed with ember install, resolver.js looks like the example you provided. It looks like this shouldn't matter any longer, but my environment is called local instead of development

joshkadis avatar Dec 04 '18 15:12 joshkadis

@joshkadis you can try ember-ast-hot-load addon

lifeart avatar Dec 09 '18 14:12 lifeart

@joshkadis could you reproduce the issue in a tiny ember app? I'd be happy to look it over at some point but without a broken ember-cli baseline it might be tough to diagnose the issue.

Also, the work @lifeart is doing might be of interest. He is a more active maintainer and his project works with ember-cli 3.4+

toranb avatar Dec 10 '18 12:12 toranb