v5-docs icon indicating copy to clipboard operation
v5-docs copied to clipboard
verified publisher icon adonisjs

docs: use subpath exports to import core module

Open targos opened this issue 4 years ago • 5 comments

This can only land after a release with https://github.com/adonisjs/core/pull/2796 is published.

targos avatar Jun 16 '21 07:06 targos

Actually, we should not only wait for a release of the subpath exports, but also for TypeScript to support this feature (otherwise it says that the module cannot be found). I don't know why TS takes so much time to implement it...

targos avatar Jun 19 '21 09:06 targos

TS issue: https://github.com/microsoft/TypeScript/issues/33079

targos avatar Jun 19 '21 10:06 targos

So, if I get it right. We should hold the releasing this https://github.com/adonisjs/core/pull/2796 until the TypeScript issue has been resolved?

thetutlage avatar Jun 20 '21 12:06 thetutlage

So, if I get it right. We should hold the releasing this adonisjs/core#2796 until the TypeScript issue has been resolved?

No, we should just hold telling people to use it.

targos avatar Jun 20 '21 12:06 targos

But we need https://github.com/adonisjs/core/pull/2813 to fix a bug I introduced in the other PR.

targos avatar Jun 20 '21 12:06 targos