persona icon indicating copy to clipboard operation
persona copied to clipboard
verified publisher icon adonisjs

fix(*): correct mistakes in word

Open yariksav opened this issue 7 years ago • 7 comments

yariksav avatar Jun 20 '18 07:06 yariksav

Pull Request Test Coverage Report for Build 34

  • 2 of 6 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.0%) to 91.534%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Persona.js 2 6 33.33%
<!-- Total: 2 6
Totals Coverage Status
Change from base Build 33: -2.0%
Covered Lines: 136
Relevant Lines: 145
💛 - Coveralls

coveralls avatar Jun 20 '18 07:06 coveralls

Nice!

I believe we can release it as a breaking change update but since it's not critical we can wait a little bit.

RomainLanz avatar Jun 22 '18 06:06 RomainLanz

Also we can add a depreciation notice to the existing method and then remove it later in the next major release.

thetutlage avatar Jun 22 '18 06:06 thetutlage

@yariksav Lemme know if you need any guidance

thetutlage avatar Jun 22 '18 06:06 thetutlage

I've added deprecation methods, and fixed one more mistake in massageRegisterationData

yariksav avatar Jun 22 '18 07:06 yariksav

massageRegistrationData is not a mistake.

You have change massage to message whereas massage itself is a word and used intentionally

thetutlage avatar Jun 25 '18 03:06 thetutlage

@thetutlage, sorry, it misunderstanding, I've fixed it

yariksav avatar Jun 25 '18 08:06 yariksav