core
core copied to clipboard
adonisjs
feat: add support for installing specific versions of packages
🔗 Linked issue
This enables what's described in https://github.com/adonisjs/ace/issues/163
However, I cannot think of a way to actually test this, since @antfu/install-pkg doesn't provide a way to not actually do anything (i.e., run under test)
❓ Type of change
- [ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
- [ ] 👌 Enhancement (improving an existing functionality like performance)
- [x] ✨ New feature (a non-breaking change that adds functionality)
- [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
📚 Description
Currently when using node ace add <package> it's not possible to install a prerelease or specific released version of a package, so if we have @adonisjs/transmit releasing a prerelease of v5.0.0-next.0 which isn't the latest tag, but the next tag, we can't install that through node ace add, instead we'd have to install manually via package.json the specific version, and then call node ace configure <package> separately.
The way the tests are written, I cannot see a way to actually add test coverage for this.
📝 Checklist
- [ ] I have linked an issue or discussion.
- [ ] I have updated the documentation accordingly.
This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Haven't had time to progress on this, but I still think it's a good feature if we can figure out how to reasonably test it.
This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request
This pull request has been automatically closed because it has been inactive for more than 4 weeks. Please reopen if you still intend to submit this pull request
This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request
This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request
This pull request has been automatically closed because it has been inactive for more than 4 weeks. Please reopen if you still intend to submit this pull request
This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request
This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request
This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request
This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request
This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request
@thetutlage the thing this stalled on was how to test it. I still don't have good ideas on that, but maybe we need a few stub packages just for the tests?
This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request