vscode-extension icon indicating copy to clipboard operation
vscode-extension copied to clipboard

Feat(Snippets): Add Edge and Adonis Snippets

Open toksdotdev opened this issue 5 years ago • 8 comments

Resolves #4.

toksdotdev avatar Dec 19 '19 17:12 toksdotdev

I was considering prefixing all the snippet triggers with ad:.

Although, prefixing might not eventually be necessary considering that we could restrict the extension to run only in an adonis project (#10).

Pros:

  • Easy to understand
  • Easy to distinguish adonis snippets from vscode suggestions.

Cons:

  • Extra 3 characters (hence making commands longer to type).

toksdotdev avatar Dec 19 '19 17:12 toksdotdev

@TNkemdilim @thetutlage When is this extension going to get released to marketplace

Any fixed date?

guledali avatar May 13 '20 09:05 guledali

Some of the work is still pending and the final polishing. Not 100% sure, when I'll begin working on it. But happy, you or someone else wants to pick up the development

thetutlage avatar May 13 '20 10:05 thetutlage

So far, the major pending tasks (asides from final polishing) includes:

  • Merging the snippets into master (status: completed);

Decision about prefixing the snippets commands is yet to be concluded on as mentioned earlier in this thread.

There are still deliberations on whether to ship the vscode html language server with the extension or write a custom one, considering that it'll increase the download size of the extension (a comparison of compiled extension size from both will be performed to see if it's worth a tradeoff).

  • Documentation of internal workings.

I'll work on completing the above at the latter part of this month. Although, would really appreciate if you could join in the development.

toksdotdev avatar May 13 '20 11:05 toksdotdev

@TNkemdilim

I was actually thinking to release the extensions in multiple phases.

  • In the first phase, we can ship with the autocompletion of controllers and edge templates, along with Edge syntax support
  • The 2nd phase will be swap adonis cli commands with node ace. Initially, we wrote the extension by keeping adonis cli in mind, but now the landscape has changed.
  • Add .adonisrc.json schema file for JSON autocomplete.

thetutlage avatar May 13 '20 11:05 thetutlage

So it will be matter of creating a few branches, each dedicated to a single release.

thetutlage avatar May 13 '20 11:05 thetutlage

@thetutlage

Releasing incrementally is definitely a great idea.

Would you suggest releasing the edge snippets initially?

What i'll need to do:

  • [x] Create the expected releases into separate branches.
  • [ ] Check the ace CLI tasks in v5 for breaking changes.
  • [ ] Highlight what needs to be done for v5 compatibility on the project board.

toksdotdev avatar May 13 '20 11:05 toksdotdev

@TNkemdilim @thetutlage It has been over a month now, any updates?

guledali avatar Jun 22 '20 13:06 guledali