light-service icon indicating copy to clipboard operation
light-service copied to clipboard

Rename LightService from light-service to light_service

Open adomokos opened this issue 9 years ago • 9 comments

This is the recommended naming pattern. I chose light-service based on a blog post I read at the time when I started LightService, but I think now that the name is misleading.

I am not alone with this unique naming convention. The project RestClient follows the same naming convention.

I would be curious to see what other folks are thinking about the possibility of renaming the gem from light-service to light_service.

adomokos avatar May 18 '15 20:05 adomokos

Also noticed this before. Never bothered opening an issue for it, but :+1:

padi avatar May 18 '15 21:05 padi

Yes, light_service, since the project isn't Light::Service.

ramontayag avatar Jun 18 '15 05:06 ramontayag

:+1:

variousred avatar Apr 14 '16 22:04 variousred

This is actually not all that easy. There is no rename in RubyGems, I have to close the current LightService repo, open up a new one with the new name and continue development on that. Which might make sense as we approach 1.0.

Does anybody else have a simpler, less invasive resolution to this?

adomokos avatar Jun 16 '16 14:06 adomokos

How about making a new one and publishing to both, abandoning (possibly with deprecation warnings to STDOUT) the old?

jeroenvisser101 avatar Jun 16 '16 14:06 jeroenvisser101

That's a pretty good idea! Thank you for suggesting that.

adomokos avatar Jun 16 '16 15:06 adomokos

@adomokos thanks — I haven't tested that yet, but in theory, it should work.

jeroenvisser101 avatar Jun 16 '16 15:06 jeroenvisser101

Apologies for the bump on an ancient issue, but I would also add a spec.post_install_message to the gemspec for the deprecated version.

There are docs for post_install_message functionality.

gee-forr avatar Oct 09 '16 16:10 gee-forr

I think we know what we want to do with this. I am proposing closing it for now.

adomokos avatar Jun 29 '18 21:06 adomokos