milo icon indicating copy to clipboard operation
milo copied to clipboard

MWPW-184268: Add uppercase styling to merch-sidenav h2 titles

Open joaquinrivero opened this issue 1 month ago • 3 comments

Summary

  • Added text-transform: uppercase; to :host h2 style rule in merch-sidenav component

Test URLs

Before: https://main--milo--adobecom.aem.page/drafts/rivero/products/catalog?martech=off

After: https://mwpw-184268--milo--joaquinrivero.aem.page/drafts/rivero/products/catalog?maslibs=MWPW-182305--mas--adobecom&martech=off

Visual Impact

All h2 titles in the merch-sidenav component will now display in uppercase across catalog pages.

Resolves: MWPW-184268

joaquinrivero avatar Nov 23 '25 00:11 joaquinrivero

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

github-actions[bot] avatar Nov 23 '25 02:11 github-actions[bot]

@joaquinrivero Nala failures needs to be fixed for merging. one of test expecting the email/pass env variables - i think they are missing in your branch/fork. > 63 | expect(process.env.EMAIL_COLLECTION_IMS_MAIL, 'ERROR: No environment variable found for EMAIL_COLLECTION_IMS_MAIL').toBeTruthy(); | ^ 64 | expect(process.env.EMAIL_COLLECTION_IMS_PASS, 'ERROR: No environment variable found for EMAIL_COLLECTION_IMS_PASS').toBeTruthy();

Roycethan avatar Nov 24 '25 20:11 Roycethan

Test are good after applying @nateekar suggestion:

tags: '@emailCollection @smoke @regression @milo @nopr'

See threat

joaquinrivero avatar Nov 25 '25 03:11 joaquinrivero

Error merging 5154: MWPW-184268: Add uppercase styling to merch-sidenav h2 titles Pull Request is not mergeable

milo-pr-merge[bot] avatar Dec 02 '25 09:12 milo-pr-merge[bot]