milo icon indicating copy to clipboard operation
milo copied to clipboard
verified publisher icon adobecom

[MWPW-167902] - Updated links and primary CTA colors to make it consistant across the milo pages.

Open Deva309 opened this issue 2 months ago • 5 comments

Updated links and primary CTA colors to make it consistant across the milo pages.

Resolves: MWPW-167902

Test URLs:

  • Before: https://main--milo--adobecom.aem.page/?martech=off
  • After: https://mwpw-167902--milo--deva309.aem.page/?martech=off

QA: https://main--cc--adobecom.aem.page/drafts/devashish/test?milolibs=mwpw-167902--milo--deva309

GNav Test URLs

Gnav + Footer + Region Picker modal:

  • Acrobat: https://main--dc--adobecom.aem.live/acrobat?martech=off&milolibs=mwpw-167902--milo--adobecom
  • BACOM: https://main--da-bacom--adobecom.aem.live/?martech=off&milolibs=mwpw-167902--milo--adobecom
  • CC: https://main--cc--adobecom.aem.live/creativecloud?martech=off&milolibs=mwpw-167902--milo--adobecom
  • Milo: https://mwpw-167902--milo--adobecom.aem.page/drafts/blaishram/test-urls/page?martech=off
  • Express: https://main--express-milo--adobecom.aem.live/express/?martech=off&milolibs=mwpw-167902--milo--adobecom
  • News: https://main--news--adobecom.aem.live/?martech=off&milolibs=mwpw-167902--milo--adobecom
  • Homepage: https://main--homepage--adobecom.aem.live/homepage/index-loggedout?martech=off&milolibs=mwpw-167902--milo--adobecom

Thin Gnav + ThinFooter + Region Picker dropup:

  • Acrobat: https://main--dc--adobecom.aem.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-167902--milo--adobecom
  • BACOM: https://main--da-bacom--adobecom.aem.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-167902--milo--adobecom
  • CC: https://main--cc--adobecom.aem.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-167902--milo--adobecom
  • Milo: https://mwpw-167902--milo--adobecom.aem.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off
  • Express: https://main--express-milo--adobecom.aem.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-167902--milo--adobecom
  • News: https://main--news--adobecom.aem.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-167902--milo--adobecom
  • Homepage: https://main--homepage--adobecom.aem.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-167902--milo--adobecom

Localnav + Promo:

  • Acrobat: https://main--dc--adobecom.aem.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-167902--milo--adobecom
  • BACOM: https://main--da-bacom--adobecom.aem.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-167902--milo--adobecom
  • CC: https://main--cc--adobecom.aem.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-167902--milo--adobecom
  • Milo: https://mwpw-167902--milo--adobecom.aem.page/drafts/blaishram/test-urls/page-with-promo?martech=off
  • Express: https://main--express-milo--adobecom.aem.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-167902--milo--adobecom
  • News: https://main--news--adobecom.aem.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-167902--milo--adobecom
  • Homepage: https://main--homepage--adobecom.aem.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-167902--milo--adobecom

Sticky Branch Banner:

  • URL: https://main--federal--adobecom.aem.page/drafts/blaishram/banner/branch-banner-sticky?martech=off&milolibs=mwpw-167902--milo--adobecom

Inline Branch Banner:

  • URL: https://main--federal--adobecom.aem.page/drafts/blaishram/banner/branch-banner-inline?martech=off&milolibs=mwpw-167902--milo--adobecom

Blog

  • URL: https://main--blog--adobecom.aem.page/?martech=off&milolibs=mwpw-167902--milo--adobecom

RTL Locale

  • URL: https://main--homepage--adobecom.aem.live/mena_ar/homepage/index-loggedout?martech=off&milolibs=mwpw-167902--milo--adobecom

Deva309 avatar Nov 12 '25 04:11 Deva309

Hi @Deva309 Change region links do not have a hover effect on standalone pages. for both default and hover it shows same #5681FF in dark theme for Light theme, the default and hover shows #035FE6 color which is not the suggested given color. Expected • Default: #274DEA • Hover: #1D3ECF • Dark theme: • Default: #5681FF • Hover: #6995FE https://adobecom.github.io/nav-consumer/navigation.html?env=stage&theme=dark&navbranch=mwpw-167902&authoringpath=/federal/learn#langnav

image image

prativas22 avatar Nov 12 '25 10:11 prativas22

Hi @Deva309 , This pr has regression in homepage on hover , please check https://main--homepage--adobecom.aem.page/homepage/index-loggedout?milolibs=mwpw-167902--milo--deva309 image

spadmasa avatar Nov 12 '25 10:11 spadmasa

Hi @yesil I’ve updated the code through the MAS build system. Could you please review it? Also, if possible, can the QA team test a few sample pages?

CC: @spadmasa

Deva309 avatar Nov 13 '25 07:11 Deva309

Hi @Deva309 , This pr has regression in homepage on hover , please check https://main--homepage--adobecom.aem.page/homepage/index-loggedout?milolibs=mwpw-167902--milo--deva309 image

Hi @seanchoi-dev @Blainegunn We're seeing this regression issue on the homepage after this PR change. Since we added link hover color for dark mode, the homepage-brick is also showing a color change on hover. As in homepage previously set the anchor color to inherit in default mode for the homepage-brick, so it should apply the same for the hover state as well. Please let me know if you need any more details.

CC: @spadmasa

Deva309 avatar Nov 13 '25 07:11 Deva309

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

github-actions[bot] avatar Nov 14 '25 01:11 github-actions[bot]

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

github-actions[bot] avatar Nov 29 '25 01:11 github-actions[bot]

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

github-actions[bot] avatar Dec 09 '25 01:12 github-actions[bot]

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

github-actions[bot] avatar Dec 17 '25 01:12 github-actions[bot]