milo icon indicating copy to clipboard operation
milo copied to clipboard

MWPW-182179 background image vs. background color returns different p…

Open suhjainadobe opened this issue 2 months ago • 3 comments

When there is no foreground (product tile) and background image(hex value), due to "no-image" class the block is rendered differently.

it's adding the margin to action-area where buttons are not vertically centered.

Resolves: MWPW-182179

Test URLs:

  • Before: https://main--milo--adobecom.aem.page/drafts/klee/jira-ticket/mwpw-182179-figma-block-options
  • After: https://ribbon-notification--milo--suhjainadobe.aem.page/drafts/klee/jira-ticket/mwpw-182179-figma-block-options

suhjainadobe avatar Nov 11 '25 08:11 suhjainadobe

Hi @suhjainadobe can you please confirm on the below url , notification is seen hidden when embded when verified with milolibs https://ribbon-notification--milo--suhjainadobe.aem.page/docs/library/kitchen-sink/notification-ribbon image

image image close button alignment and text is seen shifted image

spadmasa avatar Nov 11 '25 14:11 spadmasa

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

github-actions[bot] avatar Nov 12 '25 01:11 github-actions[bot]

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

github-actions[bot] avatar Nov 25 '25 01:11 github-actions[bot]