adobecom
Google Yolo (auto sign)
This PR adds the ability to turn on google yolo via authoring
https://github.com/user-attachments/assets/711d4c62-4312-4ecc-a408-714cfea1d016
Resolves: MWPW-180897 Test URLs:
- Before: https://main--milo--adobecom.aem.page/express?martech=off
- After: https://google-yolo--milo--adobecom.aem.page/express?martech=off
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch. In case there are problems, just click the checkbox below to rerun the respective action.
- [ ] Re-sync branch
Commits
![aem-code-sync[bot] avatar](https://avatars.githubusercontent.com/in/17488?v=4 "Published by a pub.dev verified publisher"){kind=small}
As @overmyheadandbody mentioned on Slack, this already exists, does it not? https://github.com/adobecom/milo/blob/stage/libs/scripts/delayed.js#L82
As @overmyheadandbody mentioned on Slack, this already exists, does it not? https://github.com/adobecom/milo/blob/stage/libs/scripts/delayed.js#L82
Hi @mokimo, it is true that the ability for authors to enable / disable google login for either desktop / mobile or both does exist already in milo, however the changes in this PR add new functionality. That additional functionality is the ability to turn on / off a zero-tap flow called YOLO.
Milo currently supports one-tap only. After digging into the login flow I thought perhaps YOLO existed but a true zero-tap login currently does not exist. By adding "auto-select: true" the YOLO zero-tap flow is available to authors.
Note the behavior in the video above. I sign out and then return to the page and without taking any action google signs the user in automatically through a zero-tap flow. When zero-tap is not activated the user will see a one-tap pop up that will allow a sign in without the user having to re-enter their password while requiring one-tap from the user to initiate sign in.
@overmyheadandbody are we good to merge this PR? Are there any outstanding changes you would like to see?
Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jsandland make sure this gets QE sign-off and the Ready for Stage label applied by the QE! Otherwise this will get stuck and not get merged
Hi @jsandland , can you please confirm what would be the flow when there is geo pop up on the page , will google yolo comes up before or only after the popup close . We have this feature on PEP prompt will be the flow similar please clarify? cc : @nishantka
Hi @jsandland , can you please confirm what would be the flow when there is geo pop up on the page , will google yolo comes up before or only after the popup close . We have this feature on PEP prompt will be the flow similar please clarify? cc : @nishantka
Hi @spadmasa, I think currently google-yolo prompt is independent of georouting popup. The new auto login prompt should similarly work independent of georouting popup.
This page is giving 404. https://google-yolo--milo--adobecom.aem.page/express?martech=off
@mokimo @overmyheadandbody
FYI @hadobe you'd want to apply the "Ready for Stage" label so that the automation can pick it up and will merge it!
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.