milo icon indicating copy to clipboard operation
milo copied to clipboard

subheader referred as a link

Open patel-prince opened this issue 11 months ago • 4 comments

subheader with static text is seen getting tabbed and getting focus

Resolves: MWPW-171997

Test URLs:

  • Before: https://main--milo--adobecom.aem.page/?martech=off
  • After: https://mwpw-171997--milo--patel-prince.aem.page/?martech=off

QA URL:

  • https://main--homepage--adobecom.aem.page/homepage/index-loggedout?milolibs=mwpw-171997--milo--patel-prince
  • https://main--bacom--adobecom.hlx.live/?martech=off&milolibs=mwpw-171997--milo--patel-prince
  • https://mwpw-171997--milo--patel-prince.aem.page/drafts/blaishram/test-urls/page?martech=off

GNav Test URLs

Gnav + Footer + Region Picker modal:

  • Acrobat: https://main--dc--adobecom.hlx.live/acrobat?martech=off&milolibs=mwpw-171997--milo--adobecom
  • BACOM: https://main--bacom--adobecom.hlx.live/?martech=off&milolibs=mwpw-171997--milo--adobecom
  • CC: https://main--cc--adobecom.aem.live/creativecloud?martech=off&milolibs=mwpw-171997--milo--adobecom
  • Milo: https://mwpw-171997--milo--adobecom.aem.page/drafts/blaishram/test-urls/page?martech=off
  • Express: https://main--express-milo--adobecom.aem.live/express/?martech=off&milolibs=mwpw-171997--milo--adobecom
  • News: https://main--news--adobecom.aem.live/?martech=off&milolibs=mwpw-171997--milo--adobecom
  • Homepage: https://main--homepage--adobecom.aem.live/homepage/index-loggedout?martech=off&milolibs=mwpw-171997--milo--adobecom

Thin Gnav + ThinFooter + Region Picker dropup:

  • Acrobat: https://main--dc--adobecom.hlx.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-171997--milo--adobecom
  • BACOM: https://main--bacom--adobecom.hlx.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-171997--milo--adobecom
  • CC: https://main--cc--adobecom.hlx.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-171997--milo--adobecom
  • Milo: https://mwpw-171997--milo--adobecom.hlx.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off
  • Express: https://main--express-milo--adobecom.hlx.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-171997--milo--adobecom
  • News: https://main--news--adobecom.hlx.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-171997--milo--adobecom
  • Homepage: https://main--homepage--adobecom.hlx.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-171997--milo--adobecom

Localnav + Promo:

  • Acrobat: https://main--dc--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-171997--milo--adobecom
  • BACOM: https://main--bacom--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-171997--milo--adobecom
  • CC: https://main--cc--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-171997--milo--adobecom
  • Milo: https://mwpw-171997--milo--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?martech=off
  • Express: https://main--express-milo--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-171997--milo--adobecom
  • News: https://main--news--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-171997--milo--adobecom
  • Homepage: https://main--homepage--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-171997--milo--adobecom

Sticky Branch Banner:

  • URL: https://main--federal--adobecom.aem.page/drafts/blaishram/banner/branch-banner-sticky?martech=off&milolibs=mwpw-171997--milo--adobecom

Inline Branch Banner:

  • URL: https://main--federal--adobecom.aem.page/drafts/blaishram/banner/branch-banner-inline?martech=off&milolibs=mwpw-171997--milo--adobecom

Blog

  • URL: https://main--blog--adobecom.aem.page/?martech=off&milolibs=mwpw-171997--milo--adobecom

RTL Locale

  • URL: https://main--homepage--adobecom.aem.live/mena_ar/homepage/index-loggedout?martech=off&milolibs=mwpw-171997--milo--adobecom

patel-prince avatar May 07 '25 11:05 patel-prince

@patel-prince I don't think the description is for this PR. Please correct it and give proper name for the PR as well

bandana147 avatar May 07 '25 14:05 bandana147

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

github-actions[bot] avatar May 08 '25 01:05 github-actions[bot]

Hi @patel-prince , do not see tab changes working its seen stuck after adobe commerce (magneto) link , please check and advise https://main--homepage--adobecom.aem.page/homepage/index-loggedout?milolibs=mwpw-171997--milo--patel-prince image image

spadmasa avatar May 21 '25 05:05 spadmasa

Validation done on the pr on the below urls https://main--homepage--adobecom.aem.page/homepage/index-loggedout?milolibs=mwpw-171997--milo--patel-prince https://main--bacom--adobecom.hlx.live/?martech=off&milolibs=mwpw-171997--milo--patel-prince image

https://github.com/user-attachments/assets/c8760ac7-697f-44fd-8d32-00c9dcb526ad

Results are added in subtask of https://jira.corp.adobe.com/browse/MWPW-171997

spadmasa avatar May 28 '25 06:05 spadmasa

Skipped merging 4095: subheader referred as a link due to failing or running checks

milo-pr-merge[bot] avatar Jun 02 '25 08:06 milo-pr-merge[bot]