milo icon indicating copy to clipboard operation
milo copied to clipboard

MWPW-159032: Accessibility requirements floating label

Open joaquinrivero opened this issue 1 year ago • 2 comments

  • Adds a floating label as accessibility requirements for comments field

Resolves: MWPW-159032

Test URLs:

  • Before: https://main--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?martech=off
  • After: https://mwpw-159032--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?milolibs=MWPW-159032--milo--joaquinrivero&martech=off

joaquinrivero avatar Oct 04 '24 16:10 joaquinrivero

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.33%. Comparing base (1bdfd4a) to head (5b17a03). Report is 64 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3015      +/-   ##
==========================================
- Coverage   96.34%   96.33%   -0.01%     
==========================================
  Files         243      243              
  Lines       55284    55282       -2     
==========================================
- Hits        53261    53254       -7     
- Misses       2023     2028       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 04 '24 16:10 codecov[bot]

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

github-actions[bot] avatar Oct 05 '24 01:10 github-actions[bot]

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

github-actions[bot] avatar Oct 13 '24 01:10 github-actions[bot]

I see the same PR here - https://github.com/adobecom/milo/pull/2949 @joaquinrivero - can you please update the PRs? Thanks!

narcis-radu avatar Oct 18 '24 08:10 narcis-radu

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

github-actions[bot] avatar Oct 27 '24 01:10 github-actions[bot]