MWPW-159032: Accessibility requirements for ratings comment field
- Adds a floating label as accessibility requirements for comments field
Resolves: MWPW-159032
Test URLs:
- Before: https://main--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?martech=off
- After: https://mwpw-159032--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?milolibs=MWPW-159032-ratings--milo--joaquinrivero&martech=off
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.96%. Comparing base (
5ddeb73) to head (84eef60). Report is 103 commits behind head on stage.
Additional details and impacted files
@@ Coverage Diff @@
## stage #2949 +/- ##
==========================================
- Coverage 96.29% 95.96% -0.33%
==========================================
Files 240 175 -65
Lines 54739 46859 -7880
==========================================
- Hits 52709 44970 -7739
+ Misses 2030 1889 -141
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.
Hi @joaquinrivero , for PSI check you need to provide the Milo page link (currently in the description you only have dc page), smthg like
https://mwpw-159032-ratings--milo--joaquinrivero.hlx.page/drafts/joaquinrivero/testpage where testpage have the block you've worked on.
- MAS Unit Tests seem to fail due to style change, i'd try to pull latest from stage to make sure it's indeed a real issue or not. if issue persists we need to look deeper why style change in one block affects another one
@joaquinrivero - I see the story is marked as done. Do we need the PR?
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.
Closing this PR due to inactivity.