milo icon indicating copy to clipboard operation
milo copied to clipboard

[MWPW-152968] mWeb - Passing ECID to Branch.io banner - Implementation

Open drashti1712 opened this issue 1 year ago • 2 comments

  • When a user who has opted into both analytics and advertising cookies and is using Android device, their unique ECID is passed to Branch.
  • These changes were approved and merged last month ( PR: 2567) but were later reverted as we needed to wait for PIA approval. We are now re-opening this PR as we have received the PIA approval for this.

Resolves: MWPW-152968

Test URLs:

  • Before: https://main--milo--adobecom.hlx.live/drafts/drashti/milo-banner/branch-banner?martech=off
  • After: https://branch-ecid--milo--drashti1712.hlx.live/drafts/drashti/milo-banner/branch-banner

drashti1712 avatar Aug 21 '24 07:08 drashti1712

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.92%. Comparing base (2abe70f) to head (dcc46cb). Report is 22 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #2772   +/-   ##
=======================================
  Coverage   95.91%   95.92%           
=======================================
  Files         173      173           
  Lines       45831    45861   +30     
=======================================
+ Hits        43958    43990   +32     
+ Misses       1873     1871    -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 21 '24 07:08 codecov[bot]

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

github-actions[bot] avatar Aug 23 '24 01:08 github-actions[bot]

Validation done on the pr in the below url : https://main--cc--adobecom.hlx.page/drafts/Souj/branch-io/branch-io-page12?milolibs=branch-ecid--milo--drashti1712 ecid value is seen passed for android and seen matching in branch image image

details are updated in ticket https://jira.corp.adobe.com/browse/MWPW-152968

spadmasa avatar Aug 26 '24 08:08 spadmasa