milo icon indicating copy to clipboard operation
milo copied to clipboard

MWPW-154209 - [hero-marquee] bugs

Open ryanmparrish opened this issue 6 months ago • 6 comments

Fixed some bugs in the hero-marquee that were found in GPW user testing. These changes address the following.

  1. Row type and button variants on con-block rows should style the elements. They are not. ex con-block-row-text (s-body, xl-button, xxxl-heading)
  2. :icons: in the main content area not rendering.
  3. Update lockup styles from incoming globals.
  4. When background image is smaller than 1199px, the image should be forced to display at 100% in tablet view.
  5. When CTA is the ONLY element placed in "con block row text," margin top should be removed.
  6. Video elements not displaying for mobile or tablet when authored w/ bg-bottom-mobile, bg-top-tablet variants.

Resolves: MWPW-154209

Test URLs:

  • Before: https://main--milo--adobecom.hlx.page/drafts/rparrish/hero/hero-bugs?martech=off
  • After: https://rparrish-hero-bugz--milo--adobecom.hlx.page/drafts/rparrish/hero/hero-bugs?martech=off

Prod URLs:

  • Before: https://main--milo--adobecom.hlx.page/docs/library/blocks/hero-marquee?martech=off
  • After: https://rparrish-hero-bugz--milo--adobecom.hlx.page/docs/library/blocks/hero-marquee?martech=off
  • Before: https://main--milo--adobecom.hlx.page/docs/library/kitchen-sink/hero-marquee?martech=off
  • After: https://rparrish-hero-bugz--milo--adobecom.hlx.page/docs/library/kitchen-sink/hero-marquee?martech=off

ryanmparrish avatar Aug 12 '24 18:08 ryanmparrish