spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

[Bug]: Modal-wrapper block-size style is not being set in Safari or Firefox

Open lehelen19 opened this issue 1 week ago • 2 comments

Code of conduct

  • [x] I agree to follow this project's code of conduct.

Impacted component(s)

sp-dialog-base

Library version

1.9.0

Expected behavior

block-size should be set on sp-dialog-base.

Actual behavior

block-size is not set on sp-dialog-base on Firefox or Safari.

Screenshots

Image Image

What browsers are you seeing the problem in?

Safari, Firefox

How can we reproduce this issue?

  1. Go to https://opensource.adobe.com/spectrum-web-components/storybook/index.html?path=/story/dialog-base--slotted&globals=system:spectrum-two
  2. Inspect sp-dialog-base
  3. Search for the block-size style

Sample code or abstract reproduction which illustrates the problem

https://github.com/adobe/spectrum-web-components/blob/main/1st-gen/packages/modal/src/spectrum-modal-wrapper.css#L16-L18

Severity

None

Logs taken while reproducing problem

No response

Would you like to track this issue in Jira?

  • [x] Yes, please tell me the ticket number!

lehelen19 avatar Dec 09 '25 21:12 lehelen19

This is a regression from 1.7.0:

Image

lehelen19 avatar Dec 09 '25 21:12 lehelen19

This issue is due to the lightningCSS build minifier where it strips out duplicate css during minification breaking the fallback chain causing issues like this in FF and Webkit. We need to add browser targets to preserve these fallbacks when necessary. Limited support for block:stretch in FF and Safari too. https://caniuse.com/?search=stretch

Rajdeepc avatar Dec 10 '25 09:12 Rajdeepc