spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

fix(styles): cjk alias mapping fixed

Open castastrophe opened this issue 6 months ago • 5 comments

Description

A contributor identified that one of our alias tokens for CJK font was pointing to the code font-family stack instead of the appropriate (and expected) CJK font-family stack.

Related issue(s)

  • Fix brought over from CSS contribution https://github.com/adobe/spectrum-css/pull/3936

Author's checklist

  • [x] I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • [x] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • [n/a] I have added automated tests to cover my changes.
  • [x] I have included a well-written changeset if my change needs to be published.
  • [n/a] I have included updated documentation if my change required it.

Reviewer's checklist

  • [ ] Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • [ ] Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • [ ] Automated tests cover all use cases and follow best practices for writing
  • [ ] Validated on all supported browsers
  • [ ] All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • No test cases for this because our library does not appear to use the cjk-font alias variable. Bringing the fix over in case downstream consumers are using it.

castastrophe avatar Jun 11 '25 14:06 castastrophe

🦋 Changeset detected

Latest commit: dd71f053e929febaab9f53b4efabdf208ef18965

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 84 packages
Name Type
@spectrum-web-components/styles Patch
@spectrum-web-components/card Patch
@spectrum-web-components/illustrated-message Patch
@spectrum-web-components/custom-vars-viewer Patch
example-project-rollup Patch
example-project-webpack Patch
@spectrum-web-components/vrt-compare Patch
@spectrum-web-components/bundle Patch
@spectrum-web-components/theme Patch
@spectrum-web-components/truncated Patch
documentation Patch
@spectrum-web-components/overlay Patch
@spectrum-web-components/slider Patch
@spectrum-web-components/story-decorator Patch
@spectrum-web-components/combobox Patch
@spectrum-web-components/contextual-help Patch
@spectrum-web-components/menu Patch
@spectrum-web-components/picker Patch
@spectrum-web-components/popover Patch
@spectrum-web-components/tooltip Patch
@spectrum-web-components/breadcrumbs Patch
@spectrum-web-components/action-menu Patch
@spectrum-web-components/action-bar Patch
@spectrum-web-components/eslint-plugin Patch
@spectrum-web-components/accordion Patch
@spectrum-web-components/action-button Patch
@spectrum-web-components/action-group Patch
@spectrum-web-components/alert-banner Patch
@spectrum-web-components/alert-dialog Patch
@spectrum-web-components/asset Patch
@spectrum-web-components/avatar Patch
@spectrum-web-components/badge Patch
@spectrum-web-components/button-group Patch
@spectrum-web-components/button Patch
@spectrum-web-components/checkbox Patch
@spectrum-web-components/clear-button Patch
@spectrum-web-components/close-button Patch
@spectrum-web-components/coachmark Patch
@spectrum-web-components/color-area Patch
@spectrum-web-components/color-field Patch
@spectrum-web-components/color-handle Patch
@spectrum-web-components/color-loupe Patch
@spectrum-web-components/color-slider Patch
@spectrum-web-components/color-wheel Patch
@spectrum-web-components/dialog Patch
@spectrum-web-components/divider Patch
@spectrum-web-components/dropzone Patch
@spectrum-web-components/field-group Patch
@spectrum-web-components/field-label Patch
@spectrum-web-components/help-text Patch
@spectrum-web-components/icon Patch
@spectrum-web-components/icons-ui Patch
@spectrum-web-components/icons-workflow Patch
@spectrum-web-components/icons Patch
@spectrum-web-components/iconset Patch
@spectrum-web-components/infield-button Patch
@spectrum-web-components/link Patch
@spectrum-web-components/meter Patch
@spectrum-web-components/modal Patch
@spectrum-web-components/number-field Patch
@spectrum-web-components/picker-button Patch
@spectrum-web-components/progress-bar Patch
@spectrum-web-components/progress-circle Patch
@spectrum-web-components/radio Patch
@spectrum-web-components/search Patch
@spectrum-web-components/sidenav Patch
@spectrum-web-components/split-view Patch
@spectrum-web-components/status-light Patch
@spectrum-web-components/swatch Patch
@spectrum-web-components/switch Patch
@spectrum-web-components/table Patch
@spectrum-web-components/tabs Patch
@spectrum-web-components/tags Patch
@spectrum-web-components/textfield Patch
@spectrum-web-components/thumbnail Patch
@spectrum-web-components/toast Patch
@spectrum-web-components/top-nav Patch
@spectrum-web-components/tray Patch
@spectrum-web-components/underlay Patch
@spectrum-web-components/base Patch
@spectrum-web-components/grid Patch
@spectrum-web-components/opacity-checkerboard Patch
@spectrum-web-components/reactive-controllers Patch
@spectrum-web-components/shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 11 '25 14:06 changeset-bot[bot]

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file. If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

github-actions[bot] avatar Jun 11 '25 14:06 github-actions[bot]

Tachometer results

Currently, no packages are changed by this PR...

github-actions[bot] avatar Jun 11 '25 14:06 github-actions[bot]

Is there any way we can test this via storybook?

Rajdeepc avatar Jun 13 '25 05:06 Rajdeepc

Is there any way we can test this via storybook?

From my description:

No test cases for this because our library does not appear to use the cjk-font alias variable. Bringing the fix over in case downstream consumers are using it.

It's pretty obvious looking at the code too that it's a simple fix.

castastrophe avatar Jun 13 '25 16:06 castastrophe