spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

fix: get tests passing on latest playwright version

Open caseyisonit opened this issue 7 months ago • 3 comments

Description

Get tests passing with playwright at latest

Motivation and context

to bump playwright to latest

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • [x] I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • [x] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • [x] I have added automated tests to cover my changes.
  • [x] I have included a well-written changeset if my change needs to be published.
  • [x] I have included updated documentation if my change required it.

Reviewer's checklist

  • [ ] Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • [ ] Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • [ ] Automated tests cover all use cases and follow best practices for writing
  • [ ] Validated on all supported browsers
  • [ ] All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • [ ] Tests pass in CI

caseyisonit avatar May 13 '25 16:05 caseyisonit

⚠️ No Changeset found

Latest commit: 1d4730268fec66a5ffe718951045a9b676070ad9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 13 '25 16:05 changeset-bot[bot]

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file. If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

github-actions[bot] avatar May 13 '25 16:05 github-actions[bot]

Tachometer results

Currently, no packages are changed by this PR...

github-actions[bot] avatar May 13 '25 16:05 github-actions[bot]