spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

[Bug]: sp-button mod tokens blocked

Open SavkaTaras opened this issue 7 months ago • 2 comments

Code of conduct

  • [x] I agree to follow this project's code of conduct.

Impacted component(s)

sp-button

Expected behavior

To be able to use any --mod-* css tokens to override needed properties.

Actual behavior

packages/button/src/button-overrides.css uses --mod-* tokens instead of --spectrum-* to override different variants of the button. Please see required patch to fix the issue: https://github.com/adobe/spectrum-web-components/commit/7a47013c6056725f66e0a785992c472f9787537a please note there is a typo for --mspectrumod-button-background-color-down, which should be --spectrum-button-background-color-down

Screenshots

Image

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to https://opensource.adobe.com/spectrum-web-components/storybook/index.html?path=/story/button-group-sizes--m

Sample code or abstract reproduction which illustrates the problem

No response

Severity

SEV 1

Logs taken while reproducing problem

No response

SavkaTaras avatar Apr 07 '25 23:04 SavkaTaras

SWC-788

najikahalsema avatar Apr 10 '25 16:04 najikahalsema