adobe
fix(dialog,styles): remove unneeded abstraction layer for system theming - abandoned
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| @spectrum-css/dialog (source) | 11.0.0-s2-foundations.15 -> 12.1.0 |
Release Notes
adobe/spectrum-css (@spectrum-css/dialog)
v11.0.1
Patch Changes
📝 #3522 7a47c22 Thanks @castastrophe!
-
Peer dependency for @spectrum-css/tokens updated to include v15 as well as v14.
v11.0.0
Major Changes
📝 #3502 562396e Thanks @castastrophe!
-
Remove empty theme references to reduce complexity for components that don't need to define any mappings. This involves removing the source
themesdirectories with the emptyspectrum.cssandexpress.comfiles as well as removing the following empty or unnecessary exports:index-base.cssindex-theme.cssthemes/spectrum.cssthemes/express.css
Patch Changes
v11.0.0-s2-foundations.17
Major Changes
- #2786
7fa37a7Thanks @pfulton! - Removes empty theme assets from the component; no longer publishing a themes folder or index-theme.css map.
Patch Changes
- Updated dependencies [
7fa37a7]:- @spectrum-css/underlay@5.0.0-s2-foundations.17
v11.0.0-s2-foundations.16
Major Changes
-
#2786
f6ad55eThanks @pfulton! - feat: s2 foundations non-gray-800 colors updateProperty name Context Old value Updated value --spectrum-blue-800dark rgb(69, 110, 254) rgb(64, 105, 253) --spectrum-red-800dark rgb(230, 54, 35) rgb(223, 52, 34) --spectrum-orange-800dark rgb(205, 86, 0) rgb(199, 82, 0) --spectrum-yellow-800dark rgb(169, 110, 0) rgb(164, 106, 0) --spectrum-chartreuse-800dark rgb(109, 131, 0) rgb(106, 127, 0) --spectrum-celery-800dark rgb(69, 138, 19) rgb(66, 134, 18) --spectrum-green-800dark rgb(6, 140, 82) rgb(6, 136, 80) --spectrum-seafoam-800dark rgb(8, 138, 116) rgb(8, 134, 112) --spectrum-cyan-800dark rgb(15, 128, 194) rgb(13, 125, 186) --spectrum-indigo-800dark rgb(119, 97, 252) rgb(116, 91, 252) --spectrum-purple-800dark rgb(161, 84, 229) rgb(157, 78, 228) --spectrum-fuchsia-800dark rgb(192, 64, 212) rgb(186, 60, 206) --spectrum-magenta-800dark rgb(231, 41, 105) rgb(224, 38, 101) --spectrum-pink-800dark rgb(220, 47, 156) rgb(213, 45, 151) --spectrum-turqoise-800dark rgb(9, 135, 147) rgb(9, 131, 142) --spectrum-brown-800dark rgb(148, 118, 73) rgb(143, 114, 69) --spectrum-silver-800dark rgb(123, 123, 123) rgb(118, 118, 118) --spectrum-cinnamon-800dark rgb(179, 103, 64) rgb(176, 98, 59)
Patch Changes
- Updated dependencies [
f6ad55e]:- @spectrum-css/tokens@15.0.0-s2-foundations.29
- @spectrum-css/closebutton@6.0.0-s2-foundations.17
- @spectrum-css/underlay@5.0.0-s2-foundations.16
- @spectrum-css/divider@4.0.0-s2-foundations.16
- @spectrum-css/modal@6.0.0-s2-foundations.17
Configuration
📅 Schedule: Branch creation - "after 12pm on thursday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
- [ ] If you want to rebase/retry this PR, check this box
This PR was generated by Mend Renovate. View the repository job log.
![renovate[bot] avatar](https://avatars.githubusercontent.com/in/2740?v=4 "Published by a pub.dev verified publisher"){kind=small}
🦋 Changeset detected
Latest commit: 180e6c2e5c3c265de274bfa0dae4f787f5bd5c33
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 84 packages
| Name | Type |
|---|---|
| @spectrum-web-components/dialog | Patch |
| @spectrum-web-components/styles | Patch |
| @spectrum-web-components/contextual-help | Patch |
| @spectrum-web-components/bundle | Patch |
| @spectrum-web-components/card | Patch |
| @spectrum-web-components/illustrated-message | Patch |
| @spectrum-web-components/custom-vars-viewer | Patch |
| example-project-rollup | Patch |
| example-project-webpack | Patch |
| @spectrum-web-components/vrt-compare | Patch |
| @spectrum-web-components/theme | Patch |
| @spectrum-web-components/truncated | Patch |
| documentation | Patch |
| @spectrum-web-components/overlay | Patch |
| @spectrum-web-components/slider | Patch |
| @spectrum-web-components/story-decorator | Patch |
| @spectrum-web-components/combobox | Patch |
| @spectrum-web-components/menu | Patch |
| @spectrum-web-components/picker | Patch |
| @spectrum-web-components/popover | Patch |
| @spectrum-web-components/tooltip | Patch |
| @spectrum-web-components/breadcrumbs | Patch |
| @spectrum-web-components/action-menu | Patch |
| @spectrum-web-components/action-bar | Patch |
| @spectrum-web-components/eslint-plugin | Patch |
| @spectrum-web-components/accordion | Patch |
| @spectrum-web-components/action-button | Patch |
| @spectrum-web-components/action-group | Patch |
| @spectrum-web-components/alert-banner | Patch |
| @spectrum-web-components/alert-dialog | Patch |
| @spectrum-web-components/asset | Patch |
| @spectrum-web-components/avatar | Patch |
| @spectrum-web-components/badge | Patch |
| @spectrum-web-components/button-group | Patch |
| @spectrum-web-components/button | Patch |
| @spectrum-web-components/checkbox | Patch |
| @spectrum-web-components/clear-button | Patch |
| @spectrum-web-components/close-button | Patch |
| @spectrum-web-components/coachmark | Patch |
| @spectrum-web-components/color-area | Patch |
| @spectrum-web-components/color-field | Patch |
| @spectrum-web-components/color-handle | Patch |
| @spectrum-web-components/color-loupe | Patch |
| @spectrum-web-components/color-slider | Patch |
| @spectrum-web-components/color-wheel | Patch |
| @spectrum-web-components/divider | Patch |
| @spectrum-web-components/dropzone | Patch |
| @spectrum-web-components/field-group | Patch |
| @spectrum-web-components/field-label | Patch |
| @spectrum-web-components/help-text | Patch |
| @spectrum-web-components/icon | Patch |
| @spectrum-web-components/icons-ui | Patch |
| @spectrum-web-components/icons-workflow | Patch |
| @spectrum-web-components/icons | Patch |
| @spectrum-web-components/iconset | Patch |
| @spectrum-web-components/infield-button | Patch |
| @spectrum-web-components/link | Patch |
| @spectrum-web-components/meter | Patch |
| @spectrum-web-components/modal | Patch |
| @spectrum-web-components/number-field | Patch |
| @spectrum-web-components/picker-button | Patch |
| @spectrum-web-components/progress-bar | Patch |
| @spectrum-web-components/progress-circle | Patch |
| @spectrum-web-components/radio | Patch |
| @spectrum-web-components/search | Patch |
| @spectrum-web-components/sidenav | Patch |
| @spectrum-web-components/split-view | Patch |
| @spectrum-web-components/status-light | Patch |
| @spectrum-web-components/swatch | Patch |
| @spectrum-web-components/switch | Patch |
| @spectrum-web-components/table | Patch |
| @spectrum-web-components/tabs | Patch |
| @spectrum-web-components/tags | Patch |
| @spectrum-web-components/textfield | Patch |
| @spectrum-web-components/thumbnail | Patch |
| @spectrum-web-components/toast | Patch |
| @spectrum-web-components/top-nav | Patch |
| @spectrum-web-components/tray | Patch |
| @spectrum-web-components/underlay | Patch |
| @spectrum-web-components/base | Patch |
| @spectrum-web-components/grid | Patch |
| @spectrum-web-components/opacity-checkerboard | Patch |
| @spectrum-web-components/reactive-controllers | Patch |
| @spectrum-web-components/shared | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
Pull Request Test Coverage Report for Build 14134736568
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 98.002%
| Totals | |
|---|---|
| Change from base Build 14134663351: | 0.0% |
| Covered Lines: | 33711 |
| Relevant Lines: | 34211 |
💛 - Coveralls
Branch preview
Review the following VRT differences
When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
- Spectrum | Light | Medium | LTR
- Spectrum | Dark | Large | RTL
- Express | Light | Medium | LTR
- Express | Dark | Large | RTL
- Spectrum-two | Light | Medium | LTR
- Spectrum-two | Dark | Large | RTL
- High Contrast Mode | Medium | LTR
If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Tachometer results
Chrome
dialog permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 563 kB | 78.99ms - 80.55ms | - | unsure 🔍 -2% - +1% -1.66ms - +1.08ms |
| branch | 537 kB | 78.93ms - 81.19ms | unsure 🔍 -1% - +2% -1.08ms - +1.66ms |
- |
Firefox
dialog permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 563 kB | 119.49ms - 125.95ms | - | unsure 🔍 -5% - +2% -6.06ms - +2.62ms |
| branch | 537 kB | 121.54ms - 127.34ms | unsure 🔍 -2% - +5% -2.62ms - +6.06ms |
- |
Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠️ Warning: custom changes will be lost.
@castastrophe does the golden hash need to be updated? i don't want it to feel like its all on you to handle the renovate PRs so let me know if you'd like me to help
@castastrophe does the golden hash need to be updated? i don't want it to feel like its all on you to handle the renovate PRs so let me know if you'd like me to help
Thanks! I appreciate the offer. I'm holding off on any updates that are showing visual diffs. I'll go through and remove the ready flag from those! Thanks for the reminder.
@caseyisonit This update is altering the inline size of the dialog for consumers and I'm not sure that's desirable at this time - should we close this update out? Are there any features in it that are really valuable? I didn't see any other changes we'd necessarily need.
Autoclosing Skipped
This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.
📚 Branch Preview
🔍 Visual Regression Test Results
When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
- Spectrum | Light | Medium | LTR
- Spectrum | Dark | Large | RTL
- Express | Light | Medium | LTR
- Express | Dark | Large | RTL
- Spectrum-two | Light | Medium | LTR
- Spectrum-two | Dark | Large | RTL
- High Contrast Mode | Medium | LTR
Deployed to Azure Blob Storage: pr-5304
If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.