spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard
verified publisher icon adobe

fix(field-group): update styles to latest; reduce system theming - abandoned

Open renovate[bot] opened this issue 9 months ago • 7 comments

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@spectrum-css/fieldgroup (source) 6.0.0-s2-foundations.16 -> 7.1.0 age adoption passing confidence

Release Notes

adobe/spectrum-css (@​spectrum-css/fieldgroup)

v6.0.1

Compare Source

Patch Changes

📝 #​3522 7a47c22 Thanks @​castastrophe!

v6.0.0

Compare Source

Major Changes

📝 #​3502 562396e Thanks @​castastrophe!

  • Remove empty theme references to reduce complexity for components that don't need to define any mappings. This involves removing the source themes directories with the empty spectrum.css and express.com files as well as removing the following empty or unnecessary exports:

    • index-base.css
    • index-theme.css
    • themes/spectrum.css
    • themes/express.css
Patch Changes

v6.0.0-s2-foundations.18

Compare Source

Major Changes
  • #​2786 7fa37a7 Thanks @​pfulton! - Removes empty theme assets from the component; no longer publishing a themes folder or index-theme.css map.
Patch Changes

v6.0.0-s2-foundations.17

Compare Source

Major Changes

  • #​2786 f6ad55e Thanks @​pfulton! - feat: s2 foundations non-gray-800 colors update

    Property name Context Old value Updated value
    --spectrum-blue-800 dark rgb(69, 110, 254) rgb(64, 105, 253)
    --spectrum-red-800 dark rgb(230, 54, 35) rgb(223, 52, 34)
    --spectrum-orange-800 dark rgb(205, 86, 0) rgb(199, 82, 0)
    --spectrum-yellow-800 dark rgb(169, 110, 0) rgb(164, 106, 0)
    --spectrum-chartreuse-800 dark rgb(109, 131, 0) rgb(106, 127, 0)
    --spectrum-celery-800 dark rgb(69, 138, 19) rgb(66, 134, 18)
    --spectrum-green-800 dark rgb(6, 140, 82) rgb(6, 136, 80)
    --spectrum-seafoam-800 dark rgb(8, 138, 116) rgb(8, 134, 112)
    --spectrum-cyan-800 dark rgb(15, 128, 194) rgb(13, 125, 186)
    --spectrum-indigo-800 dark rgb(119, 97, 252) rgb(116, 91, 252)
    --spectrum-purple-800 dark rgb(161, 84, 229) rgb(157, 78, 228)
    --spectrum-fuchsia-800 dark rgb(192, 64, 212) rgb(186, 60, 206)
    --spectrum-magenta-800 dark rgb(231, 41, 105) rgb(224, 38, 101)
    --spectrum-pink-800 dark rgb(220, 47, 156) rgb(213, 45, 151)
    --spectrum-turqoise-800 dark rgb(9, 135, 147) rgb(9, 131, 142)
    --spectrum-brown-800 dark rgb(148, 118, 73) rgb(143, 114, 69)
    --spectrum-silver-800 dark rgb(123, 123, 123) rgb(118, 118, 118)
    --spectrum-cinnamon-800 dark rgb(179, 103, 64) rgb(176, 98, 59)
Patch Changes

Configuration

📅 Schedule: Branch creation - "after 12pm on thursday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • [ ] If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate[bot] avatar Mar 28 '25 17:03 renovate[bot]

🦋 Changeset detected

Latest commit: fa54e2e1e84244346a0aa52e8bda6bfc3862ea7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 84 packages
Name Type
@spectrum-web-components/field-group Patch
@spectrum-web-components/styles Patch
@spectrum-web-components/radio Patch
@spectrum-web-components/bundle Patch
@spectrum-web-components/card Patch
@spectrum-web-components/illustrated-message Patch
@spectrum-web-components/custom-vars-viewer Patch
example-project-rollup Patch
example-project-webpack Patch
@spectrum-web-components/vrt-compare Patch
@spectrum-web-components/theme Patch
@spectrum-web-components/truncated Patch
documentation Patch
@spectrum-web-components/overlay Patch
@spectrum-web-components/slider Patch
@spectrum-web-components/story-decorator Patch
@spectrum-web-components/combobox Patch
@spectrum-web-components/contextual-help Patch
@spectrum-web-components/menu Patch
@spectrum-web-components/picker Patch
@spectrum-web-components/popover Patch
@spectrum-web-components/tooltip Patch
@spectrum-web-components/breadcrumbs Patch
@spectrum-web-components/action-menu Patch
@spectrum-web-components/action-bar Patch
@spectrum-web-components/eslint-plugin Patch
@spectrum-web-components/accordion Patch
@spectrum-web-components/action-button Patch
@spectrum-web-components/action-group Patch
@spectrum-web-components/alert-banner Patch
@spectrum-web-components/alert-dialog Patch
@spectrum-web-components/asset Patch
@spectrum-web-components/avatar Patch
@spectrum-web-components/badge Patch
@spectrum-web-components/button-group Patch
@spectrum-web-components/button Patch
@spectrum-web-components/checkbox Patch
@spectrum-web-components/clear-button Patch
@spectrum-web-components/close-button Patch
@spectrum-web-components/coachmark Patch
@spectrum-web-components/color-area Patch
@spectrum-web-components/color-field Patch
@spectrum-web-components/color-handle Patch
@spectrum-web-components/color-loupe Patch
@spectrum-web-components/color-slider Patch
@spectrum-web-components/color-wheel Patch
@spectrum-web-components/dialog Patch
@spectrum-web-components/divider Patch
@spectrum-web-components/dropzone Patch
@spectrum-web-components/field-label Patch
@spectrum-web-components/help-text Patch
@spectrum-web-components/icon Patch
@spectrum-web-components/icons-ui Patch
@spectrum-web-components/icons-workflow Patch
@spectrum-web-components/icons Patch
@spectrum-web-components/iconset Patch
@spectrum-web-components/infield-button Patch
@spectrum-web-components/link Patch
@spectrum-web-components/meter Patch
@spectrum-web-components/modal Patch
@spectrum-web-components/number-field Patch
@spectrum-web-components/picker-button Patch
@spectrum-web-components/progress-bar Patch
@spectrum-web-components/progress-circle Patch
@spectrum-web-components/search Patch
@spectrum-web-components/sidenav Patch
@spectrum-web-components/split-view Patch
@spectrum-web-components/status-light Patch
@spectrum-web-components/swatch Patch
@spectrum-web-components/switch Patch
@spectrum-web-components/table Patch
@spectrum-web-components/tabs Patch
@spectrum-web-components/tags Patch
@spectrum-web-components/textfield Patch
@spectrum-web-components/thumbnail Patch
@spectrum-web-components/toast Patch
@spectrum-web-components/top-nav Patch
@spectrum-web-components/tray Patch
@spectrum-web-components/underlay Patch
@spectrum-web-components/base Patch
@spectrum-web-components/grid Patch
@spectrum-web-components/opacity-checkerboard Patch
@spectrum-web-components/reactive-controllers Patch
@spectrum-web-components/shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Mar 28 '25 17:03 changeset-bot[bot]

Pull Request Test Coverage Report for Build 14134746726

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 97.999%
Totals Coverage Status
Change from base Build 14134663351: -0.003%
Covered Lines: 33711
Relevant Lines: 34211
💛 - Coveralls

coveralls avatar Mar 28 '25 17:03 coveralls

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file. If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

github-actions[bot] avatar Mar 28 '25 17:03 github-actions[bot]

Tachometer results

Chrome

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 474 kB 44.96ms - 46.45ms - faster ✔
4% - 8%
1.73ms - 4.17ms
branch 451 kB 47.69ms - 49.62ms slower ❌
4% - 9%
1.73ms - 4.17ms		 -
Firefox

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 474 kB 100.01ms - 105.67ms - unsure 🔍
-7% - +0%
-7.18ms - +0.18ms
branch 451 kB 103.98ms - 108.70ms unsure 🔍
-0% - +7%
-0.18ms - +7.18ms		 -

github-actions[bot] avatar Mar 28 '25 18:03 github-actions[bot]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

renovate[bot] avatar Mar 31 '25 21:03 renovate[bot]

@castastrophe do you think we are good to close this with the dependency removal work on going?

caseyisonit avatar May 05 '25 23:05 caseyisonit

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

renovate[bot] avatar May 21 '25 15:05 renovate[bot]

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5293

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file. If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

github-actions[bot] avatar Jul 23 '25 14:07 github-actions[bot]