spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

[test] full update for css packages (not for merging)

Open castastrophe opened this issue 8 months ago • 8 comments

This is a utility pull request that serves as a view of all remaining Spectrum CSS version updates remaining to be evaluated before the cutover.

castastrophe avatar Mar 27 '25 21:03 castastrophe

⚠️ No Changeset found

Latest commit: e1f3abff079ccc2248ebc2c974483484a9ed083c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 27 '25 21:03 changeset-bot[bot]

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file. If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

github-actions[bot] avatar Mar 27 '25 21:03 github-actions[bot]

Tachometer results

Currently, no packages are changed by this PR...

github-actions[bot] avatar Mar 27 '25 22:03 github-actions[bot]

Pull Request Test Coverage Report for Build 14135005473

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 98.009%

Totals Coverage Status
Change from base Build 14134663351: 0.007%
Covered Lines: 33713
Relevant Lines: 34211

💛 - Coveralls

coveralls avatar Mar 27 '25 22:03 coveralls

I am a little concerned with such a big list of file changes! Once you are ready let's discuss before we merge this in.

Rajdeepc avatar Mar 28 '25 04:03 Rajdeepc

@Rajdeepc this isn't for merging - it's a preview of the full scope of changes if all packages were updated. That's why it's in draft. Are there other labels that will help clarify this?

castastrophe avatar Mar 28 '25 18:03 castastrophe

@Rajdeepc this isn't for merging - it's a preview of the full scope of changes if all packages were updated. That's why it's in draft. Are there other labels that will help clarify this?

That's okay! But let's discuss this with Josh and others before we decide to work on this.

Rajdeepc avatar Mar 29 '25 14:03 Rajdeepc

That's okay! But let's discuss this with Josh and others before we decide to work on this.

@Rajdeepc It's already in the sprint. Like I said, don't worry about it. It's in draft and specifically says it's just a test.

castastrophe avatar Mar 29 '25 19:03 castastrophe

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5282

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file. If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

github-actions[bot] avatar Jul 08 '25 18:07 github-actions[bot]