spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

chore: updated playwright version

Open Rajdeepc opened this issue 1 year ago • 4 comments

Description

Update to latest Playwright

Related issue(s)

  • Playwright tests were failing in CI

Motivation and context

How has this been tested?

  • [ ] Test case 1

    1. Go here
    2. Do this
  • [ ] Test case 2

    1. Go here
    2. Do this
  • [ ] Did it pass in Desktop?

  • [ ] Did it pass in Mobile?

  • [ ] Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • [ ] I have signed the Adobe Open Source CLA.
  • [ ] My code follows the code style of this project.
  • [ ] If my change required a change to the documentation, I have updated the documentation in this pull request.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Rajdeepc avatar Oct 16 '24 11:10 Rajdeepc

Branch preview

github-actions[bot] avatar Oct 16 '24 11:10 github-actions[bot]

Tachometer results

Currently, no packages are changed by this PR...

github-actions[bot] avatar Oct 16 '24 11:10 github-actions[bot]

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 229.996 kB 217.294 kB 217.20 kB 🏆
Scripts 59.158 kB 52.638 kB 52.631 kB 🏆
Stylesheet 34.775 kB 30.244 kB 30.136 kB 🏆
Document 6.224 kB 5.467 kB 5.463 kB 🏆
Font 126.844 kB 126.595 kB 🏆 126.622 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

github-actions[bot] avatar Oct 16 '24 11:10 github-actions[bot]

Pull Request Test Coverage Report for Build 11407191839

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 98.227%

Totals Coverage Status
Change from base Build 11351160238: -0.005%
Covered Lines: 32983
Relevant Lines: 33395

💛 - Coveralls

coveralls avatar Oct 16 '24 15:10 coveralls

Closing this as this is redundant now!

Rajdeepc avatar Nov 05 '24 08:11 Rajdeepc