spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

Add Spectrum Combobox Pattern

Open Westbrook opened this issue 4 years ago • 7 comments

Expected Behaviour

https://opensource.adobe.com/spectrum-css/combobox.html should be available in the library.

Actual Behaviour

Missing

The future

image

Westbrook avatar Feb 06 '20 18:02 Westbrook

The styles package to support this is https://www.npmjs.com/package/@spectrum-css/inputgroup The hope would be that this could be an extension of the sp-dropdown pattern in some way.

Westbrook avatar Feb 07 '20 04:02 Westbrook

We could definitely use this component, specifically the "quiet" variant and ability to enter value that differs from the stock values (e.g. XD's zoom level combo for example).

CoreyDotCom avatar Jun 05 '20 15:06 CoreyDotCom

Thanks for the info @CoreyDotCom! Would you be able to share any screenshots of what that looks like? As a "contribution" even the newest version of this pattern has only the smallest amount of direction in the Spectrum documentation, so this information would be invaluable.

Westbrook avatar Jun 05 '20 15:06 Westbrook

Accessibility of combo boxes is really hard to get right and hard to retrofit if not considered upfront. Please ping me when this component starts to move along.

jnurthen avatar Jun 05 '20 15:06 jnurthen

Basically just the quiet combo as found here https://opensource.adobe.com/spectrum-css/components/combobox/

image

CoreyDotCom avatar Jun 05 '20 15:06 CoreyDotCom

Revisit this comment https://github.com/adobe/spectrum-web-components/pull/1661#discussion_r679336866 while shipping this pattern.

Westbrook avatar Jul 29 '21 18:07 Westbrook

Review pre-1.0; ship only if meeting quality bar.

hunterloftis avatar Sep 23 '21 20:09 hunterloftis

Any ETA for this component?

SavoInfostream avatar Feb 14 '23 17:02 SavoInfostream

Out current target is end of Q2.

Westbrook avatar Feb 14 '23 18:02 Westbrook

FYI: Currently, the work on this in blocked by the work going into the Overlay v2 release. Any team that was interested in leveraging a Combobox from SWC soon could smooth the process by beginning to test the RC release of that code in their application.

After that, it would be great if we could collect your specific use cases in the issue tracking this addition. Specifically, it would be useful to know which of the various Combobox type you are looking to leverage to support scoping an initial release:

With that information, and the code review for the new Overlay API wrapping up this week, we should be in a place where we could review the outstanding work required by that branch in order to possibly break it into sharable pieces later this week into next.

Westbrook avatar Jul 24 '23 11:07 Westbrook

Oh I would love the "Editable Combobox with List Autocomplete:" version. I'm trying to use sp-menu for just the mutli-select portion of this and really struggling. Even if I get it working, the list is long enough that the user experience will be poor searching through for the entry you wish to toggle.

lschierer avatar Dec 01 '23 23:12 lschierer