spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

chore: make the spectrum-two theme fully functional

Open graynorton opened this issue 1 year ago • 9 comments

Description

The spectrum-two theme didn't yet have all of the necessary plumbing in tools/styles and tools/theme.

This PR adds the missing files and updates various build scripts to create a fully functioning spectrum-two theme.

Note that the spectrum-two theme (like the spectrum and express themes) includes the core-global CSS variables to ensure that application views relying on these variables will not break when migrating to the spectrum-two theme. Per the plan of record, these variables remain deprecated and will be removed in a future major version of SWC.

Related issue(s)

  • SWC-348, SWC-466 (internal JIRA)

Motivation and context

Allow the spectrum-two theme to be used and tested.

How has this been tested?

Tested in the Storybook theme switcher, in both SWC and the downstream UEC project.

graynorton avatar Sep 06 '24 21:09 graynorton

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

github-actions[bot] avatar Sep 10 '24 07:09 github-actions[bot]

Pull Request Test Coverage Report for Build 10789631288

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 98.2%

Totals Coverage Status
Change from base Build 10718063455: -0.003%
Covered Lines: 32519
Relevant Lines: 32950

💛 - Coveralls

coveralls avatar Sep 10 '24 08:09 coveralls

Tachometer results

Chrome

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 431 kB 78.26ms - 79.61ms - faster ✔
9% - 11%
8.10ms - 10.00ms
branch 647 kB 87.32ms - 88.66ms slower ❌
10% - 13%
8.10ms - 10.00ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 501 kB 51.19ms - 52.06ms - faster ✔
7% - 9%
3.76ms - 5.30ms
branch 704 kB 55.52ms - 56.80ms slower ❌
7% - 10%
3.76ms - 5.30ms
-

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 529 kB 71.92ms - 73.34ms - faster ✔
5% - 7%
3.63ms - 5.56ms
branch 742 kB 76.58ms - 77.88ms slower ❌
5% - 8%
3.63ms - 5.56ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 552 kB 47.95ms - 50.06ms - faster ✔
8% - 13%
4.54ms - 6.95ms
branch 766 kB 54.17ms - 55.33ms slower ❌
9% - 14%
4.54ms - 6.95ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 669 kB 137.36ms - 139.86ms - faster ✔
7% - 10%
11.21ms - 15.18ms
branch 880 kB 150.26ms - 153.34ms slower ❌
8% - 11%
11.21ms - 15.18ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 623 kB 66.74ms - 68.09ms - faster ✔
9% - 11%
6.49ms - 8.42ms
branch 837 kB 74.17ms - 75.56ms slower ❌
10% - 13%
6.49ms - 8.42ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 622 kB 64.89ms - 66.07ms - faster ✔
10% - 12%
7.41ms - 9.13ms
branch 836 kB 73.12ms - 74.37ms slower ❌
11% - 14%
7.41ms - 9.13ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 813 kB 1879.27ms - 1881.98ms - unsure 🔍
-0% - -0%
-8.73ms - -4.54ms
branch 1.01 MB 1885.66ms - 1888.86ms unsure 🔍
+0% - +0%
+4.54ms - +8.73ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 812 kB 1875.35ms - 1878.21ms - unsure 🔍
-0% - -0%
-9.34ms - -5.08ms
branch 1.01 MB 1882.41ms - 1885.56ms unsure 🔍
+0% - +0%
+5.08ms - +9.34ms
-

alert-banner permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 439 kB 11.99ms - 12.27ms - faster ✔
17% - 19%
2.54ms - 2.91ms
branch 651 kB 14.73ms - 14.98ms slower ❌
21% - 24%
2.54ms - 2.91ms
-

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 467 kB 103.29ms - 104.09ms - faster ✔
8% - 9%
8.59ms - 10.73ms
branch 675 kB 112.36ms - 114.35ms slower ❌
8% - 10%
8.59ms - 10.73ms
-

asset permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 373 kB 8.66ms - 8.78ms - faster ✔
22% - 23%
2.44ms - 2.59ms
branch 586 kB 11.19ms - 11.28ms slower ❌
28% - 30%
2.44ms - 2.59ms
-

avatar permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 412 kB 18.06ms - 18.28ms - faster ✔
14% - 16%
3.09ms - 3.45ms
branch 623 kB 21.30ms - 21.58ms slower ❌
17% - 19%
3.09ms - 3.45ms
-

badge permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 412 kB 22.06ms - 22.53ms - faster ✔
10% - 13%
2.61ms - 3.26ms
branch 625 kB 25.00ms - 25.45ms slower ❌
12% - 15%
2.61ms - 3.26ms
-

banner permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 372 kB 10.26ms - 10.44ms - faster ✔
20% - 21%
2.53ms - 2.77ms
branch 586 kB 12.92ms - 13.08ms slower ❌
24% - 27%
2.53ms - 2.77ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 686 kB 490.23ms - 495.24ms - faster ✔
0% - 2%
0.11ms - 9.32ms
branch 892 kB 493.58ms - 501.31ms slower ❌
0% - 2%
0.11ms - 9.32ms
-

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 458 kB 42.63ms - 43.48ms - faster ✔
10% - 13%
5.06ms - 6.29ms
branch 667 kB 48.28ms - 49.18ms slower ❌
12% - 15%
5.06ms - 6.29ms
-

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 464 kB 47.97ms - 48.88ms - faster ✔
8% - 10%
3.96ms - 5.32ms
branch 673 kB 52.56ms - 53.57ms slower ❌
8% - 11%
3.96ms - 5.32ms
-

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 517 kB 37.92ms - 38.53ms - faster ✔
8% - 10%
3.14ms - 4.14ms
branch 733 kB 41.47ms - 42.26ms slower ❌
8% - 11%
3.14ms - 4.14ms
-

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 430 kB 39.30ms - 39.87ms - faster ✔
9% - 12%
4.00ms - 5.19ms
branch 642 kB 43.66ms - 44.71ms slower ❌
10% - 13%
4.00ms - 5.19ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 91.92ms - 93.53ms - faster ✔
5% - 8%
5.17ms - 7.50ms
branch 847 kB 98.22ms - 99.90ms slower ❌
6% - 8%
5.17ms - 7.50ms
-

color-area permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 469 kB 123.13ms - 123.96ms - faster ✔
7% - 8%
8.73ms - 11.12ms
branch 680 kB 132.35ms - 134.59ms slower ❌
7% - 9%
8.73ms - 11.12ms
-

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 502 kB 42.07ms - 42.92ms - faster ✔
7% - 9%
3.34ms - 4.36ms
branch 714 kB 46.06ms - 46.62ms slower ❌
8% - 10%
3.34ms - 4.36ms
-

color-handle permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 386 kB 20.26ms - 20.62ms - faster ✔
13% - 15%
2.98ms - 3.53ms
branch 598 kB 23.49ms - 23.90ms slower ❌
14% - 17%
2.98ms - 3.53ms
-

color-loupe permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 378 kB 14.63ms - 14.89ms - faster ✔
14% - 16%
2.48ms - 2.81ms
branch 590 kB 17.30ms - 17.51ms slower ❌
17% - 19%
2.48ms - 2.81ms
-

color-slider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 471 kB 105.09ms - 107.48ms - faster ✔
5% - 8%
6.13ms - 8.65ms
branch 682 kB 113.28ms - 114.06ms slower ❌
6% - 8%
6.13ms - 8.65ms
-

color-wheel permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 472 kB 101.90ms - 102.77ms - faster ✔
7% - 8%
8.20ms - 9.34ms
branch 683 kB 110.73ms - 111.47ms slower ❌
8% - 9%
8.20ms - 9.34ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 730 kB 37.22ms - 37.78ms - faster ✔
15% - 17%
6.85ms - 7.70ms
branch 929 kB 44.46ms - 45.10ms slower ❌
18% - 21%
6.85ms - 7.70ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 730 kB 390.08ms - 396.41ms - faster ✔
6% - 8%
26.96ms - 36.21ms
branch 929 kB 421.45ms - 428.20ms slower ❌
7% - 9%
26.96ms - 36.21ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 657 kB 49.87ms - 50.91ms - faster ✔
11% - 13%
6.16ms - 7.71ms
branch 868 kB 56.75ms - 57.90ms slower ❌
12% - 15%
6.16ms - 7.71ms
-

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 524 kB 75.53ms - 76.91ms - faster ✔
6% - 8%
5.29ms - 6.87ms
branch 734 kB 81.90ms - 82.69ms slower ❌
7% - 9%
5.29ms - 6.87ms
-

divider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 374 kB 8.86ms - 8.99ms - faster ✔
22% - 23%
2.52ms - 2.68ms
branch 586 kB 11.47ms - 11.58ms slower ❌
28% - 30%
2.52ms - 2.68ms
-

dropzone permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 382 kB 14.83ms - 15.05ms - faster ✔
15% - 16%
2.60ms - 2.93ms
branch 595 kB 17.59ms - 17.83ms slower ❌
17% - 20%
2.60ms - 2.93ms
-

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 436 kB 44.73ms - 45.56ms - faster ✔
7% - 9%
3.26ms - 4.53ms
branch 648 kB 48.56ms - 49.52ms slower ❌
7% - 10%
3.26ms - 4.53ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 405 kB 20.02ms - 20.45ms - faster ✔
12% - 14%
2.78ms - 3.34ms
branch 618 kB 23.11ms - 23.48ms slower ❌
14% - 17%
2.78ms - 3.34ms
-

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 401 kB 9.91ms - 10.22ms - faster ✔
21% - 23%
2.67ms - 3.03ms
branch 613 kB 12.83ms - 13.00ms slower ❌
26% - 31%
2.67ms - 3.03ms
-

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 409 kB 10.96ms - 11.29ms - faster ✔
19% - 28%
2.63ms - 4.24ms
branch 620 kB 13.77ms - 15.34ms slower ❌
24% - 38%
2.63ms - 4.24ms
-

illustrated-message permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 417 kB 13.54ms - 13.79ms - faster ✔
17% - 19%
2.82ms - 3.19ms
branch 631 kB 16.52ms - 16.81ms slower ❌
20% - 24%
2.82ms - 3.19ms
-

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 417 kB 14.68ms - 14.97ms - faster ✔
20% - 23%
3.74ms - 4.45ms
branch 629 kB 18.60ms - 19.24ms slower ❌
25% - 30%
3.74ms - 4.45ms
-

link permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 399 kB 13.30ms - 13.62ms - faster ✔
18% - 20%
2.89ms - 3.30ms
branch 610 kB 16.42ms - 16.69ms slower ❌
21% - 25%
2.89ms - 3.30ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 214.97ms - 218.25ms - faster ✔
5% - 6%
10.89ms - 14.95ms
branch 704 kB 228.34ms - 230.73ms slower ❌
5% - 7%
10.89ms - 14.95ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 47.72ms - 48.36ms - faster ✔
9% - 10%
4.57ms - 5.55ms
branch 634 kB 52.73ms - 53.46ms slower ❌
9% - 12%
4.57ms - 5.55ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 539 kB 67.44ms - 68.59ms - faster ✔
13% - 16%
10.36ms - 12.68ms
branch 752 kB 78.53ms - 80.54ms slower ❌
15% - 19%
10.36ms - 12.68ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 711 kB 435.14ms - 439.77ms - faster ✔
2% - 3%
8.48ms - 15.38ms
branch 912 kB 446.83ms - 451.94ms slower ❌
2% - 4%
8.48ms - 15.38ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 791 kB 22.41ms - 22.86ms - faster ✔
18% - 21%
5.10ms - 5.93ms
branch 991 kB 27.80ms - 28.50ms slower ❌
22% - 26%
5.10ms - 5.93ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 780 kB 349.85ms - 353.87ms - faster ✔
4% - 7%
13.57ms - 24.48ms
branch 980 kB 365.81ms - 375.95ms slower ❌
4% - 7%
13.57ms - 24.48ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 577 kB 41.81ms - 43.79ms - faster ✔
9% - 13%
4.29ms - 6.44ms
branch 784 kB 47.74ms - 48.58ms slower ❌
10% - 15%
4.29ms - 6.44ms
-

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 428 kB 25.66ms - 26.73ms - faster ✔
9% - 13%
2.72ms - 3.89ms
branch 641 kB 29.26ms - 29.74ms slower ❌
10% - 15%
2.72ms - 3.89ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 536 kB 509.68ms - 516.52ms - faster ✔
4% - 6%
19.63ms - 30.10ms
branch 746 kB 533.99ms - 541.93ms slower ❌
4% - 6%
19.63ms - 30.10ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 396 kB 11.37ms - 11.84ms - faster ✔
17% - 20%
2.37ms - 2.89ms
branch 597 kB 14.11ms - 14.35ms slower ❌
20% - 25%
2.37ms - 2.89ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 422 kB 27.98ms - 28.51ms - faster ✔
10% - 12%
3.14ms - 3.93ms
branch 635 kB 31.49ms - 32.08ms slower ❌
11% - 14%
3.14ms - 3.93ms
-

progress-circle permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 398 kB 15.70ms - 16.10ms - faster ✔
15% - 18%
2.90ms - 3.52ms
branch 609 kB 18.87ms - 19.35ms slower ❌
18% - 22%
2.90ms - 3.52ms
-

quick-actions permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 373 kB 8.91ms - 9.04ms - faster ✔
22% - 23%
2.50ms - 2.67ms
branch 587 kB 11.50ms - 11.62ms slower ❌
28% - 30%
2.50ms - 2.67ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 36.46ms - 37.19ms - faster ✔
7% - 10%
2.74ms - 3.84ms
branch 632 kB 39.70ms - 40.53ms slower ❌
7% - 10%
2.74ms - 3.84ms
-

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 487 kB 39.29ms - 41.61ms - faster ✔
7% - 18%
3.15ms - 8.76ms
branch 698 kB 43.85ms - 48.96ms slower ❌
8% - 22%
3.15ms - 8.76ms
-

sidenav permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 443 kB 158.17ms - 161.05ms - faster ✔
10% - 12%
17.06ms - 20.96ms
branch 656 kB 177.30ms - 179.94ms slower ❌
11% - 13%
17.06ms - 20.96ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 495 kB 77.77ms - 79.00ms - faster ✔
6% - 8%
5.09ms - 7.16ms
branch 708 kB 83.68ms - 85.35ms slower ❌
6% - 9%
5.09ms - 7.16ms
-

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 747 kB 1868.97ms - 1871.83ms - faster ✔
0% - 1%
5.14ms - 9.79ms
branch 949 kB 1876.03ms - 1879.70ms slower ❌
0% - 1%
5.14ms - 9.79ms
-

split-view permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 409 kB 32.77ms - 35.04ms - faster ✔
14% - 20%
5.46ms - 8.38ms
branch 620 kB 39.90ms - 41.74ms slower ❌
16% - 25%
5.46ms - 8.38ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 422 kB 13.34ms - 13.68ms - faster ✔
21% - 23%
3.53ms - 4.01ms
branch 634 kB 17.11ms - 17.45ms slower ❌
26% - 30%
3.53ms - 4.01ms
-

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 414 kB 14.95ms - 15.86ms - faster ✔
15% - 22%
2.74ms - 4.17ms
branch 626 kB 18.31ms - 19.41ms slower ❌
17% - 28%
2.74ms - 4.17ms
-

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 546 kB 123.41ms - 125.32ms - faster ✔
4% - 6%
4.95ms - 7.72ms
branch 739 kB 129.70ms - 131.69ms slower ❌
4% - 6%
4.95ms - 7.72ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 441 kB 113.52ms - 114.67ms - faster ✔
6% - 7%
6.77ms - 8.55ms
branch 651 kB 121.07ms - 122.43ms slower ❌
6% - 8%
6.77ms - 8.55ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 465 kB 12.38ms - 12.55ms - faster ✔
16% - 18%
2.37ms - 2.72ms
branch 678 kB 14.86ms - 15.16ms slower ❌
19% - 22%
2.37ms - 2.72ms
-

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 447 kB 24.48ms - 25.89ms - faster ✔
15% - 20%
4.40ms - 6.19ms
branch 659 kB 29.93ms - 31.03ms slower ❌
17% - 25%
4.40ms - 6.19ms
-

thumbnail permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 774 kB 23.08ms - 23.93ms - faster ✔
10% - 14%
2.70ms - 3.84ms
branch 986 kB 26.40ms - 27.15ms slower ❌
11% - 17%
2.70ms - 3.84ms
-

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 445 kB 27.30ms - 28.69ms - faster ✔
11% - 18%
3.58ms - 5.90ms
branch 658 kB 31.80ms - 33.67ms slower ❌
13% - 21%
3.58ms - 5.90ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 587 kB 34.64ms - 35.33ms - faster ✔
9% - 12%
3.66ms - 4.71ms
branch 803 kB 38.78ms - 39.57ms slower ❌
10% - 14%
3.66ms - 4.71ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 548 kB 23.55ms - 24.08ms - faster ✔
15% - 18%
4.17ms - 5.12ms
branch 761 kB 28.07ms - 28.86ms slower ❌
17% - 22%
4.17ms - 5.12ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 672 kB 53.28ms - 54.38ms - faster ✔
8% - 10%
4.79ms - 6.24ms
branch 883 kB 58.87ms - 59.82ms slower ❌
9% - 12%
4.79ms - 6.24ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 648 kB 42.64ms - 43.40ms - faster ✔
11% - 13%
5.16ms - 6.29ms
branch 859 kB 48.32ms - 49.16ms slower ❌
12% - 15%
5.16ms - 6.29ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 447 kB 40.15ms - 42.86ms - faster ✔
4% - 13%
1.83ms - 6.17ms
branch 657 kB 43.81ms - 47.20ms slower ❌
4% - 15%
1.83ms - 6.17ms
-

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 538 kB 98.39ms - 99.19ms - faster ✔
10% - 11%
10.94ms - 12.26ms
branch 749 kB 109.87ms - 110.92ms slower ❌
11% - 12%
10.94ms - 12.26ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 544 kB 58.40ms - 61.52ms - faster ✔
9% - 18%
6.16ms - 12.44ms
branch 754 kB 66.53ms - 71.99ms slower ❌
10% - 21%
6.16ms - 12.44ms
-

underlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 373 kB 9.25ms - 9.35ms - faster ✔
21% - 22%
2.53ms - 2.69ms
branch 585 kB 11.85ms - 11.97ms slower ❌
27% - 29%
2.53ms - 2.69ms
-
Firefox

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 431 kB 163.07ms - 166.81ms - faster ✔
8% - 12%
14.47ms - 21.89ms
branch 647 kB 179.92ms - 186.32ms slower ❌
9% - 13%
14.47ms - 21.89ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 501 kB 109.80ms - 115.40ms - faster ✔
4% - 10%
4.78ms - 12.30ms
branch 704 kB 118.64ms - 123.64ms slower ❌
4% - 11%
4.78ms - 12.30ms
-

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 529 kB 144.51ms - 150.97ms - faster ✔
5% - 10%
7.12ms - 15.96ms
branch 742 kB 156.27ms - 162.29ms slower ❌
5% - 11%
7.12ms - 15.96ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 552 kB 111.66ms - 118.74ms - faster ✔
4% - 11%
4.99ms - 14.49ms
branch 766 kB 121.78ms - 128.10ms slower ❌
4% - 13%
4.99ms - 14.49ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 669 kB 275.83ms - 278.73ms - faster ✔
13% - 16%
42.47ms - 51.33ms
branch 880 kB 320.00ms - 328.36ms slower ❌
15% - 19%
42.47ms - 51.33ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 623 kB 133.55ms - 136.53ms - faster ✔
2% - 4%
2.44ms - 6.04ms
branch 837 kB 138.27ms - 140.29ms slower ❌
2% - 5%
2.44ms - 6.04ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 622 kB 130.35ms - 138.25ms - unsure 🔍
-5% - +1%
-6.94ms - +1.50ms
branch 836 kB 135.52ms - 138.52ms unsure 🔍
-1% - +5%
-1.50ms - +6.94ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 813 kB 1901.74ms - 1908.62ms - unsure 🔍
-0% - -0%
-8.35ms - -0.65ms
branch 1.01 MB 1907.96ms - 1911.40ms unsure 🔍
+0% - +0%
+0.65ms - +8.35ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 812 kB 1894.17ms - 1899.91ms - faster ✔
0% - 1%
4.04ms - 11.80ms
branch 1.01 MB 1902.36ms - 1907.56ms slower ❌
0% - 1%
4.04ms - 11.80ms
-

alert-banner permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 439 kB 27.55ms - 30.61ms - faster ✔
13% - 25%
4.43ms - 9.33ms
branch 651 kB 34.05ms - 37.87ms slower ❌
14% - 33%
4.43ms - 9.33ms
-

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 467 kB 198.13ms - 204.39ms - faster ✔
3% - 7%
6.00ms - 15.32ms
branch 675 kB 208.46ms - 215.38ms slower ❌
3% - 8%
6.00ms - 15.32ms
-

asset permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 373 kB 21.56ms - 23.96ms - faster ✔
10% - 23%
2.49ms - 6.31ms
branch 586 kB 25.67ms - 28.65ms slower ❌
10% - 28%
2.49ms - 6.31ms
-

avatar permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 412 kB 45.83ms - 49.25ms - faster ✔
6% - 15%
3.10ms - 8.02ms
branch 623 kB 51.33ms - 54.87ms slower ❌
6% - 17%
3.10ms - 8.02ms
-

badge permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 412 kB 48.59ms - 52.57ms - faster ✔
7% - 17%
3.92ms - 10.16ms
branch 625 kB 55.21ms - 60.03ms slower ❌
7% - 20%
3.92ms - 10.16ms
-

banner permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 372 kB 21.78ms - 23.50ms - faster ✔
17% - 25%
4.62ms - 7.50ms
branch 586 kB 27.55ms - 29.85ms slower ❌
20% - 34%
4.62ms - 7.50ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 686 kB 779.56ms - 797.00ms - slower ❌
1% - 4%
9.83ms - 29.89ms
branch 892 kB 763.46ms - 773.38ms faster ✔
1% - 4%
9.83ms - 29.89ms
-

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 458 kB 93.94ms - 100.62ms - faster ✔
7% - 15%
7.06ms - 16.66ms
branch 667 kB 105.68ms - 112.60ms slower ❌
7% - 17%
7.06ms - 16.66ms
-

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 464 kB 102.18ms - 106.74ms - faster ✔
9% - 14%
10.04ms - 17.36ms
branch 673 kB 115.29ms - 121.03ms slower ❌
9% - 17%
10.04ms - 17.36ms
-

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 517 kB 70.36ms - 74.88ms - faster ✔
6% - 13%
4.26ms - 10.66ms
branch 733 kB 77.82ms - 82.34ms slower ❌
6% - 15%
4.26ms - 10.66ms
-

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 430 kB 93.31ms - 98.53ms - faster ✔
0% - 7%
0.23ms - 6.73ms
branch 642 kB 97.47ms - 101.33ms slower ❌
0% - 7%
0.23ms - 6.73ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 183.80ms - 186.92ms - faster ✔
6% - 8%
11.24ms - 15.24ms
branch 847 kB 197.35ms - 199.85ms slower ❌
6% - 8%
11.24ms - 15.24ms
-

color-area permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 469 kB 186.03ms - 193.61ms - faster ✔
3% - 9%
6.35ms - 18.81ms
branch 680 kB 197.46ms - 207.34ms slower ❌
3% - 10%
6.35ms - 18.81ms
-

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 510 kB 76.38ms - 79.94ms - faster ✔
6% - 11%
4.91ms - 9.37ms
branch 722 kB 83.95ms - 86.65ms slower ❌
6% - 12%
4.91ms - 9.37ms
-

color-handle permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 386 kB 44.85ms - 48.63ms - faster ✔
7% - 17%
3.52ms - 9.36ms
branch 598 kB 50.96ms - 55.40ms slower ❌
7% - 20%
3.52ms - 9.36ms
-

color-loupe permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 378 kB 29.20ms - 31.52ms - faster ✔
12% - 22%
4.03ms - 8.49ms
branch 590 kB 34.72ms - 38.52ms slower ❌
13% - 28%
4.03ms - 8.49ms
-

color-slider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 471 kB 160.20ms - 167.12ms - unsure 🔍
-5% - +0%
-8.44ms - +0.08ms
branch 682 kB 165.35ms - 170.33ms unsure 🔍
-0% - +5%
-0.08ms - +8.44ms
-

color-wheel permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 472 kB 155.41ms - 161.19ms - faster ✔
4% - 8%
5.87ms - 13.81ms
branch 683 kB 165.42ms - 170.86ms slower ❌
4% - 9%
5.87ms - 13.81ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 730 kB 61.63ms - 63.57ms - faster ✔
15% - 19%
10.85ms - 14.07ms
branch 929 kB 73.77ms - 76.35ms slower ❌
17% - 23%
10.85ms - 14.07ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 730 kB 752.18ms - 772.26ms - unsure 🔍
-1% - +3%
-6.54ms - +23.66ms
branch 929 kB 742.38ms - 764.94ms unsure 🔍
-3% - +1%
-23.66ms - +6.54ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 657 kB 107.75ms - 113.41ms - faster ✔
5% - 12%
5.82ms - 14.26ms
branch 868 kB 117.48ms - 123.76ms slower ❌
5% - 13%
5.82ms - 14.26ms
-

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 524 kB 123.76ms - 130.84ms - faster ✔
4% - 11%
5.38ms - 16.06ms
branch 734 kB 134.02ms - 142.02ms slower ❌
4% - 13%
5.38ms - 16.06ms
-

divider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 374 kB 20.75ms - 23.37ms - faster ✔
12% - 24%
2.94ms - 6.58ms
branch 586 kB 25.55ms - 28.09ms slower ❌
12% - 31%
2.94ms - 6.58ms
-

dropzone permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 382 kB 25.39ms - 26.57ms - faster ✔
14% - 19%
4.27ms - 5.85ms
branch 595 kB 30.52ms - 31.56ms slower ❌
16% - 23%
4.27ms - 5.85ms
-

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 436 kB 101.48ms - 108.28ms - faster ✔
4% - 12%
4.35ms - 13.89ms
branch 648 kB 110.65ms - 117.35ms slower ❌
4% - 13%
4.35ms - 13.89ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 405 kB 49.10ms - 53.62ms - faster ✔
12% - 23%
7.13ms - 14.51ms
branch 618 kB 59.26ms - 65.10ms slower ❌
13% - 29%
7.13ms - 14.51ms
-

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 401 kB 21.98ms - 24.02ms - faster ✔
15% - 25%
4.16ms - 7.28ms
branch 613 kB 27.54ms - 29.90ms slower ❌
17% - 32%
4.16ms - 7.28ms
-

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 409 kB 26.88ms - 29.12ms - faster ✔
7% - 15%
2.14ms - 4.90ms
branch 620 kB 30.72ms - 32.32ms slower ❌
7% - 18%
2.14ms - 4.90ms
-

illustrated-message permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 417 kB 26.11ms - 27.41ms - faster ✔
13% - 19%
4.11ms - 5.97ms
branch 631 kB 31.14ms - 32.46ms slower ❌
15% - 23%
4.11ms - 5.97ms
-

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 417 kB 37.28ms - 40.24ms - faster ✔
11% - 20%
4.78ms - 9.14ms
branch 629 kB 44.12ms - 47.32ms slower ❌
12% - 24%
4.78ms - 9.14ms
-

link permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 399 kB 27.87ms - 30.61ms - faster ✔
9% - 19%
3.11ms - 6.61ms
branch 610 kB 33.01ms - 35.19ms slower ❌
10% - 23%
3.11ms - 6.61ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 433.59ms - 448.01ms - faster ✔
11% - 15%
53.87ms - 73.81ms
branch 704 kB 497.75ms - 511.53ms slower ❌
12% - 17%
53.87ms - 73.81ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 82.11ms - 85.77ms - faster ✔
6% - 12%
5.46ms - 11.58ms
branch 634 kB 90.01ms - 94.91ms slower ❌
6% - 14%
5.46ms - 11.58ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 539 kB 144.77ms - 150.87ms - faster ✔
9% - 14%
14.54ms - 22.74ms
branch 752 kB 163.72ms - 169.20ms slower ❌
10% - 16%
14.54ms - 22.74ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 787 kB 663.00ms - 691.56ms - unsure 🔍
-0% - +5%
+0.09ms - +34.47ms
branch 987 kB 650.43ms - 669.57ms faster ✔
0% - 5%
0.09ms - 34.47ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 791 kB 47.06ms - 48.14ms - faster ✔
13% - 16%
7.00ms - 8.68ms
branch 991 kB 54.79ms - 56.09ms slower ❌
15% - 18%
7.00ms - 8.68ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 780 kB 678.08ms - 701.36ms - unsure 🔍
-1% - +4%
-5.16ms - +28.92ms
branch 980 kB 665.40ms - 690.28ms unsure 🔍
-4% - +1%
-28.92ms - +5.16ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 577 kB 89.83ms - 94.81ms - faster ✔
8% - 14%
8.24ms - 14.44ms
branch 784 kB 101.81ms - 105.51ms slower ❌
9% - 16%
8.24ms - 14.44ms
-

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 428 kB 56.19ms - 60.33ms - faster ✔
8% - 18%
5.25ms - 12.03ms
branch 641 kB 64.21ms - 69.59ms slower ❌
9% - 21%
5.25ms - 12.03ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 536 kB 1021.40ms - 1033.40ms - faster ✔
6% - 8%
64.61ms - 94.23ms
branch 746 kB 1093.27ms - 1120.37ms slower ❌
6% - 9%
64.61ms - 94.23ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 396 kB 30.02ms - 32.86ms - faster ✔
14% - 26%
4.95ms - 10.57ms
branch 597 kB 36.78ms - 41.62ms slower ❌
15% - 34%
4.95ms - 10.57ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 422 kB 60.50ms - 64.70ms - faster ✔
7% - 15%
4.49ms - 10.43ms
branch 635 kB 67.96ms - 72.16ms slower ❌
7% - 17%
4.49ms - 10.43ms
-

progress-circle permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 398 kB 33.85ms - 36.03ms - faster ✔
15% - 24%
6.33ms - 10.79ms
branch 609 kB 41.55ms - 45.45ms slower ❌
18% - 31%
6.33ms - 10.79ms
-

quick-actions permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 373 kB 19.32ms - 20.44ms - faster ✔
16% - 23%
3.98ms - 5.66ms
branch 587 kB 24.07ms - 25.33ms slower ❌
20% - 29%
3.98ms - 5.66ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 76.41ms - 80.51ms - faster ✔
4% - 11%
3.62ms - 9.14ms
branch 632 kB 83.00ms - 86.68ms slower ❌
4% - 12%
3.62ms - 9.14ms
-

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 487 kB 77.58ms - 82.66ms - faster ✔
8% - 16%
7.43ms - 14.89ms
branch 698 kB 88.55ms - 94.01ms slower ❌
9% - 19%
7.43ms - 14.89ms
-

sidenav permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 443 kB 351.45ms - 364.35ms - faster ✔
5% - 10%
20.58ms - 38.74ms
branch 656 kB 381.17ms - 393.95ms slower ❌
6% - 11%
20.58ms - 38.74ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 495 kB 159.78ms - 166.46ms - faster ✔
3% - 8%
4.63ms - 13.65ms
branch 708 kB 169.24ms - 175.28ms slower ❌
3% - 8%
4.63ms - 13.65ms
-

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 747 kB 1876.90ms - 1881.98ms - faster ✔
1% - 1%
9.57ms - 16.87ms
branch 949 kB 1890.04ms - 1895.28ms slower ❌
1% - 1%
9.57ms - 16.87ms
-

split-view permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 409 kB 71.45ms - 76.91ms - faster ✔
7% - 16%
6.03ms - 13.97ms
branch 620 kB 81.29ms - 87.07ms slower ❌
8% - 19%
6.03ms - 13.97ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 422 kB 30.06ms - 32.98ms - faster ✔
19% - 29%
7.39ms - 12.45ms
branch 634 kB 39.37ms - 43.51ms slower ❌
23% - 40%
7.39ms - 12.45ms
-

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 414 kB 34.41ms - 36.91ms - faster ✔
21% - 30%
9.73ms - 14.83ms
branch 626 kB 45.71ms - 50.17ms slower ❌
27% - 42%
9.73ms - 14.83ms
-

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 546 kB 278.17ms - 289.39ms - faster ✔
2% - 7%
6.12ms - 19.72ms
branch 739 kB 292.86ms - 300.54ms slower ❌
2% - 7%
6.12ms - 19.72ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 441 kB 202.20ms - 211.68ms - faster ✔
1% - 7%
2.97ms - 14.71ms
branch 651 kB 212.33ms - 219.23ms slower ❌
1% - 7%
2.97ms - 14.71ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 465 kB 26.31ms - 28.61ms - faster ✔
10% - 20%
3.21ms - 6.59ms
branch 678 kB 31.12ms - 33.60ms slower ❌
11% - 25%
3.21ms - 6.59ms
-

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 447 kB 48.77ms - 50.87ms - faster ✔
13% - 20%
7.46ms - 12.54ms
branch 659 kB 57.51ms - 62.13ms slower ❌
15% - 25%
7.46ms - 12.54ms
-

thumbnail permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 774 kB 56.26ms - 59.42ms - faster ✔
4% - 12%
2.49ms - 7.71ms
branch 986 kB 60.86ms - 65.02ms slower ❌
4% - 13%
2.49ms - 7.71ms
-

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 445 kB 63.54ms - 67.54ms - faster ✔
8% - 17%
5.63ms - 12.77ms
branch 658 kB 71.79ms - 77.69ms slower ❌
8% - 20%
5.63ms - 12.77ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 672 kB 79.79ms - 84.57ms - slower ❌
0% - 7%
0.27ms - 5.89ms
branch 883 kB 77.63ms - 80.57ms faster ✔
0% - 7%
0.27ms - 5.89ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 548 kB 46.60ms - 48.72ms - faster ✔
11% - 16%
5.80ms - 9.00ms
branch 761 kB 53.87ms - 56.25ms slower ❌
12% - 19%
5.80ms - 9.00ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 672 kB 130.48ms - 136.60ms - unsure 🔍
-1% - +6%
-0.70ms - +7.38ms
branch 883 kB 127.56ms - 132.84ms unsure 🔍
-5% - +0%
-7.38ms - +0.70ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 648 kB 90.95ms - 96.41ms - faster ✔
13% - 20%
14.34ms - 23.46ms
branch 859 kB 108.93ms - 116.23ms slower ❌
15% - 25%
14.34ms - 23.46ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 447 kB 95.01ms - 100.39ms - faster ✔
7% - 13%
7.06ms - 14.14ms
branch 657 kB 106.00ms - 110.60ms slower ❌
7% - 15%
7.06ms - 14.14ms
-

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 538 kB 170.67ms - 178.25ms - faster ✔
2% - 8%
3.99ms - 14.65ms
branch 749 kB 180.03ms - 187.53ms slower ❌
2% - 8%
3.99ms - 14.65ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 544 kB 104.41ms - 110.23ms - faster ✔
8% - 16%
9.03ms - 19.53ms
branch 754 kB 117.22ms - 125.98ms slower ❌
8% - 18%
9.03ms - 19.53ms
-

underlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 373 kB 23.58ms - 26.26ms - faster ✔
11% - 23%
3.19ms - 7.13ms
branch 585 kB 28.64ms - 31.52ms slower ❌
12% - 29%
3.19ms - 7.13ms
-

github-actions[bot] avatar Sep 10 '24 08:09 github-actions[bot]

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 225.79 kB 214.604 kB 🏆 232.15 kB
Scripts 55.349 kB 49.968 kB 🏆 50.162 kB
Stylesheet 34.623 kB 30.219 kB 🏆 47.527 kB
Document 6.19 kB 5.435 kB 🏆 5.449 kB
Font 126.809 kB 126.632 kB 126.623 kB 🏆

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

github-actions[bot] avatar Sep 10 '24 09:09 github-actions[bot]

Great work! I left a few nit comments and a larger question around lightest and darkest artifacts 👍

Thanks for the thorough review and suggestions, @rubencarvalho!

I took care of the nits and commented with my rationale for including the lightest and darkest "facades".

graynorton avatar Sep 12 '24 21:09 graynorton

I'd love to discuss the benefits of supporting non-core styles and lightest/darkest in S2.

@TarunAdobe

As for including the non-core (global) tokens in the spectrum-two system, this is something that I've discussed extensively with @jnjosh, @rubencarvalho and @Rajdeepc, and we've concluded that these tokens should remain in "deprecated" status for SWC 1.x (across all three systems) and be removed in SWC 2.0.

The rationale is that we want to get customers to spectrum-two as quickly and painlessly as possible, then support them in completing larger migration tasks during the SWC 1.x => 2.0 transition (which we expect to last for a year or more). If we were to ship the spectrum-two system in SWC 1.0 without including the legacy tokens, then teams would face potentially significant migration work before they could even try out and adopt spectrum-two.

As for including lightest and darkest in spectrum-two, please see the discussion with @rubencarvalho and @Rajdeepc elsewhere in this PR review. The tl;dr is that I followed the example of the express theme, which I believe is in exactly the same situation as spectrum-two (the system itself does not include lightest and darkest tokens, but the theme is set up to "fall back" to the light and dark tokens if a user sets color to lightest or darkest). We could reasonably make a different choice here, but I don't think that needs to be handled as part of this PR.

Does this make sense?

graynorton avatar Sep 16 '24 18:09 graynorton

I'd love to discuss the benefits of supporting non-core styles and lightest/darkest in S2.

@TarunAdobe

As for including the non-core (global) tokens in the spectrum-two system, this is something that I've discussed extensively with @jnjosh, @rubencarvalho and @Rajdeepc, and we've concluded that these tokens should remain in "deprecated" status for SWC 1.x (across all three systems) and be removed in SWC 2.0.

The rationale is that we want to get customers to spectrum-two as quickly and painlessly as possible, then support them in completing larger migration tasks during the SWC 1.x => 2.0 transition (which we expect to last for a year or more). If we were to ship the spectrum-two system in SWC 1.0 without including the legacy tokens, then teams would face potentially significant migration work before they could even try out and adopt spectrum-two.

As for including lightest and darkest in spectrum-two, please see the discussion with @rubencarvalho and @Rajdeepc elsewhere in this PR review. The tl;dr is that I followed the example of the express theme, which I believe is in exactly the same situation as spectrum-two (the system itself does not include lightest and darkest tokens, but the theme is set up to "fall back" to the light and dark tokens if a user sets color to lightest or darkest). We could reasonably make a different choice here, but I don't think that needs to be handled as part of this PR.

Does this make sense?

Thanks for the explanation! I feel lightest and darkest are not needed to be shipped as a part of spectrum-two reference since these needs to be deleted in 1.0. We would also want to surface this information to the consumers like express to not to use lightest and darkest global tokens and we have already deleted these two color modes already! I am okay to get these shipped as part of S1 but S2 will not have any global definitions of lightest and darkest.

Rajdeepc avatar Sep 18 '24 10:09 Rajdeepc

I feel lightest and darkest are not needed to be shipped as a part of spectrum-two reference since these needs to be deleted in 1.0.

Sure, that makes sense to me. My suggestion would be to merge this PR, and then follow up with a new PR to remove lightest and darkest from both express and spectrum-two.

graynorton avatar Sep 18 '24 15:09 graynorton

I feel lightest and darkest are not needed to be shipped as a part of spectrum-two reference since these needs to be deleted in 1.0.

Sure, that makes sense to me. My suggestion would be to merge this PR, and then follow up with a new PR to remove lightest and darkest from both express and spectrum-two.

I feel lightest and darkest are not needed to be shipped as a part of spectrum-two reference since these needs to be deleted in 1.0.

Sure, that makes sense to me. My suggestion would be to merge this PR, and then follow up with a new PR to remove lightest and darkest from both express and spectrum-two.

Sounds great! I think we are all in the same page now! Thanks everyone

Rajdeepc avatar Sep 18 '24 16:09 Rajdeepc

Closing this PR in favor of the cleanly reconstructed #4859

graynorton avatar Oct 24 '24 20:10 graynorton