spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

chore: added mobile vrt

Open Rajdeepc opened this issue 1 year ago • 4 comments

Description

Related issue(s)

Motivation and context

How has this been tested?

  • [ ] Test case 1

    1. Go here
    2. Do this
  • [ ] Test case 2

    1. Go here
    2. Do this
  • [ ] Did it pass in Desktop?

  • [ ] Did it pass in Mobile?

  • [ ] Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • [ ] I have signed the Adobe Open Source CLA.
  • [ ] My code follows the code style of this project.
  • [ ] If my change required a change to the documentation, I have updated the documentation in this pull request.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Rajdeepc avatar Aug 27 '24 14:08 Rajdeepc

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

github-actions[bot] avatar Aug 27 '24 14:08 github-actions[bot]

Tachometer results

Chrome

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 85.94ms - 88.99ms - faster ✔
1% - 5%
1.01ms - 4.64ms
branch 621 kB 89.30ms - 91.27ms slower ❌
1% - 5%
1.01ms - 4.64ms
-
Firefox

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 182.66ms - 185.34ms - faster ✔
4% - 7%
7.64ms - 14.04ms
branch 621 kB 191.93ms - 197.75ms slower ❌
4% - 8%
7.64ms - 14.04ms
-

github-actions[bot] avatar Aug 27 '24 14:08 github-actions[bot]

Pull Request Test Coverage Report for Build 10593006510

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.202%

Totals Coverage Status
Change from base Build 10578704525: 0.0%
Covered Lines: 32500
Relevant Lines: 32931

💛 - Coveralls

coveralls avatar Aug 27 '24 14:08 coveralls

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 227.319 kB 214.443 kB 🏆 214.471 kB
Scripts 56.62 kB 49.542 kB 🏆 49.876 kB
Stylesheet 34.583 kB 30.333 kB 30.178 kB 🏆
Document 6.207 kB 5.464 kB 5.447 kB 🏆
Font 127.002 kB 126.661 kB 126.622 kB 🏆

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

github-actions[bot] avatar Aug 27 '24 14:08 github-actions[bot]

Closing. Will be taken up in mobile specific dev in 2025

Rajdeepc avatar Nov 18 '24 14:11 Rajdeepc