spectrum-web-components
spectrum-web-components copied to clipboard
adobe
feat(reactive-controller): new pending state controller
Description
The pendingStateController is a centralized controller designed to manage the pending state across various components within the spectrum-web-components library. The goal is to streamline state management, ensuring consistent behavior and appearance when components are in a pending state. Spectrum Design for Pending state
Motivation and context
Objectives
- Centralized State Management: Provide a single source of truth for the pending state, reducing redundancy and potential inconsistencies.
- Improved User Experience: Ensure that users receive clear and consistent feedback when actions are pending.
- Scalability: Allow for easy expansion to include additional components in the future.
How has this been tested?
- [ ] Test case 1
- Go here
- Do this
- [ ] Test case 2
- Go here
- Do this
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)
Checklist
- [x] I have signed the Adobe Open Source CLA.
- [x] My code follows the code style of this project.
- [x] If my change required a change to the documentation, I have updated the documentation in this pull request.
- [x] I have read the CONTRIBUTING document.
- [x] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [x] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.
Branch preview
Visual regression test results
When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
- High Contrast Mode | Medium | LTR
- Spectrum | Lightest | Medium | LTR
- Spectrum | Lightest | Medium | RTL
- Spectrum | Lightest | Large | LTR
- Spectrum | Lightest | Large | RTL
- Spectrum | Light | Medium | LTR
- Spectrum | Light | Medium | RTL
- Spectrum | Light | Large | LTR
- Spectrum | Light | Large | RTL
- Spectrum | Dark | Medium | LTR
- Spectrum | Dark | Medium | RTL
- Spectrum | Dark | Large | LTR
- Spectrum | Dark | Large | RTL
- Spectrum | Darkest | Medium | LTR
- Spectrum | Darkest | Medium | RTL
- Spectrum | Darkest | Large | LTR
- Spectrum | Darkest | Large | RTL
- Express | Lightest | Medium | LTR
- Express | Lightest | Medium | RTL
- Express | Lightest | Large | LTR
- Express | Lightest | Large | RTL
- Express | Light | Medium | LTR
- Express | Light | Medium | RTL
- Express | Light | Large | LTR
- Express | Light | Large | RTL
- Express | Dark | Medium | LTR
- Express | Dark | Medium | RTL
- Express | Dark | Large | LTR
- Express | Dark | Large | RTL
- Express | Darkest | Medium | LTR
- Express | Darkest | Medium | RTL
- Express | Darkest | Large | LTR
- Express | Darkest | Large | RTL
- Spectrum-two | Light | Medium | LTR
- Spectrum-two | Light | Medium | RTL
- Spectrum-two | Light | Large | LTR
- Spectrum-two | Light | Large | RTL
- Spectrum-two | Dark | Medium | LTR
- Spectrum-two | Dark | Medium | RTL
- Spectrum-two | Dark | Large | LTR
- Spectrum-two | Dark | Large | RTL
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Lighthouse scores
| Category | Latest (report) | Main (report) | Branch (report) |
|---|---|---|---|
| Performance | 0.99 | 0.99 | 0.99 |
| Accessibility | 1 | 1 | 1 |
| Best Practices | 1 | 1 | 1 |
| SEO | 1 | 0.92 | 0.92 |
| PWA | 1 | 1 | 1 |
What is this?
Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.
Transfer Size
| Category | Latest | Main | Branch |
|---|---|---|---|
| Total | 226.197 kB | 214.395 kB 🏆 | 217.164 kB |
| Scripts | 55.18 kB | 49.828 kB 🏆 | 52.493 kB |
| Stylesheet | 34.872 kB | 30.098 kB 🏆 | 30.228 kB |
| Document | 6.191 kB | 5.435 kB 🏆 | 5.46 kB |
| Font | 126.968 kB | 126.685 kB | 126.632 kB 🏆 |
Request Count
| Category | Latest | Main | Branch |
|---|---|---|---|
| Total | 52 | 52 | 52 |
| Scripts | 41 | 41 | 41 |
| Stylesheet | 5 | 5 | 5 |
| Document | 1 | 1 | 1 |
| Font | 2 | 2 | 2 |
Tachometer results
Chrome
accordion permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 431 kB | 79.18ms - 80.56ms | - | faster ✔ 7% - 10% 5.93ms - 8.36ms |
| branch | 408 kB | 86.01ms - 88.02ms | slower ❌ 7% - 11% 5.93ms - 8.36ms |
- |
action-bar permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 501 kB | 51.40ms - 52.28ms | - | faster ✔ 3% - 6% 1.78ms - 3.34ms |
| branch | 477 kB | 53.75ms - 55.04ms | slower ❌ 3% - 6% 1.78ms - 3.34ms |
- |
action-button permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 529 kB | 71.69ms - 75.58ms | - | faster ✔ 2% - 10% 1.06ms - 7.88ms |
| branch | 519 kB | 75.31ms - 80.91ms | slower ❌ 1% - 11% 1.06ms - 7.88ms |
- |
action-group permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 552 kB | 48.39ms - 49.54ms | - | faster ✔ 3% - 7% 1.73ms - 3.81ms |
| branch | 542 kB | 50.86ms - 52.60ms | slower ❌ 3% - 8% 1.73ms - 3.81ms |
- |
action-menu permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 669 kB | 140.91ms - 144.02ms | - | faster ✔ 4% - 7% 6.63ms - 10.99ms |
| branch | 660 kB | 149.75ms - 152.81ms | slower ❌ 5% - 8% 6.63ms - 10.99ms |
- |
test-directive permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 623 kB | 67.09ms - 68.39ms | - | faster ✔ 8% - 10% 5.52ms - 7.74ms |
| branch | 617 kB | 73.48ms - 75.27ms | slower ❌ 8% - 11% 5.52ms - 7.74ms |
- |
test-lazy permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 622 kB | 65.63ms - 66.88ms | - | faster ✔ 6% - 9% 4.43ms - 6.31ms |
| branch | 616 kB | 70.92ms - 72.32ms | slower ❌ 7% - 10% 4.43ms - 6.31ms |
- |
test-open-close-directive permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 815 kB | 1880.81ms - 1883.36ms | - | unsure 🔍 +0% - +0% +4.46ms - +8.41ms |
| branch | 803 kB | 1874.14ms - 1877.16ms | unsure 🔍 -0% - -0% -8.41ms - -4.46ms |
- |
test-open-close permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 813 kB | 1876.99ms - 1880.19ms | - | unsure 🔍 -0% - +0% -3.79ms - +0.40ms |
| branch | 801 kB | 1878.93ms - 1881.64ms | unsure 🔍 -0% - +0% -0.40ms - +3.79ms |
- |
alert-banner permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 439 kB | 11.69ms - 12.18ms | - | faster ✔ 1% - 8% 0.12ms - 0.97ms |
| branch | 415 kB | 12.14ms - 12.83ms | slower ❌ 1% - 8% 0.12ms - 0.97ms |
- |
alert-dialog permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 467 kB | 103.31ms - 105.17ms | - | faster ✔ 3% - 5% 3.06ms - 5.17ms |
| branch | 456 kB | 107.86ms - 108.85ms | slower ❌ 3% - 5% 3.06ms - 5.17ms |
- |
breadcrumbs permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 686 kB | 493.16ms - 498.94ms | - | faster ✔ 1% - 3% 6.21ms - 14.67ms |
| branch | 677 kB | 503.40ms - 509.58ms | slower ❌ 1% - 3% 6.21ms - 14.67ms |
- |
button-group permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 458 kB | 42.84ms - 43.65ms | - | faster ✔ 6% - 9% 3.00ms - 4.12ms |
| branch | 447 kB | 46.41ms - 47.20ms | slower ❌ 7% - 10% 3.00ms - 4.12ms |
- |
button permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 464 kB | 48.54ms - 49.52ms | - | faster ✔ 4% - 7% 2.15ms - 3.92ms |
| branch | 453 kB | 51.34ms - 52.80ms | slower ❌ 4% - 8% 2.15ms - 3.92ms |
- |
coachmark permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 648 kB | 92.99ms - 95.04ms | - | faster ✔ 4% - 6% 3.51ms - 6.38ms |
| branch | 634 kB | 97.96ms - 99.96ms | slower ❌ 4% - 7% 3.51ms - 6.38ms |
- |
color-area permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 469 kB | 123.88ms - 124.67ms | - | faster ✔ 1% - 2% 1.84ms - 3.09ms |
| branch | 446 kB | 126.25ms - 127.22ms | slower ❌ 1% - 2% 1.84ms - 3.09ms |
- |
color-slider permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 471 kB | 105.33ms - 106.28ms | - | faster ✔ 1% - 3% 0.97ms - 3.09ms |
| branch | 448 kB | 106.89ms - 108.78ms | slower ❌ 1% - 3% 0.97ms - 3.09ms |
- |
color-wheel permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 472 kB | 102.09ms - 102.83ms | - | faster ✔ 2% - 3% 1.93ms - 3.07ms |
| branch | 449 kB | 104.53ms - 105.39ms | slower ❌ 2% - 3% 1.93ms - 3.07ms |
- |
combobox permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 731 kB | 37.66ms - 38.22ms | - | faster ✔ 3% - 5% 1.19ms - 2.00ms |
| branch | 719 kB | 39.25ms - 39.82ms | slower ❌ 3% - 5% 1.19ms - 2.00ms |
- |
light-dom-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 732 kB | 394.47ms - 400.26ms | - | faster ✔ 2% - 4% 6.57ms - 15.07ms |
| branch | 719 kB | 405.07ms - 411.29ms | slower ❌ 2% - 4% 6.57ms - 15.07ms |
- |
contextual-help permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 658 kB | 50.14ms - 51.32ms | - | faster ✔ 6% - 9% 3.02ms - 4.71ms |
| branch | 645 kB | 53.99ms - 55.20ms | slower ❌ 6% - 9% 3.02ms - 4.71ms |
- |
dialog permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 524 kB | 76.20ms - 76.93ms | - | faster ✔ 0% - 2% 0.01ms - 1.23ms |
| branch | 512 kB | 76.70ms - 77.68ms | slower ❌ 0% - 2% 0.01ms - 1.23ms |
- |
field-label permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 405 kB | 20.56ms - 23.20ms | - | unsure 🔍 -5% - +7% -1.18ms - +1.55ms |
| branch | 382 kB | 21.36ms - 22.03ms | unsure 🔍 -7% - +5% -1.55ms - +1.18ms |
- |
grid permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 474 kB | 40.08ms - 40.68ms | - | slower ❌ 2% - 4% 0.78ms - 1.60ms |
| branch | 431 kB | 38.92ms - 39.47ms | faster ✔ 2% - 4% 0.78ms - 1.60ms |
- |
infield-button permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 417 kB | 14.91ms - 15.25ms | - | faster ✔ 8% - 11% 1.27ms - 1.85ms |
| branch | 393 kB | 16.40ms - 16.88ms | slower ❌ 8% - 12% 1.27ms - 1.85ms |
- |
menu permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 494 kB | 216.64ms - 226.54ms | - | unsure 🔍 -5% - +0% -11.93ms - +0.60ms |
| branch | 471 kB | 223.41ms - 231.10ms | unsure 🔍 -0% - +5% -0.60ms - +11.93ms |
- |
meter permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 421 kB | 48.36ms - 49.11ms | - | faster ✔ 3% - 5% 1.70ms - 2.72ms |
| branch | 397 kB | 50.61ms - 51.29ms | slower ❌ 3% - 6% 1.70ms - 2.72ms |
- |
number-field permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 539 kB | 70.16ms - 71.51ms | - | faster ✔ 10% - 12% 7.68ms - 9.92ms |
| branch | 516 kB | 78.74ms - 80.53ms | slower ❌ 11% - 14% 7.68ms - 9.92ms |
- |
overlay permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 711 kB | 440.11ms - 449.01ms | - | unsure 🔍 -6% - +0% -28.92ms - +1.51ms |
| branch | 699 kB | 443.71ms - 472.82ms | unsure 🔍 -0% - +7% -1.51ms - +28.92ms |
- |
directive-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 792 kB | 22.62ms - 23.15ms | - | faster ✔ 12% - 15% 3.03ms - 3.90ms |
| branch | 778 kB | 26.01ms - 26.70ms | slower ❌ 13% - 17% 3.03ms - 3.90ms |
- |
element-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 782 kB | 354.79ms - 360.78ms | - | faster ✔ 2% - 5% 8.53ms - 16.79ms |
| branch | 768 kB | 367.60ms - 373.30ms | slower ❌ 2% - 5% 8.53ms - 16.79ms |
- |
lazy-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 578 kB | 42.51ms - 43.39ms | - | faster ✔ 7% - 9% 3.02ms - 4.27ms |
| branch | 565 kB | 46.15ms - 47.04ms | slower ❌ 7% - 10% 3.02ms - 4.27ms |
- |
picker-button permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 428 kB | 25.43ms - 25.77ms | - | faster ✔ 4% - 7% 1.14ms - 1.83ms |
| branch | 405 kB | 26.78ms - 27.39ms | slower ❌ 4% - 7% 1.14ms - 1.83ms |
- |
picker permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 536 kB | 512.02ms - 520.36ms | - | faster ✔ 3% - 5% 15.79ms - 28.85ms |
| branch | 527 kB | 533.48ms - 543.54ms | slower ❌ 3% - 6% 15.79ms - 28.85ms |
- |
popover permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 396 kB | 11.28ms - 12.11ms | - | unsure 🔍 -8% - +3% -0.92ms - +0.32ms |
| branch | 374 kB | 11.54ms - 12.45ms | unsure 🔍 -3% - +8% -0.32ms - +0.92ms |
- |
progress-bar permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 422 kB | 28.95ms - 29.43ms | - | faster ✔ 3% - 5% 0.80ms - 1.56ms |
| branch | 398 kB | 30.07ms - 30.67ms | slower ❌ 3% - 5% 0.80ms - 1.56ms |
- |
radio permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 421 kB | 37.21ms - 38.04ms | - | faster ✔ 0% - 3% 0.14ms - 1.22ms |
| branch | 398 kB | 37.95ms - 38.65ms | slower ❌ 0% - 3% 0.14ms - 1.22ms |
- |
search permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 487 kB | 39.58ms - 42.96ms | - | unsure 🔍 -9% - +0% -3.69ms - +0.06ms |
| branch | 463 kB | 42.28ms - 43.89ms | unsure 🔍 -0% - +9% -0.06ms - +3.69ms |
- |
sidenav permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 443 kB | 162.15ms - 166.09ms | - | faster ✔ 8% - 14% 13.54ms - 25.58ms |
| branch | 420 kB | 177.99ms - 189.37ms | slower ❌ 8% - 16% 13.54ms - 25.58ms |
- |
slider permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 495 kB | 79.58ms - 84.41ms | - | unsure 🔍 -8% - +0% -6.53ms - +0.07ms |
| branch | 471 kB | 82.97ms - 87.48ms | unsure 🔍 -0% - +8% -0.07ms - +6.53ms |
- |
split-button permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 749 kB | 1872.36ms - 1875.89ms | - | unsure 🔍 -0% - +0% -0.38ms - +4.64ms |
| branch | 736 kB | 1870.21ms - 1873.77ms | unsure 🔍 -0% - +0% -4.64ms - +0.38ms |
- |
swatch permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 422 kB | 13.36ms - 13.61ms | - | faster ✔ 9% - 11% 1.28ms - 1.70ms |
| branch | 399 kB | 14.80ms - 15.14ms | slower ❌ 9% - 13% 1.28ms - 1.70ms |
- |
tabs permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 441 kB | 112.46ms - 115.29ms | - | unsure 🔍 -3% - +0% -3.02ms - +0.51ms |
| branch | 417 kB | 114.07ms - 116.19ms | unsure 🔍 -0% - +3% -0.51ms - +3.02ms |
- |
tags permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 465 kB | 12.58ms - 12.74ms | - | unsure 🔍 -0% - +2% -0.04ms - +0.23ms |
| branch | 442 kB | 12.46ms - 12.67ms | unsure 🔍 -2% - +0% -0.23ms - +0.04ms |
- |
toast permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 445 kB | 27.19ms - 27.65ms | - | faster ✔ 5% - 8% 1.41ms - 2.23ms |
| branch | 422 kB | 28.90ms - 29.58ms | slower ❌ 5% - 8% 1.41ms - 2.23ms |
- |
tooltip permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 590 kB | 34.37ms - 35.01ms | - | faster ✔ 3% - 6% 1.13ms - 2.02ms |
| branch | 577 kB | 35.96ms - 36.58ms | slower ❌ 3% - 6% 1.13ms - 2.02ms |
- |
test-directive permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 548 kB | 23.16ms - 23.65ms | - | faster ✔ 8% - 11% 2.02ms - 2.84ms |
| branch | 538 kB | 25.51ms - 26.17ms | slower ❌ 9% - 12% 2.02ms - 2.84ms |
- |
test-element permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 673 kB | 52.56ms - 53.45ms | - | faster ✔ 6% - 9% 3.22ms - 4.90ms |
| branch | 660 kB | 56.36ms - 57.77ms | slower ❌ 6% - 9% 3.22ms - 4.90ms |
- |
test-lazy permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 649 kB | 42.42ms - 43.11ms | - | faster ✔ 7% - 9% 3.08ms - 4.27ms |
| branch | 636 kB | 45.95ms - 46.93ms | slower ❌ 7% - 10% 3.08ms - 4.27ms |
- |
top-nav permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 447 kB | 39.76ms - 42.43ms | - | unsure 🔍 -8% - +0% -3.61ms - +0.13ms |
| branch | 423 kB | 41.52ms - 44.15ms | unsure 🔍 -0% - +9% -0.13ms - +3.61ms |
- |
tray permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 538 kB | 99.45ms - 100.38ms | - | faster ✔ 0% - 3% 0.48ms - 3.12ms |
| branch | 526 kB | 100.48ms - 102.95ms | slower ❌ 0% - 3% 0.48ms - 3.12ms |
- |
truncated permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 546 kB | 59.08ms - 59.90ms | - | faster ✔ 3% - 6% 1.67ms - 3.56ms |
| branch | 520 kB | 61.25ms - 62.96ms | slower ❌ 3% - 6% 1.67ms - 3.56ms |
- |
Firefox
accordion permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 431 kB | 170.88ms - 177.24ms | - | faster ✔ 4% - 8% 6.87ms - 15.73ms |
| branch | 408 kB | 182.27ms - 188.45ms | slower ❌ 4% - 9% 6.87ms - 15.73ms |
- |
action-bar permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 501 kB | 112.84ms - 119.04ms | - | unsure 🔍 -7% - +0% -8.27ms - +0.51ms |
| branch | 477 kB | 116.72ms - 122.92ms | unsure 🔍 -0% - +7% -0.51ms - +8.27ms |
- |
action-button permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 529 kB | 150.27ms - 157.49ms | - | faster ✔ 1% - 6% 0.97ms - 9.87ms |
| branch | 519 kB | 156.70ms - 161.90ms | slower ❌ 1% - 6% 0.97ms - 9.87ms |
- |
action-group permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 552 kB | 116.69ms - 122.99ms | - | faster ✔ 1% - 9% 1.09ms - 11.87ms |
| branch | 542 kB | 121.95ms - 130.69ms | slower ❌ 1% - 10% 1.09ms - 11.87ms |
- |
action-menu permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 669 kB | 290.49ms - 295.55ms | - | faster ✔ 10% - 12% 31.37ms - 38.71ms |
| branch | 660 kB | 325.40ms - 330.72ms | slower ❌ 11% - 13% 31.37ms - 38.71ms |
- |
test-directive permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 623 kB | 138.62ms - 140.70ms | - | unsure 🔍 -1% - +1% -1.84ms - +0.72ms |
| branch | 617 kB | 139.47ms - 140.97ms | unsure 🔍 -1% - +1% -0.72ms - +1.84ms |
- |
test-lazy permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 622 kB | 131.57ms - 135.71ms | - | faster ✔ 2% - 5% 2.15ms - 7.25ms |
| branch | 616 kB | 136.84ms - 139.84ms | slower ❌ 2% - 5% 2.15ms - 7.25ms |
- |
test-open-close-directive permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 815 kB | 1903.15ms - 1909.57ms | - | slower ❌ 0% - 1% 3.41ms - 11.91ms |
| branch | 803 kB | 1895.92ms - 1901.48ms | faster ✔ 0% - 1% 3.41ms - 11.91ms |
- |
test-open-close permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 813 kB | 1898.93ms - 1903.51ms | - | unsure 🔍 -0% - +0% -4.20ms - +1.80ms |
| branch | 801 kB | 1900.49ms - 1904.35ms | unsure 🔍 -0% - +0% -1.80ms - +4.20ms |
- |
alert-banner permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 439 kB | 27.30ms - 29.22ms | - | faster ✔ 0% - 11% 0.09ms - 3.39ms |
| branch | 415 kB | 28.65ms - 31.35ms | slower ❌ 0% - 12% 0.09ms - 3.39ms |
- |
alert-dialog permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 467 kB | 204.25ms - 212.19ms | - | unsure 🔍 -4% - +1% -8.54ms - +2.26ms |
| branch | 456 kB | 207.71ms - 215.01ms | unsure 🔍 -1% - +4% -2.26ms - +8.54ms |
- |
breadcrumbs permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 686 kB | 822.11ms - 845.17ms | - | faster ✔ 1% - 4% 7.33ms - 32.51ms |
| branch | 677 kB | 848.50ms - 858.62ms | slower ❌ 1% - 4% 7.33ms - 32.51ms |
- |
button-group permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 458 kB | 102.45ms - 107.79ms | - | faster ✔ 6% - 13% 6.95ms - 14.69ms |
| branch | 447 kB | 113.14ms - 118.74ms | slower ❌ 6% - 14% 6.95ms - 14.69ms |
- |
button permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 464 kB | 113.34ms - 118.30ms | - | faster ✔ 5% - 10% 5.80ms - 13.12ms |
| branch | 453 kB | 122.59ms - 127.97ms | slower ❌ 5% - 11% 5.80ms - 13.12ms |
- |
coachmark permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 648 kB | 195.93ms - 199.39ms | - | faster ✔ 4% - 6% 7.96ms - 12.92ms |
| branch | 634 kB | 206.33ms - 209.87ms | slower ❌ 4% - 7% 7.96ms - 12.92ms |
- |
color-area permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 469 kB | 192.33ms - 198.95ms | - | unsure 🔍 -3% - +2% -5.13ms - +4.65ms |
| branch | 446 kB | 192.28ms - 199.48ms | unsure 🔍 -2% - +3% -4.65ms - +5.13ms |
- |
color-slider permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 471 kB | 163.85ms - 170.23ms | - | faster ✔ 0% - 5% 0.30ms - 9.38ms |
| branch | 448 kB | 168.65ms - 175.11ms | slower ❌ 0% - 6% 0.30ms - 9.38ms |
- |
color-wheel permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 472 kB | 158.41ms - 164.91ms | - | unsure 🔍 -4% - +1% -6.74ms - +2.34ms |
| branch | 449 kB | 160.69ms - 167.03ms | unsure 🔍 -1% - +4% -2.34ms - +6.74ms |
- |
combobox permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 731 kB | 63.68ms - 65.52ms | - | faster ✔ 2% - 6% 1.01ms - 3.83ms |
| branch | 719 kB | 65.96ms - 68.08ms | slower ❌ 2% - 6% 1.01ms - 3.83ms |
- |
light-dom-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 732 kB | 760.46ms - 783.14ms | - | slower ❌ 2% - 5% 13.03ms - 37.45ms |
| branch | 719 kB | 742.04ms - 751.08ms | faster ✔ 2% - 5% 13.03ms - 37.45ms |
- |
contextual-help permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 658 kB | 107.15ms - 112.85ms | - | faster ✔ 2% - 9% 2.63ms - 11.17ms |
| branch | 645 kB | 113.73ms - 120.07ms | slower ❌ 2% - 10% 2.63ms - 11.17ms |
- |
dialog permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 524 kB | 125.96ms - 132.72ms | - | unsure 🔍 -1% - +7% -0.62ms - +8.62ms |
| branch | 512 kB | 122.20ms - 128.48ms | unsure 🔍 -7% - +0% -8.62ms - +0.62ms |
- |
field-label permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 405 kB | 54.21ms - 58.39ms | - | unsure 🔍 -10% - +0% -6.04ms - +0.36ms |
| branch | 382 kB | 56.72ms - 61.56ms | unsure 🔍 -1% - +11% -0.36ms - +6.04ms |
- |
grid permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 474 kB | 84.68ms - 89.00ms | - | unsure 🔍 -5% - +3% -4.00ms - +2.76ms |
| branch | 431 kB | 84.86ms - 90.06ms | unsure 🔍 -3% - +5% -2.76ms - +4.00ms |
- |
infield-button permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 417 kB | 37.84ms - 40.72ms | - | faster ✔ 0% - 10% 0.12ms - 4.28ms |
| branch | 393 kB | 39.97ms - 42.99ms | slower ❌ 0% - 11% 0.12ms - 4.28ms |
- |
menu permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 494 kB | 448.46ms - 458.70ms | - | faster ✔ 1% - 4% 4.47ms - 21.09ms |
| branch | 471 kB | 459.81ms - 472.91ms | slower ❌ 1% - 5% 4.47ms - 21.09ms |
- |
meter permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 421 kB | 85.43ms - 90.13ms | - | unsure 🔍 -7% - +1% -5.99ms - +1.03ms |
| branch | 397 kB | 87.66ms - 92.86ms | unsure 🔍 -1% - +7% -1.03ms - +5.99ms |
- |
number-field permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 539 kB | 148.58ms - 153.90ms | - | faster ✔ 7% - 12% 11.80ms - 19.68ms |
| branch | 516 kB | 164.07ms - 169.89ms | slower ❌ 8% - 13% 11.80ms - 19.68ms |
- |
overlay permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 789 kB | 682.31ms - 700.97ms | - | slower ❌ 2% - 6% 12.94ms - 38.58ms |
| branch | 775 kB | 657.09ms - 674.67ms | faster ✔ 2% - 6% 12.94ms - 38.58ms |
- |
directive-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 792 kB | 48.24ms - 49.08ms | - | faster ✔ 5% - 8% 2.73ms - 4.07ms |
| branch | 778 kB | 51.54ms - 52.58ms | slower ❌ 6% - 8% 2.73ms - 4.07ms |
- |
element-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 782 kB | 693.59ms - 710.13ms | - | slower ❌ 2% - 6% 13.76ms - 41.80ms |
| branch | 768 kB | 662.75ms - 685.41ms | faster ✔ 2% - 6% 13.76ms - 41.80ms |
- |
lazy-test permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 578 kB | 89.79ms - 93.81ms | - | faster ✔ 5% - 10% 4.98ms - 9.90ms |
| branch | 565 kB | 97.83ms - 100.65ms | slower ❌ 5% - 11% 4.98ms - 9.90ms |
- |
picker-button permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 428 kB | 57.18ms - 61.50ms | - | unsure 🔍 -8% - +1% -4.90ms - +0.82ms |
| branch | 405 kB | 59.50ms - 63.26ms | unsure 🔍 -1% - +8% -0.82ms - +4.90ms |
- |
picker permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 536 kB | 1050.56ms - 1061.64ms | - | faster ✔ 4% - 7% 49.66ms - 77.46ms |
| branch | 527 kB | 1106.91ms - 1132.41ms | slower ❌ 5% - 7% 49.66ms - 77.46ms |
- |
popover permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 396 kB | 30.36ms - 33.72ms | - | unsure 🔍 -15% - -0% -5.25ms - +0.05ms |
| branch | 374 kB | 32.59ms - 36.69ms | unsure 🔍 -0% - +17% -0.05ms - +5.25ms |
- |
progress-bar permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 422 kB | 59.86ms - 64.10ms | - | unsure 🔍 -6% - +3% -4.11ms - +1.67ms |
| branch | 398 kB | 61.24ms - 65.16ms | unsure 🔍 -3% - +7% -1.67ms - +4.11ms |
- |
radio permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 421 kB | 75.81ms - 80.75ms | - | unsure 🔍 -8% - +1% -6.60ms - +0.84ms |
| branch | 398 kB | 78.38ms - 83.94ms | unsure 🔍 -1% - +9% -0.84ms - +6.60ms |
- |
search permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 487 kB | 75.67ms - 81.01ms | - | unsure 🔍 -9% - +1% -7.06ms - +1.30ms |
| branch | 463 kB | 78.00ms - 84.44ms | unsure 🔍 -2% - +9% -1.30ms - +7.06ms |
- |
sidenav permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 443 kB | 349.28ms - 363.04ms | - | faster ✔ 5% - 9% 17.40ms - 35.32ms |
| branch | 420 kB | 376.77ms - 388.27ms | slower ❌ 5% - 10% 17.40ms - 35.32ms |
- |
slider permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 495 kB | 160.17ms - 165.99ms | - | faster ✔ 2% - 7% 2.79ms - 12.17ms |
| branch | 471 kB | 166.87ms - 174.25ms | slower ❌ 2% - 8% 2.79ms - 12.17ms |
- |
split-button permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 749 kB | 1876.27ms - 1881.09ms | - | faster ✔ 0% - 1% 2.97ms - 10.31ms |
| branch | 736 kB | 1882.54ms - 1888.10ms | slower ❌ 0% - 1% 2.97ms - 10.31ms |
- |
swatch permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 422 kB | 33.45ms - 36.67ms | - | unsure 🔍 -9% - +3% -3.18ms - +1.02ms |
| branch | 399 kB | 34.79ms - 37.49ms | unsure 🔍 -3% - +9% -1.02ms - +3.18ms |
- |
tabs permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 441 kB | 205.15ms - 210.81ms | - | faster ✔ 0% - 5% 0.24ms - 11.60ms |
| branch | 417 kB | 208.98ms - 218.82ms | slower ❌ 0% - 6% 0.24ms - 11.60ms |
- |
tags permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 465 kB | 27.33ms - 30.51ms | - | unsure 🔍 -5% - +9% -1.35ms - +2.55ms |
| branch | 442 kB | 27.18ms - 29.46ms | unsure 🔍 -9% - +5% -2.55ms - +1.35ms |
- |
toast permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 445 kB | 64.81ms - 70.59ms | - | unsure 🔍 -11% - -0% -7.76ms - +0.04ms |
| branch | 422 kB | 68.95ms - 74.17ms | unsure 🔍 -0% - +12% -0.04ms - +7.76ms |
- |
tooltip permalink
test-basic
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 673 kB | 79.67ms - 85.69ms | - | slower ❌ 6% - 15% 4.46ms - 11.06ms |
| branch | 660 kB | 73.57ms - 76.27ms | faster ✔ 6% - 13% 4.46ms - 11.06ms |
- |
test-directive permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 548 kB | 47.47ms - 49.65ms | - | faster ✔ 2% - 7% 1.02ms - 3.34ms |
| branch | 538 kB | 50.33ms - 51.15ms | slower ❌ 2% - 7% 1.02ms - 3.34ms |
- |
test-element permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 673 kB | 136.82ms - 142.58ms | - | slower ❌ 9% - 15% 11.63ms - 18.33ms |
| branch | 660 kB | 123.01ms - 126.43ms | faster ✔ 9% - 13% 11.63ms - 18.33ms |
- |
test-lazy permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 649 kB | 89.12ms - 93.00ms | - | faster ✔ 14% - 21% 14.82ms - 23.74ms |
| branch | 636 kB | 106.33ms - 114.35ms | slower ❌ 16% - 26% 14.82ms - 23.74ms |
- |
top-nav permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 447 kB | 96.23ms - 100.53ms | - | faster ✔ 2% - 8% 2.15ms - 8.81ms |
| branch | 423 kB | 101.32ms - 106.40ms | slower ❌ 2% - 9% 2.15ms - 8.81ms |
- |
tray permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 538 kB | 170.95ms - 180.33ms | - | unsure 🔍 -3% - +3% -6.00ms - +5.76ms |
| branch | 526 kB | 172.21ms - 179.31ms | unsure 🔍 -3% - +3% -5.76ms - +6.00ms |
- |
truncated permalink
basic-test
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 546 kB | 107.95ms - 113.45ms | - | faster ✔ 1% - 9% 1.02ms - 10.26ms |
| branch | 520 kB | 112.63ms - 120.05ms | slower ❌ 1% - 9% 1.02ms - 10.26ms |
- |
Also @blunteshwar looks like code coverage is failing in the CI. Please look into that too.
Pull Request Test Coverage Report for Build 10900074800
Details
- 164 of 164 (100.0%) changed or added relevant lines in 5 files are covered.
- 12 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-0.006%) to 98.18%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| packages/combobox/src/Combobox.ts | 12 | 97.37% |
| <!-- | Total: | 12 |
| Totals | |
|---|---|
| Change from base Build 10900066689: | -0.006% |
| Covered Lines: | 32624 |
| Relevant Lines: | 33054 |
💛 - Coveralls
@blunteshwar: I think @spectrum-web-components/reactive-controllers is missing as a dependency in the package.json of button and combobox. Can you take a look?
We are not using button or combobox in our reactive controllers internally anywhere so we don't need to add them as the dependencies. However we do use sp-progress-circle in the pending-state controller so I've added it in #4943. Thanks for reporting.