spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

fix(action-bar): include focus-visible polyfilling

Open inasirhussain opened this issue 1 year ago • 1 comments
trafficstars

Description

For older browser and UXP, we have to rely on focus-visible polyfill to match behaviour with the modern browser where the corresponding pseudo-selector is supported.

Related issue(s)

fixes https://github.com/adobe/spectrum-web-components/issues/4279

Motivation and context

How has this been tested?

  • [ ] Test case 1
    1. Go here
    2. Do this
  • [ ] Test case 2
    1. Go here
    2. Do this

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • [ ] I have signed the Adobe Open Source CLA.
  • [ ] My code follows the code style of this project.
  • [ ] If my change required a change to the documentation, I have updated the documentation in this pull request.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

inasirhussain avatar Apr 16 '24 14:04 inasirhussain

As a member of Adobe, Inc. you should be able to self serve access to this repo and make this PR as a branch, rather than a fork, and enjoy our full CI coverage. Would you be able to set that up and reopen this PR?

Westbrook avatar Apr 22 '24 20:04 Westbrook