spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

[Bug]: Samsung Galaxy S23 Ultra Not Considered a Small/Mobile Devoce

Open croberts5 opened this issue 10 months ago • 2 comments

Code of conduct

  • [X] I agree to follow this project's code of conduct.

Impacted component(s)

sp-action-menu

Expected behavior

When opening sp-action-menu on a mobile device (any iPhone for example), the menu items are wrapped in sp-tray. When opening an action menu in a Samsung Galaxy S23 Ultra, the menu items should render in a tray.

Actual behavior

When the device is a Samsung Galaxy S23 Ultra, the menu renders in a popover like a tablet or desktop device.

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to SWC docs for Action menu on a Samsung Galaxy S23 Ultra device
  2. Click on '.... More Actions' button in the "Sizes" section
  3. Assert the menu items are not rendered in a tray

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

croberts5 avatar Apr 11 '24 18:04 croberts5

Can you share whether or not this decide meets the following criteria of "mobile" for our context:

  • (max-width: 700px) and (hover: none) and (pointer: coarse)
    • width of less than 700px
    • does not include support for "hover"
    • has a coarse input device (some Android devices have a stylus which invalidates this check)
  • (max-height: 700px) and (hover: none) and (pointer: coarse)
    • height of less than 700px
    • does not include support for "hover"
    • has a coarse input device (some Android devices have a stylus which invalidates this check)

Westbrook avatar May 09 '24 21:05 Westbrook

@croberts5 Have you been able to see if the device meets the criteria?

najikahalsema avatar May 22 '24 14:05 najikahalsema