spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

fix(styles,theme): add S2 tokens and theme

Open TarunAdobe opened this issue 1 year ago • 16 comments
trafficstars

Introduce spectrum-two styles as a SWC theme.

Description

Todos:

  • [x] Add a script to generate tokens-v2 from the @spectrum-css's next versions.
  • [x] Add spectrum-two theme that takes v2 tokens.
  • [x] Update storybook decorator and documentation site to include spectrum-two theme.
  • [x] Update visual ci test to include spectrum-two theme.
  • [x] Think about documenting these changes

Motivation and context

How has this been tested?

  • [x] Test case 1
    1. Go here
    2. Toggle the theme
  • [x] Test case 2
    1. Go here
    2. Toggle the theme

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • [x] I have signed the Adobe Open Source CLA.
  • [x] My code follows the code style of this project.
  • [ ] If my change required a change to the documentation, I have updated the documentation in this pull request.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.
  • [x] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

TarunAdobe avatar Apr 03 '24 09:04 TarunAdobe

Good start! Let's also think about creating some documentation around this in parallel!

Rajdeepc avatar Apr 03 '24 11:04 Rajdeepc

Looks like it added all the new tests! How ever I'm unable to review them as they are not listed here. They'll also not be listed on the review sites, like this one. That URL also doesn't display as expected...

Westbrook avatar Apr 04 '24 14:04 Westbrook

These may be artifacts of the upstream styling, so perhaps not an issue with this change, but I wanted to note two deltas:

image

image

hunterloftis avatar Apr 05 '24 13:04 hunterloftis

@hunterloftis Would you be able to check why the spectrum 2 css loads in localhost but not in preview url? Is there something we need to add to surface these up to the build?

Rajdeepc avatar Apr 08 '24 16:04 Rajdeepc

@Rajdeepc I don't know if this is related, but when I run yarn storybook locally I see changes that are not currently tracked in this git commit:

image

hunterloftis avatar Apr 09 '24 14:04 hunterloftis

The option to toggle the theme is present in storybook but absent in documentation site

blunteshwar avatar Apr 29 '24 13:04 blunteshwar

Also I think using the word 'system' instead of theme would be more precise and will be more easier to understand because in storybook as well we are using system to toggle between classic, express, spectrum 2

blunteshwar avatar Apr 29 '24 13:04 blunteshwar

Can you ensure that this passes CI before we get into a final review?

Westbrook avatar Apr 30 '24 17:04 Westbrook

can you also make sure that the preview links starts with Spectrum and not Classic anymore

Rajdeepc avatar May 01 '24 12:05 Rajdeepc

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 225.75 kB 210.538 kB 🏆 210.669 kB
Scripts 54.807 kB 48.329 kB 🏆 48.453 kB
Stylesheet 35.068 kB 30.405 kB 30.396 kB 🏆
Document 5.904 kB 5.189 kB 5.188 kB 🏆
Font 126.987 kB 126.615 kB 🏆 126.632 kB

Request Count

Category Latest Main Branch
Total 48 45 45
Scripts 37 37 37
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

github-actions[bot] avatar May 02 '24 03:05 github-actions[bot]

Tachometer results

Chrome

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 416 kB 76.34ms - 80.57ms - faster ✔
4% - 10%
3.21ms - 8.67ms
branch 403 kB 82.67ms - 86.13ms slower ❌
4% - 11%
3.21ms - 8.67ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 484 kB 49.52ms - 51.84ms - faster ✔
0% - 6%
0.11ms - 3.18ms
branch 472 kB 51.33ms - 53.32ms slower ❌
0% - 6%
0.11ms - 3.18ms
-

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 514 kB 69.09ms - 70.85ms - faster ✔
2% - 5%
1.57ms - 4.00ms
branch 502 kB 71.91ms - 73.59ms slower ❌
2% - 6%
1.57ms - 4.00ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 536 kB 45.06ms - 46.43ms - faster ✔
7% - 11%
3.38ms - 5.39ms
branch 524 kB 49.39ms - 50.87ms slower ❌
7% - 12%
3.38ms - 5.39ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 131.95ms - 135.52ms - faster ✔
5% - 9%
7.43ms - 12.37ms
branch 634 kB 141.92ms - 145.35ms slower ❌
5% - 9%
7.43ms - 12.37ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 603 kB 61.32ms - 62.98ms - faster ✔
5% - 10%
3.49ms - 6.81ms
branch 591 kB 65.86ms - 68.73ms slower ❌
6% - 11%
3.49ms - 6.81ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 602 kB 58.80ms - 59.96ms - faster ✔
8% - 11%
5.28ms - 7.35ms
branch 590 kB 64.84ms - 66.56ms slower ❌
9% - 12%
5.28ms - 7.35ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 788 kB 1874.00ms - 1876.88ms - unsure 🔍
-0% - +0%
-2.30ms - +2.01ms
branch 777 kB 1873.98ms - 1877.19ms unsure 🔍
-0% - +0%
-2.01ms - +2.30ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 787 kB 1861.39ms - 1864.10ms - unsure 🔍
-0% - +0%
-2.13ms - +2.53ms
branch 775 kB 1860.65ms - 1864.44ms unsure 🔍
-0% - +0%
-2.53ms - +2.13ms
-

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 452 kB 98.67ms - 100.05ms - faster ✔
2% - 4%
1.88ms - 3.65ms
branch 439 kB 101.56ms - 102.68ms slower ❌
2% - 4%
1.88ms - 3.65ms
-

asset permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 360 kB 8.60ms - 8.69ms - faster ✔
5% - 6%
0.45ms - 0.56ms
branch 349 kB 9.11ms - 9.19ms slower ❌
5% - 7%
0.45ms - 0.56ms
-

avatar permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 397 kB 17.79ms - 18.22ms - faster ✔
0% - 3%
0.05ms - 0.52ms
branch 385 kB 18.20ms - 18.39ms slower ❌
0% - 3%
0.05ms - 0.52ms
-

badge permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 398 kB 21.59ms - 22.09ms - faster ✔
1% - 4%
0.18ms - 0.85ms
branch 385 kB 22.13ms - 22.58ms slower ❌
1% - 4%
0.18ms - 0.85ms
-

banner permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 360 kB 10.25ms - 10.49ms - faster ✔
1% - 4%
0.13ms - 0.41ms
branch 348 kB 10.57ms - 10.70ms slower ❌
1% - 4%
0.13ms - 0.41ms
-

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 443 kB 41.12ms - 42.29ms - faster ✔
3% - 7%
1.40ms - 3.14ms
branch 431 kB 43.33ms - 44.61ms slower ❌
3% - 8%
1.40ms - 3.14ms
-

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 449 kB 45.64ms - 46.87ms - faster ✔
3% - 6%
1.29ms - 3.14ms
branch 437 kB 47.78ms - 49.16ms slower ❌
3% - 7%
1.29ms - 3.14ms
-

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 503 kB 37.38ms - 38.13ms - faster ✔
1% - 4%
0.46ms - 1.72ms
branch 489 kB 38.33ms - 39.35ms slower ❌
1% - 5%
0.46ms - 1.72ms
-

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 416 kB 37.92ms - 38.92ms - faster ✔
2% - 6%
0.85ms - 2.39ms
branch 402 kB 39.46ms - 40.62ms slower ❌
2% - 6%
0.85ms - 2.39ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 629 kB 89.02ms - 90.85ms - faster ✔
4% - 7%
3.91ms - 6.49ms
branch 618 kB 94.23ms - 96.04ms slower ❌
4% - 7%
3.91ms - 6.49ms
-

color-area permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 455 kB 115.13ms - 116.86ms - faster ✔
2% - 4%
2.04ms - 4.21ms
branch 442 kB 118.46ms - 119.78ms slower ❌
2% - 4%
2.04ms - 4.21ms
-

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 488 kB 39.68ms - 40.72ms - faster ✔
1% - 4%
0.50ms - 1.86ms
branch 475 kB 40.94ms - 41.82ms slower ❌
1% - 5%
0.50ms - 1.86ms
-

color-handle permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 373 kB 20.15ms - 20.45ms - faster ✔
2% - 5%
0.51ms - 1.02ms
branch 361 kB 20.85ms - 21.27ms slower ❌
2% - 5%
0.51ms - 1.02ms
-

color-loupe permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 365 kB 14.55ms - 14.68ms - faster ✔
1% - 2%
0.08ms - 0.30ms
branch 353 kB 14.72ms - 14.89ms slower ❌
1% - 2%
0.08ms - 0.30ms
-

color-slider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 457 kB 96.46ms - 97.40ms - faster ✔
2% - 4%
2.47ms - 3.75ms
branch 444 kB 99.60ms - 100.47ms slower ❌
3% - 4%
2.47ms - 3.75ms
-

color-wheel permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 458 kB 95.58ms - 96.48ms - faster ✔
1% - 3%
1.20ms - 2.80ms
branch 445 kB 97.37ms - 98.69ms slower ❌
1% - 3%
1.20ms - 2.80ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 709 kB 35.81ms - 36.30ms - faster ✔
2% - 4%
0.92ms - 1.60ms
branch 697 kB 37.07ms - 37.56ms slower ❌
3% - 4%
0.92ms - 1.60ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 709 kB 379.94ms - 386.62ms - faster ✔
2% - 5%
9.68ms - 19.94ms
branch 697 kB 394.20ms - 401.98ms slower ❌
3% - 5%
9.68ms - 19.94ms
-

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 508 kB 72.35ms - 73.00ms - faster ✔
1% - 2%
0.39ms - 1.27ms
branch 495 kB 73.21ms - 73.80ms slower ❌
1% - 2%
0.39ms - 1.27ms
-

divider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 362 kB 8.71ms - 8.79ms - faster ✔
2% - 3%
0.14ms - 0.26ms
branch 350 kB 8.91ms - 8.99ms slower ❌
2% - 3%
0.14ms - 0.26ms
-

dropzone permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 370 kB 18.31ms - 18.49ms - faster ✔
0% - 2%
0.09ms - 0.31ms
branch 358 kB 18.54ms - 18.67ms slower ❌
0% - 2%
0.09ms - 0.31ms
-

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 422 kB 42.56ms - 43.87ms - faster ✔
1% - 5%
0.41ms - 2.23ms
branch 409 kB 43.91ms - 45.16ms slower ❌
1% - 5%
0.41ms - 2.23ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 391 kB 19.52ms - 19.75ms - faster ✔
3% - 5%
0.54ms - 0.96ms
branch 379 kB 20.22ms - 20.56ms slower ❌
3% - 5%
0.54ms - 0.96ms
-

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 460 kB 36.12ms - 36.73ms - unsure 🔍
-0% - +2%
-0.04ms - +0.84ms
branch 428 kB 35.71ms - 36.35ms unsure 🔍
-2% - +0%
-0.84ms - +0.04ms
-

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 387 kB 9.94ms - 10.04ms - faster ✔
3% - 5%
0.29ms - 0.48ms
branch 374 kB 10.30ms - 10.45ms slower ❌
3% - 5%
0.29ms - 0.48ms
-

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 395 kB 10.85ms - 10.97ms - faster ✔
2% - 3%
0.17ms - 0.36ms
branch 382 kB 11.10ms - 11.25ms slower ❌
2% - 3%
0.17ms - 0.36ms
-

icons permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 374 kB 28.99ms - 29.20ms - faster ✔
2% - 3%
0.45ms - 0.88ms
branch 362 kB 29.58ms - 29.96ms slower ❌
2% - 3%
0.45ms - 0.88ms
-

illustrated-message permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 405 kB 13.36ms - 13.57ms - faster ✔
1% - 4%
0.19ms - 0.50ms
branch 393 kB 13.70ms - 13.93ms slower ❌
1% - 4%
0.19ms - 0.50ms
-

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 402 kB 14.44ms - 14.69ms - faster ✔
6% - 9%
0.91ms - 1.40ms
branch 389 kB 15.51ms - 15.93ms slower ❌
6% - 10%
0.91ms - 1.40ms
-

link permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 384 kB 12.88ms - 13.20ms - faster ✔
4% - 7%
0.49ms - 0.95ms
branch 372 kB 13.59ms - 13.92ms slower ❌
4% - 7%
0.49ms - 0.95ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 476 kB 208.74ms - 212.70ms - faster ✔
1% - 5%
2.38ms - 10.82ms
branch 463 kB 213.59ms - 221.04ms slower ❌
1% - 5%
2.38ms - 10.82ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 407 kB 43.59ms - 44.25ms - faster ✔
2% - 4%
0.88ms - 1.89ms
branch 394 kB 44.92ms - 45.68ms slower ❌
2% - 4%
0.88ms - 1.89ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 523 kB 66.57ms - 68.57ms - faster ✔
9% - 12%
6.50ms - 9.47ms
branch 510 kB 74.45ms - 76.65ms slower ❌
9% - 14%
6.50ms - 9.47ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 676 kB 421.84ms - 425.20ms - faster ✔
1% - 2%
3.74ms - 8.96ms
branch 662 kB 427.88ms - 431.87ms slower ❌
1% - 2%
3.74ms - 8.96ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 776 kB 21.81ms - 22.31ms - faster ✔
8% - 11%
1.97ms - 2.76ms
branch 780 kB 24.11ms - 24.73ms slower ❌
9% - 13%
1.97ms - 2.76ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 761 kB 346.76ms - 350.64ms - faster ✔
1% - 3%
4.33ms - 10.20ms
branch 750 kB 353.77ms - 358.18ms slower ❌
1% - 3%
4.33ms - 10.20ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 561 kB 40.42ms - 41.26ms - faster ✔
6% - 9%
2.45ms - 4.01ms
branch 548 kB 43.41ms - 44.72ms slower ❌
6% - 10%
2.45ms - 4.01ms
-

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 414 kB 24.76ms - 25.19ms - faster ✔
5% - 8%
1.40ms - 2.25ms
branch 401 kB 26.43ms - 27.16ms slower ❌
6% - 9%
1.40ms - 2.25ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 513 kB 519.38ms - 528.59ms - faster ✔
2% - 4%
9.97ms - 23.54ms
branch 500 kB 535.76ms - 545.72ms slower ❌
2% - 5%
9.97ms - 23.54ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 383 kB 11.21ms - 11.80ms - unsure 🔍
-4% - +2%
-0.41ms - +0.20ms
branch 372 kB 11.54ms - 11.68ms unsure 🔍
-2% - +4%
-0.20ms - +0.41ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 408 kB 30.04ms - 30.73ms - faster ✔
0% - 3%
0.06ms - 0.99ms
branch 395 kB 30.60ms - 31.22ms slower ❌
0% - 3%
0.06ms - 0.99ms
-

progress-circle permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 384 kB 15.14ms - 15.57ms - faster ✔
2% - 5%
0.24ms - 0.84ms
branch 371 kB 15.69ms - 16.10ms slower ❌
2% - 5%
0.24ms - 0.84ms
-

quick-actions permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 360 kB 8.93ms - 9.01ms - faster ✔
1% - 2%
0.07ms - 0.19ms
branch 348 kB 9.05ms - 9.15ms slower ❌
1% - 2%
0.07ms - 0.19ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 406 kB 34.93ms - 35.98ms - faster ✔
1% - 5%
0.21ms - 1.66ms
branch 393 kB 35.90ms - 36.89ms slower ❌
1% - 5%
0.21ms - 1.66ms
-

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 472 kB 37.45ms - 38.28ms - faster ✔
3% - 6%
1.27ms - 2.48ms
branch 459 kB 39.29ms - 40.18ms slower ❌
3% - 7%
1.27ms - 2.48ms
-

sidenav permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 428 kB 165.83ms - 170.15ms - faster ✔
7% - 10%
12.37ms - 18.56ms
branch 415 kB 181.24ms - 185.68ms slower ❌
7% - 11%
12.37ms - 18.56ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 480 kB 74.95ms - 76.94ms - faster ✔
2% - 6%
1.61ms - 4.51ms
branch 467 kB 77.95ms - 80.06ms slower ❌
2% - 6%
1.61ms - 4.51ms
-

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 722 kB 1859.66ms - 1864.04ms - unsure 🔍
-0% - +0%
-2.29ms - +3.32ms
branch 710 kB 1859.59ms - 1863.08ms unsure 🔍
-0% - +0%
-3.32ms - +2.29ms
-

split-view permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 395 kB 31.24ms - 31.85ms - faster ✔
1% - 4%
0.25ms - 1.20ms
branch 382 kB 31.91ms - 32.63ms slower ❌
1% - 4%
0.25ms - 1.20ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 408 kB 13.59ms - 13.90ms - faster ✔
5% - 8%
0.68ms - 1.16ms
branch 395 kB 14.48ms - 14.84ms slower ❌
5% - 8%
0.68ms - 1.16ms
-

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 400 kB 14.64ms - 14.94ms - faster ✔
4% - 7%
0.59ms - 1.04ms
branch 387 kB 15.44ms - 15.78ms slower ❌
4% - 7%
0.59ms - 1.04ms
-

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 531 kB 121.81ms - 125.05ms - faster ✔
1% - 5%
1.14ms - 5.92ms
branch 493 kB 125.20ms - 128.71ms slower ❌
1% - 5%
1.14ms - 5.92ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 424 kB 110.55ms - 112.75ms - faster ✔
0% - 3%
0.39ms - 3.36ms
branch 411 kB 112.53ms - 114.52ms slower ❌
0% - 3%
0.39ms - 3.36ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 449 kB 12.29ms - 12.44ms - unsure 🔍
-0% - +1%
-0.04ms - +0.16ms
branch 437 kB 12.24ms - 12.38ms unsure 🔍
-1% - +0%
-0.16ms - +0.04ms
-

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 433 kB 23.76ms - 24.52ms - faster ✔
8% - 12%
2.06ms - 3.26ms
branch 420 kB 26.33ms - 27.26ms slower ❌
8% - 14%
2.06ms - 3.26ms
-

thumbnail permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 761 kB 22.83ms - 23.36ms - faster ✔
2% - 5%
0.54ms - 1.16ms
branch 749 kB 23.78ms - 24.11ms slower ❌
2% - 5%
0.54ms - 1.16ms
-

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 431 kB 27.08ms - 27.86ms - faster ✔
1% - 5%
0.30ms - 1.32ms
branch 418 kB 27.95ms - 28.61ms slower ❌
1% - 5%
0.30ms - 1.32ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 557 kB 33.52ms - 34.25ms - faster ✔
2% - 6%
0.85ms - 1.98ms
branch 538 kB 34.87ms - 35.73ms slower ❌
2% - 6%
0.85ms - 1.98ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 546 kB 23.03ms - 23.65ms - faster ✔
6% - 10%
1.54ms - 2.53ms
branch 542 kB 24.99ms - 25.76ms slower ❌
7% - 11%
1.54ms - 2.53ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 654 kB 51.35ms - 52.59ms - faster ✔
4% - 7%
2.04ms - 3.81ms
branch 643 kB 54.27ms - 55.52ms slower ❌
4% - 7%
2.04ms - 3.81ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 631 kB 41.51ms - 42.49ms - faster ✔
6% - 10%
2.60ms - 4.39ms
branch 619 kB 44.75ms - 46.24ms slower ❌
6% - 11%
2.60ms - 4.39ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 430 kB 37.64ms - 39.17ms - unsure 🔍
-5% - +1%
-2.04ms - +0.21ms
branch 417 kB 38.49ms - 40.15ms unsure 🔍
-1% - +5%
-0.21ms - +2.04ms
-

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 522 kB 95.52ms - 96.53ms - faster ✔
1% - 2%
0.69ms - 2.22ms
branch 509 kB 96.91ms - 98.06ms slower ❌
1% - 2%
0.69ms - 2.22ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 527 kB 54.76ms - 56.34ms - faster ✔
2% - 6%
1.32ms - 3.31ms
branch 516 kB 57.25ms - 58.48ms slower ❌
2% - 6%
1.32ms - 3.31ms
-

underlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 361 kB 9.35ms - 9.42ms - faster ✔
1% - 5%
0.11ms - 0.51ms
branch 349 kB 9.49ms - 9.89ms slower ❌
1% - 5%
0.11ms - 0.51ms
-
Firefox

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 416 kB 160.54ms - 166.06ms - faster ✔
6% - 10%
9.94ms - 18.10ms
branch 403 kB 174.31ms - 180.33ms slower ❌
6% - 11%
9.94ms - 18.10ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 484 kB 111.85ms - 116.75ms - faster ✔
1% - 7%
0.60ms - 8.28ms
branch 472 kB 115.77ms - 121.71ms slower ❌
0% - 7%
0.60ms - 8.28ms
-

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 514 kB 146.70ms - 155.46ms - unsure 🔍
-6% - +0%
-9.84ms - +0.64ms
branch 502 kB 152.80ms - 158.56ms unsure 🔍
-0% - +7%
-0.64ms - +9.84ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 536 kB 114.97ms - 121.47ms - unsure 🔍
-6% - +1%
-7.83ms - +1.03ms
branch 524 kB 118.61ms - 124.63ms unsure 🔍
-1% - +7%
-1.03ms - +7.83ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 270.82ms - 274.50ms - faster ✔
13% - 15%
40.54ms - 46.54ms
branch 634 kB 313.84ms - 318.56ms slower ❌
15% - 17%
40.54ms - 46.54ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 603 kB 127.27ms - 129.53ms - faster ✔
1% - 3%
0.91ms - 3.65ms
branch 591 kB 129.90ms - 131.46ms slower ❌
1% - 3%
0.91ms - 3.65ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 602 kB 153.38ms - 159.06ms - slower ❌
9% - 15%
13.21ms - 20.63ms
branch 590 kB 136.91ms - 141.69ms faster ✔
9% - 13%
13.21ms - 20.63ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 788 kB 1915.25ms - 1923.03ms - slower ❌
2% - 2%
30.09ms - 38.75ms
branch 777 kB 1882.83ms - 1886.61ms faster ✔
2% - 2%
30.09ms - 38.75ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 787 kB 1883.67ms - 1888.69ms - unsure 🔍
-0% - +0%
-3.62ms - +4.50ms
branch 775 kB 1882.55ms - 1888.93ms unsure 🔍
-0% - +0%
-4.50ms - +3.62ms
-

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 452 kB 197.68ms - 205.28ms - unsure 🔍
-4% - +2%
-7.29ms - +3.45ms
branch 439 kB 199.61ms - 207.19ms unsure 🔍
-2% - +4%
-3.45ms - +7.29ms
-

asset permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 360 kB 19.80ms - 22.00ms - unsure 🔍
-8% - +7%
-1.64ms - +1.48ms
branch 349 kB 19.88ms - 22.08ms unsure 🔍
-7% - +8%
-1.48ms - +1.64ms
-

avatar permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 397 kB 42.13ms - 44.99ms - unsure 🔍
-5% - +3%
-2.34ms - +1.42ms
branch 385 kB 42.81ms - 45.23ms unsure 🔍
-3% - +5%
-1.42ms - +2.34ms
-

badge permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 398 kB 50.83ms - 53.97ms - unsure 🔍
-5% - +4%
-2.50ms - +1.90ms
branch 385 kB 51.16ms - 54.24ms unsure 🔍
-4% - +5%
-1.90ms - +2.50ms
-

banner permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 360 kB 25.00ms - 27.56ms - unsure 🔍
-6% - +7%
-1.64ms - +1.92ms
branch 348 kB 24.91ms - 27.37ms unsure 🔍
-7% - +6%
-1.92ms - +1.64ms
-

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 443 kB 92.49ms - 100.55ms - unsure 🔍
-10% - +0%
-10.45ms - +0.21ms
branch 431 kB 98.15ms - 105.13ms unsure 🔍
-0% - +11%
-0.21ms - +10.45ms
-

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 449 kB 98.94ms - 106.50ms - unsure 🔍
-9% - +0%
-9.35ms - +0.55ms
branch 437 kB 103.93ms - 110.31ms unsure 🔍
-1% - +9%
-0.55ms - +9.35ms
-

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 503 kB 73.48ms - 78.84ms - faster ✔
1% - 11%
0.44ms - 8.68ms
branch 489 kB 77.59ms - 83.85ms slower ❌
0% - 12%
0.44ms - 8.68ms
-

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 416 kB 88.43ms - 94.41ms - unsure 🔍
-5% - +4%
-4.21ms - +3.97ms
branch 402 kB 88.75ms - 94.33ms unsure 🔍
-4% - +5%
-3.97ms - +4.21ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 629 kB 183.02ms - 185.58ms - faster ✔
3% - 6%
5.50ms - 10.94ms
branch 618 kB 190.11ms - 194.93ms slower ❌
3% - 6%
5.50ms - 10.94ms
-

color-area permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 455 kB 178.51ms - 187.77ms - unsure 🔍
-5% - +1%
-10.09ms - +1.25ms
branch 442 kB 184.28ms - 190.84ms unsure 🔍
-1% - +6%
-1.25ms - +10.09ms
-

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 496 kB 75.92ms - 78.04ms - faster ✔
1% - 6%
0.90ms - 4.74ms
branch 483 kB 78.20ms - 81.40ms slower ❌
1% - 6%
0.90ms - 4.74ms
-

color-handle permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 373 kB 43.15ms - 46.77ms - unsure 🔍
-3% - +7%
-1.50ms - +2.98ms
branch 361 kB 42.91ms - 45.53ms unsure 🔍
-7% - +3%
-2.98ms - +1.50ms
-

color-loupe permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 365 kB 26.84ms - 27.92ms - unsure 🔍
-6% - +0%
-1.67ms - +0.15ms
branch 353 kB 27.41ms - 28.87ms unsure 🔍
-1% - +6%
-0.15ms - +1.67ms
-

color-slider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 457 kB 167.64ms - 173.36ms - faster ✔
1% - 6%
1.46ms - 10.10ms
branch 444 kB 173.04ms - 179.52ms slower ❌
1% - 6%
1.46ms - 10.10ms
-

color-wheel permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 458 kB 152.78ms - 159.06ms - unsure 🔍
-5% - +1%
-7.27ms - +2.11ms
branch 445 kB 155.01ms - 161.99ms unsure 🔍
-1% - +5%
-2.11ms - +7.27ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 709 kB 63.25ms - 69.19ms - slower ❌
2% - 12%
1.16ms - 7.64ms
branch 697 kB 60.51ms - 63.13ms faster ✔
2% - 11%
1.16ms - 7.64ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 709 kB 716.13ms - 735.75ms - slower ❌
2% - 5%
14.83ms - 36.29ms
branch 697 kB 696.03ms - 704.73ms faster ✔
2% - 5%
14.83ms - 36.29ms
-

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 508 kB 115.41ms - 121.19ms - unsure 🔍
-7% - +0%
-8.80ms - +0.48ms
branch 495 kB 118.82ms - 126.10ms unsure 🔍
-0% - +7%
-0.48ms - +8.80ms
-

divider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 362 kB 20.48ms - 22.44ms - unsure 🔍
-5% - +7%
-1.16ms - +1.40ms
branch 350 kB 20.50ms - 22.18ms unsure 🔍
-7% - +5%
-1.40ms - +1.16ms
-

dropzone permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 370 kB 25.06ms - 26.82ms - unsure 🔍
-6% - +3%
-1.65ms - +0.85ms
branch 358 kB 25.45ms - 27.23ms unsure 🔍
-3% - +6%
-0.85ms - +1.65ms
-

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 422 kB 105.17ms - 110.79ms - unsure 🔍
-6% - +1%
-6.13ms - +0.97ms
branch 409 kB 108.38ms - 112.74ms unsure 🔍
-1% - +6%
-0.97ms - +6.13ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 391 kB 54.17ms - 58.23ms - unsure 🔍
-4% - +6%
-1.99ms - +3.23ms
branch 379 kB 53.94ms - 57.22ms unsure 🔍
-6% - +4%
-3.23ms - +1.99ms
-

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 460 kB 84.74ms - 89.42ms - unsure 🔍
-2% - +6%
-1.58ms - +5.38ms
branch 428 kB 82.61ms - 87.75ms unsure 🔍
-6% - +2%
-5.38ms - +1.58ms
-

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 387 kB 20.33ms - 22.07ms - unsure 🔍
-9% - +2%
-2.01ms - +0.37ms
branch 374 kB 21.21ms - 22.83ms unsure 🔍
-2% - +10%
-0.37ms - +2.01ms
-

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 395 kB 25.26ms - 27.78ms - unsure 🔍
-7% - +6%
-1.88ms - +1.60ms
branch 382 kB 25.47ms - 27.85ms unsure 🔍
-6% - +7%
-1.60ms - +1.88ms
-

icons permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 374 kB 50.81ms - 53.11ms - unsure 🔍
-3% - +3%
-1.36ms - +1.36ms
branch 362 kB 51.23ms - 52.69ms unsure 🔍
-3% - +3%
-1.36ms - +1.36ms
-

illustrated-message permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 405 kB 26.05ms - 26.83ms - unsure 🔍
-5% - +1%
-1.22ms - +0.38ms
branch 393 kB 26.16ms - 27.56ms unsure 🔍
-1% - +5%
-0.38ms - +1.22ms
-

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 402 kB 33.13ms - 35.39ms - faster ✔
1% - 9%
0.40ms - 3.40ms
branch 389 kB 35.17ms - 37.15ms slower ❌
1% - 10%
0.40ms - 3.40ms
-

link permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 384 kB 26.51ms - 28.21ms - faster ✔
0% - 8%
0.07ms - 2.41ms
branch 372 kB 27.79ms - 29.41ms slower ❌
0% - 9%
0.07ms - 2.41ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 476 kB 423.91ms - 439.81ms - unsure 🔍
-4% - +0%
-19.07ms - +1.19ms
branch 463 kB 434.52ms - 447.08ms unsure 🔍
-0% - +4%
-1.19ms - +19.07ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 407 kB 79.95ms - 84.61ms - unsure 🔍
-8% - +0%
-6.68ms - +0.36ms
branch 394 kB 82.81ms - 88.07ms unsure 🔍
-1% - +8%
-0.36ms - +6.68ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 523 kB 142.02ms - 147.02ms - faster ✔
8% - 13%
12.91ms - 21.77ms
branch 510 kB 158.20ms - 165.52ms slower ❌
9% - 15%
12.91ms - 21.77ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 768 kB 618.82ms - 627.26ms - slower ❌
1% - 4%
7.61ms - 23.27ms
branch 757 kB 601.00ms - 614.20ms faster ✔
1% - 4%
7.61ms - 23.27ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 771 kB 45.61ms - 46.27ms - faster ✔
4% - 6%
1.68ms - 2.68ms
branch 761 kB 47.75ms - 48.49ms slower ❌
4% - 6%
1.68ms - 2.68ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 761 kB 640.46ms - 647.74ms - slower ❌
3% - 5%
19.87ms - 28.97ms
branch 750 kB 616.95ms - 622.41ms faster ✔
3% - 4%
19.87ms - 28.97ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 561 kB 98.67ms - 107.17ms - slower ❌
7% - 16%
6.07ms - 14.65ms
branch 548 kB 91.99ms - 93.13ms faster ✔
6% - 14%
6.07ms - 14.65ms
-

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 414 kB 58.48ms - 62.44ms - faster ✔
4% - 13%
2.27ms - 8.53ms
branch 401 kB 63.43ms - 68.29ms slower ❌
4% - 14%
2.27ms - 8.53ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 513 kB 988.36ms - 1019.92ms - faster ✔
3% - 6%
26.57ms - 59.59ms
branch 500 kB 1042.36ms - 1052.08ms slower ❌
3% - 6%
26.57ms - 59.59ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 383 kB 28.33ms - 31.51ms - faster ✔
5% - 21%
1.50ms - 7.54ms
branch 372 kB 31.87ms - 37.01ms slower ❌
5% - 26%
1.50ms - 7.54ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 408 kB 61.42ms - 64.74ms - faster ✔
2% - 12%
1.18ms - 8.62ms
branch 395 kB 64.64ms - 71.32ms slower ❌
2% - 14%
1.18ms - 8.62ms
-

progress-circle permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 384 kB 36.33ms - 38.91ms - unsure 🔍
-7% - +2%
-2.76ms - +0.88ms
branch 371 kB 37.27ms - 39.85ms unsure 🔍
-2% - +7%
-0.88ms - +2.76ms
-

quick-actions permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 360 kB 20.26ms - 22.18ms - unsure 🔍
-6% - +7%
-1.20ms - +1.56ms
branch 348 kB 20.05ms - 22.03ms unsure 🔍
-7% - +6%
-1.56ms - +1.20ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 406 kB 72.37ms - 77.59ms - unsure 🔍
-7% - +3%
-5.06ms - +2.34ms
branch 393 kB 73.72ms - 78.96ms unsure 🔍
-3% - +7%
-2.34ms - +5.06ms
-

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 472 kB 67.82ms - 72.90ms - faster ✔
2% - 12%
1.69ms - 8.99ms
branch 459 kB 73.08ms - 78.32ms slower ❌
2% - 13%
1.69ms - 8.99ms
-

sidenav permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 428 kB 360.08ms - 373.04ms - faster ✔
4% - 8%
16.06ms - 33.50ms
branch 415 kB 385.51ms - 397.17ms slower ❌
4% - 9%
16.06ms - 33.50ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 480 kB 161.86ms - 167.98ms - faster ✔
1% - 7%
2.04ms - 11.72ms
branch 467 kB 168.05ms - 175.55ms slower ❌
1% - 7%
2.04ms - 11.72ms
-

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 722 kB 1878.58ms - 1882.26ms - unsure 🔍
-0% - +0%
-1.22ms - +3.98ms
branch 710 kB 1877.20ms - 1880.88ms unsure 🔍
-0% - +0%
-3.98ms - +1.22ms
-

split-view permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 395 kB 71.78ms - 79.26ms - unsure 🔍
-11% - +3%
-8.68ms - +2.76ms
branch 382 kB 74.15ms - 82.81ms unsure 🔍
-4% - +12%
-2.76ms - +8.68ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 408 kB 33.59ms - 36.65ms - faster ✔
1% - 12%
0.24ms - 4.52ms
branch 395 kB 36.00ms - 39.00ms slower ❌
0% - 13%
0.24ms - 4.52ms
-

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 400 kB 32.49ms - 35.19ms - unsure 🔍
-10% - +0%
-3.50ms - +0.06ms
branch 387 kB 34.39ms - 36.73ms unsure 🔍
-0% - +11%
-0.06ms - +3.50ms
-

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 531 kB 271.76ms - 279.20ms - unsure 🔍
-4% - +0%
-10.80ms - +0.28ms
branch 493 kB 276.64ms - 284.84ms unsure 🔍
-0% - +4%
-0.28ms - +10.80ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 424 kB 197.80ms - 204.56ms - unsure 🔍
-3% - +1%
-6.97ms - +2.73ms
branch 411 kB 199.82ms - 206.78ms unsure 🔍
-1% - +3%
-2.73ms - +6.97ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 449 kB 28.74ms - 31.14ms - unsure 🔍
-4% - +8%
-1.04ms - +2.20ms
branch 437 kB 28.27ms - 30.45ms unsure 🔍
-7% - +3%
-2.20ms - +1.04ms
-

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 433 kB 47.14ms - 50.34ms - faster ✔
1% - 10%
0.39ms - 5.25ms
branch 420 kB 49.74ms - 53.38ms slower ❌
1% - 11%
0.39ms - 5.25ms
-

thumbnail permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 761 kB 54.37ms - 56.39ms - unsure 🔍
-4% - +1%
-2.38ms - +0.66ms
branch 749 kB 55.10ms - 57.38ms unsure 🔍
-1% - +4%
-0.66ms - +2.38ms
-

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 431 kB 60.49ms - 64.03ms - faster ✔
0% - 9%
0.10ms - 6.02ms
branch 418 kB 62.94ms - 67.70ms slower ❌
0% - 10%
0.10ms - 6.02ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 654 kB 79.95ms - 83.17ms - slower ❌
10% - 15%
7.16ms - 10.88ms
branch 643 kB 71.60ms - 73.48ms faster ✔
9% - 13%
7.16ms - 10.88ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 533 kB 46.24ms - 47.48ms - faster ✔
25% - 31%
15.51ms - 20.53ms
branch 521 kB 62.45ms - 67.31ms slower ❌
33% - 44%
15.51ms - 20.53ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 654 kB 110.48ms - 117.68ms - faster ✔
4% - 12%
5.40ms - 15.08ms
branch 643 kB 121.08ms - 127.56ms slower ❌
5% - 13%
5.40ms - 15.08ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 631 kB 93.80ms - 97.88ms - faster ✔
5% - 10%
4.60ms - 10.36ms
branch 619 kB 101.29ms - 105.35ms slower ❌
5% - 11%
4.60ms - 10.36ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 430 kB 85.41ms - 92.75ms - unsure 🔍
-10% - -0%
-9.53ms - +0.05ms
branch 417 kB 90.74ms - 96.90ms unsure 🔍
-0% - +11%
-0.05ms - +9.53ms
-

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 522 kB 174.24ms - 182.32ms - unsure 🔍
-5% - +2%
-8.92ms - +2.88ms
branch 509 kB 176.99ms - 185.61ms unsure 🔍
-2% - +5%
-2.88ms - +8.92ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 527 kB 102.39ms - 108.97ms - unsure 🔍
-7% - +2%
-7.19ms - +2.03ms
branch 516 kB 105.02ms - 111.50ms unsure 🔍
-2% - +7%
-2.03ms - +7.19ms
-

underlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 361 kB 25.46ms - 29.02ms - slower ❌
1% - 18%
0.29ms - 4.51ms
branch 349 kB 23.69ms - 25.99ms faster ✔
2% - 16%
0.29ms - 4.51ms
-

github-actions[bot] avatar May 02 '24 05:05 github-actions[bot]

S2 is not intended to have lightest and darkest can we avoid including test paths for that?

Westbrook avatar May 02 '24 12:05 Westbrook

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

github-actions[bot] avatar May 03 '24 05:05 github-actions[bot]

@TarunAdobe Can you pull this up to main so that we can land this!

Rajdeepc avatar May 03 '24 06:05 Rajdeepc

Great work in pulling out the lightest/darkest listing for S2.

Something is still coming up strangely in the VRT output: image

After that, I think we're good 🤞🏼

Westbrook avatar May 03 '24 11:05 Westbrook

Great work in pulling out the lightest/darkest listing for S2.

Something is still coming up strangely in the VRT output: image

After that, I think we're good 🤞🏼

@TarunAdobe In review.js this should be metadata.system instead of metadata.theme. This is why it is returning an empty side-nav-item Screenshot 2024-05-03 at 5 58 59 PM

Rajdeepc avatar May 03 '24 12:05 Rajdeepc