spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

fix(base,reactive-controllers): add delegates API and downstate delegate

Open TarunAdobe opened this issue 1 year ago • 10 comments

Description

This PR adds the delegate strategy in SWC that allows us to add downstate functionality over our existing components. This is needed so that we can support features like downstate in Spectrum 2 while keeping everything as it is in Spectrum 1

Downstate Activation is added to this PR

Motivation and context

The downstate feature in spectrum-two enhances user interaction by providing visual feedback when components are clicked or activated. It improves accessibility and user experience by clearly indicating the active state of elements. Developers can enable downstate for components, and it seamlessly integrates with existing functionality in the framework. This addition enriches the user interface, making interactions more intuitive and engaging.

Technical Document

How has this been tested?

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • [x] I have signed the Adobe Open Source CLA.
  • [x] My code follows the code style of this project.
  • [ ] If my change required a change to the documentation, I have updated the documentation in this pull request.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.
  • [x] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

TarunAdobe avatar Apr 01 '24 07:04 TarunAdobe

Build is unhappy here. Sadly, typescript requires that local dependencies also be listed as references "references": [{ "path": "../base" }] in tsconfig.json in order to support the build order of the project.

Westbrook avatar Apr 04 '24 14:04 Westbrook

Build is unhappy here. Sadly, typescript requires that local dependencies also be listed as references "references": [{ "path": "../base" }] in tsconfig.json in order to support the build order of the project.

Adding references as "references": [{ "path": "../base" }] in tsconfig.json in reactive-controllers didn't remove the error. Don't we also need to add @spectrum-webcomponents/base under the dependencies inside reactive-controllers?

Rajdeepc avatar Apr 04 '24 16:04 Rajdeepc

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

github-actions[bot] avatar Apr 05 '24 11:04 github-actions[bot]

You're missing test coverage here.

Westbrook avatar Apr 05 '24 12:04 Westbrook

Tachometer results

Chrome

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 416 kB 73.87ms - 76.75ms - faster ✔
6% - 11%
4.99ms - 9.37ms
branch 405 kB 80.84ms - 84.14ms slower ❌
6% - 13%
4.99ms - 9.37ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 484 kB 47.87ms - 48.99ms - faster ✔
4% - 9%
2.05ms - 4.99ms
branch 473 kB 50.59ms - 53.31ms slower ❌
4% - 10%
2.05ms - 4.99ms
-

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 514 kB 67.76ms - 69.56ms - faster ✔
6% - 9%
4.05ms - 6.69ms
branch 503 kB 73.07ms - 74.99ms slower ❌
6% - 10%
4.05ms - 6.69ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 536 kB 44.90ms - 46.44ms - faster ✔
8% - 12%
4.00ms - 6.14ms
branch 525 kB 50.00ms - 51.48ms slower ❌
9% - 14%
4.00ms - 6.14ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 131.64ms - 136.20ms - faster ✔
4% - 8%
5.44ms - 11.36ms
branch 635 kB 140.43ms - 144.21ms slower ❌
4% - 9%
5.44ms - 11.36ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 603 kB 60.23ms - 61.51ms - faster ✔
7% - 10%
4.56ms - 6.82ms
branch 593 kB 65.62ms - 67.49ms slower ❌
7% - 11%
4.56ms - 6.82ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 602 kB 58.62ms - 59.90ms - faster ✔
7% - 10%
4.35ms - 6.43ms
branch 592 kB 63.83ms - 65.46ms slower ❌
7% - 11%
4.35ms - 6.43ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 788 kB 1872.47ms - 1875.84ms - unsure 🔍
-0% - +0%
-3.59ms - +1.12ms
branch 777 kB 1873.75ms - 1877.04ms unsure 🔍
-0% - +0%
-1.12ms - +3.59ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 787 kB 1857.72ms - 1860.75ms - unsure 🔍
-0% - +0%
-1.39ms - +2.84ms
branch 776 kB 1857.04ms - 1859.98ms unsure 🔍
-0% - +0%
-2.84ms - +1.39ms
-

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 452 kB 96.18ms - 97.14ms - faster ✔
2% - 3%
1.71ms - 3.43ms
branch 441 kB 98.52ms - 99.94ms slower ❌
2% - 4%
1.71ms - 3.43ms
-

asset permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 360 kB 8.45ms - 8.52ms - faster ✔
3% - 6%
0.26ms - 0.56ms
branch 351 kB 8.75ms - 9.04ms slower ❌
3% - 7%
0.26ms - 0.56ms
-

avatar permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 397 kB 17.65ms - 18.08ms - faster ✔
1% - 4%
0.25ms - 0.72ms
branch 387 kB 18.25ms - 18.45ms slower ❌
1% - 4%
0.25ms - 0.72ms
-

badge permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 398 kB 21.19ms - 21.64ms - faster ✔
3% - 6%
0.61ms - 1.28ms
branch 387 kB 22.11ms - 22.61ms slower ❌
3% - 6%
0.61ms - 1.28ms
-

banner permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 360 kB 10.20ms - 10.27ms - faster ✔
3% - 4%
0.35ms - 0.48ms
branch 350 kB 10.60ms - 10.70ms slower ❌
3% - 5%
0.35ms - 0.48ms
-

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 443 kB 40.21ms - 41.44ms - faster ✔
4% - 8%
1.60ms - 3.38ms
branch 432 kB 42.67ms - 43.96ms slower ❌
4% - 8%
1.60ms - 3.38ms
-

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 449 kB 44.20ms - 45.62ms - faster ✔
3% - 7%
1.55ms - 3.53ms
branch 438 kB 46.76ms - 48.14ms slower ❌
3% - 8%
1.55ms - 3.53ms
-

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 503 kB 36.66ms - 37.35ms - faster ✔
3% - 6%
1.01ms - 2.15ms
branch 492 kB 38.14ms - 39.04ms slower ❌
3% - 6%
1.01ms - 2.15ms
-

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 416 kB 36.81ms - 37.84ms - faster ✔
2% - 5%
0.79ms - 2.08ms
branch 405 kB 38.37ms - 39.15ms slower ❌
2% - 6%
0.79ms - 2.08ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 629 kB 87.26ms - 89.21ms - faster ✔
5% - 8%
5.02ms - 7.92ms
branch 618 kB 93.63ms - 95.79ms slower ❌
6% - 9%
5.02ms - 7.92ms
-

color-area permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 455 kB 112.87ms - 114.87ms - faster ✔
1% - 3%
0.97ms - 3.85ms
branch 444 kB 115.24ms - 117.32ms slower ❌
1% - 3%
0.97ms - 3.85ms
-

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 488 kB 39.02ms - 40.04ms - faster ✔
4% - 8%
1.62ms - 3.22ms
branch 471 kB 41.33ms - 42.57ms slower ❌
4% - 8%
1.62ms - 3.22ms
-

color-handle permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 373 kB 19.86ms - 21.16ms - unsure 🔍
-5% - +1%
-1.09ms - +0.25ms
branch 363 kB 20.78ms - 21.07ms unsure 🔍
-1% - +5%
-0.25ms - +1.09ms
-

color-loupe permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 365 kB 14.42ms - 14.55ms - faster ✔
2% - 4%
0.26ms - 0.53ms
branch 355 kB 14.76ms - 15.00ms slower ❌
2% - 4%
0.26ms - 0.53ms
-

color-slider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 457 kB 94.78ms - 95.62ms - faster ✔
2% - 3%
1.46ms - 2.55ms
branch 446 kB 96.86ms - 97.56ms slower ❌
2% - 3%
1.46ms - 2.55ms
-

color-wheel permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 458 kB 93.33ms - 95.67ms - faster ✔
1% - 3%
0.71ms - 3.20ms
branch 447 kB 96.04ms - 96.86ms slower ❌
1% - 3%
0.71ms - 3.20ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 709 kB 35.38ms - 35.82ms - faster ✔
3% - 4%
0.95ms - 1.57ms
branch 698 kB 36.64ms - 37.09ms slower ❌
3% - 4%
0.95ms - 1.57ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 709 kB 374.40ms - 381.25ms - faster ✔
4% - 6%
13.90ms - 24.14ms
branch 698 kB 393.04ms - 400.65ms slower ❌
4% - 6%
13.90ms - 24.14ms
-

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 508 kB 71.42ms - 72.00ms - faster ✔
2% - 3%
1.38ms - 2.29ms
branch 498 kB 73.20ms - 73.90ms slower ❌
2% - 3%
1.38ms - 2.29ms
-

divider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 362 kB 8.66ms - 8.74ms - faster ✔
4% - 5%
0.39ms - 0.50ms
branch 352 kB 9.11ms - 9.19ms slower ❌
4% - 6%
0.39ms - 0.50ms
-

dropzone permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 370 kB 18.30ms - 18.43ms - faster ✔
2% - 3%
0.36ms - 0.57ms
branch 360 kB 18.75ms - 18.91ms slower ❌
2% - 3%
0.36ms - 0.57ms
-

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 422 kB 41.85ms - 43.28ms - faster ✔
4% - 8%
1.59ms - 3.53ms
branch 411 kB 44.46ms - 45.78ms slower ❌
4% - 8%
1.59ms - 3.53ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 391 kB 19.44ms - 19.72ms - faster ✔
3% - 5%
0.57ms - 1.00ms
branch 381 kB 20.20ms - 20.53ms slower ❌
3% - 5%
0.57ms - 1.00ms
-

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 460 kB 35.77ms - 37.50ms - unsure 🔍
-0% - +5%
-0.13ms - +1.75ms
branch 430 kB 35.47ms - 36.19ms unsure 🔍
-5% - +0%
-1.75ms - +0.13ms
-

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 387 kB 9.80ms - 9.92ms - faster ✔
4% - 8%
0.43ms - 0.86ms
branch 377 kB 10.30ms - 10.71ms slower ❌
4% - 9%
0.43ms - 0.86ms
-

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 395 kB 10.62ms - 10.73ms - faster ✔
3% - 5%
0.32ms - 0.51ms
branch 384 kB 11.01ms - 11.17ms slower ❌
3% - 5%
0.32ms - 0.51ms
-

icons permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 374 kB 28.52ms - 29.37ms - unsure 🔍
-2% - +1%
-0.68ms - +0.19ms
branch 364 kB 29.11ms - 29.28ms unsure 🔍
-1% - +2%
-0.19ms - +0.68ms
-

illustrated-message permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 405 kB 13.34ms - 13.54ms - faster ✔
1% - 5%
0.17ms - 0.75ms
branch 395 kB 13.63ms - 14.17ms slower ❌
1% - 6%
0.17ms - 0.75ms
-

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 402 kB 14.12ms - 14.37ms - faster ✔
13% - 16%
2.17ms - 2.63ms
branch 391 kB 16.45ms - 16.84ms slower ❌
15% - 19%
2.17ms - 2.63ms
-

link permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 384 kB 12.72ms - 13.05ms - faster ✔
4% - 8%
0.55ms - 1.14ms
branch 374 kB 13.48ms - 13.98ms slower ❌
4% - 9%
0.55ms - 1.14ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 476 kB 201.91ms - 205.27ms - faster ✔
2% - 5%
4.27ms - 9.80ms
branch 465 kB 208.42ms - 212.82ms slower ❌
2% - 5%
4.27ms - 9.80ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 407 kB 42.51ms - 43.28ms - faster ✔
3% - 6%
1.44ms - 2.59ms
branch 396 kB 44.48ms - 45.34ms slower ❌
3% - 6%
1.44ms - 2.59ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 523 kB 64.83ms - 66.47ms - faster ✔
9% - 12%
6.27ms - 8.69ms
branch 512 kB 72.24ms - 74.02ms slower ❌
9% - 13%
6.27ms - 8.69ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 678 kB 415.20ms - 420.72ms - faster ✔
1% - 2%
2.77ms - 9.12ms
branch 662 kB 422.34ms - 425.46ms slower ❌
1% - 2%
2.77ms - 9.12ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 771 kB 21.32ms - 21.81ms - faster ✔
10% - 13%
2.32ms - 3.15ms
branch 780 kB 23.96ms - 24.63ms slower ❌
11% - 15%
2.32ms - 3.15ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 761 kB 338.47ms - 341.97ms - faster ✔
2% - 3%
6.59ms - 11.14ms
branch 750 kB 347.64ms - 350.53ms slower ❌
2% - 3%
6.59ms - 11.14ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 561 kB 39.27ms - 40.12ms - faster ✔
7% - 11%
3.12ms - 4.62ms
branch 550 kB 42.94ms - 44.19ms slower ❌
8% - 12%
3.12ms - 4.62ms
-

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 414 kB 24.34ms - 24.77ms - faster ✔
6% - 9%
1.52ms - 2.29ms
branch 403 kB 26.14ms - 26.78ms slower ❌
6% - 9%
1.52ms - 2.29ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 513 kB 504.26ms - 513.61ms - faster ✔
2% - 9%
9.49ms - 47.53ms
branch 502 kB 519.01ms - 555.88ms slower ❌
2% - 9%
9.49ms - 47.53ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 383 kB 11.13ms - 11.24ms - faster ✔
4% - 6%
0.45ms - 0.69ms
branch 373 kB 11.64ms - 11.86ms slower ❌
4% - 6%
0.45ms - 0.69ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 408 kB 29.38ms - 30.09ms - faster ✔
2% - 5%
0.66ms - 1.65ms
branch 397 kB 30.54ms - 31.24ms slower ❌
2% - 6%
0.66ms - 1.65ms
-

progress-circle permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 384 kB 14.96ms - 15.31ms - faster ✔
4% - 7%
0.55ms - 1.12ms
branch 374 kB 15.75ms - 16.19ms slower ❌
4% - 7%
0.55ms - 1.12ms
-

quick-actions permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 360 kB 8.68ms - 8.75ms - faster ✔
3% - 5%
0.28ms - 0.44ms
branch 350 kB 9.00ms - 9.15ms slower ❌
3% - 5%
0.28ms - 0.44ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 406 kB 34.08ms - 34.85ms - faster ✔
4% - 7%
1.34ms - 2.58ms
branch 395 kB 35.94ms - 36.91ms slower ❌
4% - 8%
1.34ms - 2.58ms
-

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 472 kB 37.27ms - 38.11ms - faster ✔
3% - 6%
1.14ms - 2.28ms
branch 461 kB 39.01ms - 39.78ms slower ❌
3% - 6%
1.14ms - 2.28ms
-

sidenav permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 428 kB 161.60ms - 166.05ms - faster ✔
8% - 11%
13.87ms - 19.98ms
branch 417 kB 178.66ms - 182.84ms slower ❌
8% - 12%
13.87ms - 19.98ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 480 kB 72.78ms - 74.71ms - faster ✔
2% - 6%
1.68ms - 4.52ms
branch 469 kB 75.80ms - 77.89ms slower ❌
2% - 6%
1.68ms - 4.52ms
-

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 722 kB 1856.01ms - 1859.39ms - unsure 🔍
-0% - +0%
-2.58ms - +2.37ms
branch 711 kB 1856.00ms - 1859.62ms unsure 🔍
-0% - +0%
-2.37ms - +2.58ms
-

split-view permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 395 kB 30.59ms - 31.18ms - faster ✔
3% - 6%
1.04ms - 1.89ms
branch 384 kB 32.05ms - 32.65ms slower ❌
3% - 6%
1.04ms - 1.89ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 408 kB 13.42ms - 13.67ms - faster ✔
8% - 11%
1.21ms - 1.64ms
branch 397 kB 14.79ms - 15.14ms slower ❌
9% - 12%
1.21ms - 1.64ms
-

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 400 kB 14.09ms - 14.41ms - faster ✔
6% - 10%
0.93ms - 1.55ms
branch 389 kB 15.22ms - 15.75ms slower ❌
6% - 11%
0.93ms - 1.55ms
-

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 531 kB 117.20ms - 120.79ms - faster ✔
1% - 6%
1.25ms - 7.22ms
branch 496 kB 120.84ms - 125.61ms slower ❌
1% - 6%
1.25ms - 7.22ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 424 kB 102.96ms - 105.02ms - faster ✔
1% - 4%
1.30ms - 3.87ms
branch 413 kB 105.81ms - 107.34ms slower ❌
1% - 4%
1.30ms - 3.87ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 449 kB 12.06ms - 12.16ms - faster ✔
1% - 2%
0.10ms - 0.25ms
branch 439 kB 12.23ms - 12.35ms slower ❌
1% - 2%
0.10ms - 0.25ms
-

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 433 kB 22.85ms - 23.41ms - faster ✔
10% - 13%
2.46ms - 3.42ms
branch 422 kB 25.68ms - 26.46ms slower ❌
11% - 15%
2.46ms - 3.42ms
-

thumbnail permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 761 kB 22.17ms - 22.70ms - faster ✔
3% - 8%
0.74ms - 1.97ms
branch 751 kB 23.23ms - 24.35ms slower ❌
3% - 9%
0.74ms - 1.97ms
-

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 431 kB 25.86ms - 26.41ms - faster ✔
8% - 12%
2.40ms - 3.47ms
branch 420 kB 28.62ms - 29.53ms slower ❌
9% - 13%
2.40ms - 3.47ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 549 kB 32.77ms - 33.43ms - faster ✔
3% - 7%
0.84ms - 2.53ms
branch 538 kB 34.00ms - 35.56ms slower ❌
3% - 8%
0.84ms - 2.53ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 550 kB 22.40ms - 23.01ms - faster ✔
8% - 12%
1.98ms - 2.94ms
branch 532 kB 24.79ms - 25.54ms slower ❌
9% - 13%
1.98ms - 2.94ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 654 kB 49.82ms - 51.19ms - faster ✔
5% - 8%
2.75ms - 4.62ms
branch 643 kB 53.55ms - 54.82ms slower ❌
5% - 9%
2.75ms - 4.62ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 631 kB 40.71ms - 41.67ms - faster ✔
6% - 9%
2.67ms - 4.08ms
branch 620 kB 44.05ms - 45.09ms slower ❌
6% - 10%
2.67ms - 4.08ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 430 kB 36.48ms - 37.91ms - faster ✔
4% - 9%
1.40ms - 3.60ms
branch 419 kB 38.86ms - 40.53ms slower ❌
4% - 10%
1.40ms - 3.60ms
-

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 522 kB 93.05ms - 95.00ms - faster ✔
1% - 3%
0.62ms - 2.77ms
branch 512 kB 95.26ms - 96.17ms slower ❌
1% - 3%
0.62ms - 2.77ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 527 kB 53.84ms - 54.97ms - faster ✔
3% - 5%
1.50ms - 3.06ms
branch 516 kB 56.15ms - 57.22ms slower ❌
3% - 6%
1.50ms - 3.06ms
-

underlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 361 kB 9.24ms - 9.30ms - faster ✔
2% - 4%
0.23ms - 0.34ms
branch 351 kB 9.51ms - 9.60ms slower ❌
2% - 4%
0.23ms - 0.34ms
-
Firefox

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 416 kB 163.61ms - 170.35ms - faster ✔
5% - 10%
8.78ms - 17.58ms
branch 405 kB 177.33ms - 182.99ms slower ❌
5% - 11%
8.78ms - 17.58ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 484 kB 111.44ms - 116.32ms - faster ✔
3% - 8%
3.05ms - 10.23ms
branch 473 kB 117.89ms - 123.15ms slower ❌
3% - 9%
3.05ms - 10.23ms
-

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 514 kB 151.22ms - 157.26ms - faster ✔
3% - 10%
4.49ms - 16.07ms
branch 503 kB 159.58ms - 169.46ms slower ❌
3% - 10%
4.49ms - 16.07ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 536 kB 114.48ms - 121.32ms - faster ✔
1% - 8%
0.92ms - 9.52ms
branch 525 kB 120.51ms - 125.73ms slower ❌
1% - 8%
0.92ms - 9.52ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 277.23ms - 281.77ms - faster ✔
12% - 14%
36.71ms - 44.37ms
branch 635 kB 316.96ms - 323.12ms slower ❌
13% - 16%
36.71ms - 44.37ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 603 kB 131.21ms - 134.75ms - faster ✔
0% - 3%
0.24ms - 4.24ms
branch 593 kB 134.28ms - 136.16ms slower ❌
0% - 3%
0.24ms - 4.24ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 602 kB 145.57ms - 153.51ms - slower ❌
5% - 11%
6.92ms - 15.68ms
branch 592 kB 136.40ms - 140.08ms faster ✔
5% - 10%
6.92ms - 15.68ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 788 kB 1899.41ms - 1908.39ms - slower ❌
1% - 1%
10.63ms - 20.69ms
branch 777 kB 1885.96ms - 1890.52ms faster ✔
1% - 1%
10.63ms - 20.69ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 787 kB 1886.43ms - 1890.77ms - unsure 🔍
-0% - +0%
-4.24ms - +3.56ms
branch 776 kB 1885.71ms - 1892.17ms unsure 🔍
-0% - +0%
-3.56ms - +4.24ms
-

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 452 kB 201.11ms - 209.13ms - unsure 🔍
-4% - +2%
-7.45ms - +3.49ms
branch 441 kB 203.37ms - 210.83ms unsure 🔍
-2% - +4%
-3.49ms - +7.45ms
-

asset permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 360 kB 21.02ms - 23.10ms - unsure 🔍
-9% - +4%
-2.16ms - +0.84ms
branch 351 kB 21.64ms - 23.80ms unsure 🔍
-4% - +10%
-0.84ms - +2.16ms
-

avatar permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 397 kB 47.40ms - 51.28ms - unsure 🔍
-7% - +4%
-3.68ms - +1.92ms
branch 387 kB 48.20ms - 52.24ms unsure 🔍
-4% - +8%
-1.92ms - +3.68ms
-

badge permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 398 kB 49.25ms - 53.11ms - faster ✔
0% - 11%
0.16ms - 6.20ms
branch 387 kB 52.04ms - 56.68ms slower ❌
0% - 12%
0.16ms - 6.20ms
-

banner permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 360 kB 22.35ms - 24.25ms - unsure 🔍
-9% - +3%
-2.28ms - +0.64ms
branch 350 kB 23.01ms - 25.23ms unsure 🔍
-3% - +10%
-0.64ms - +2.28ms
-

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 443 kB 92.26ms - 97.82ms - faster ✔
5% - 13%
4.67ms - 13.65ms
branch 432 kB 100.68ms - 107.72ms slower ❌
5% - 15%
4.67ms - 13.65ms
-

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 449 kB 101.65ms - 106.71ms - faster ✔
4% - 11%
4.58ms - 12.78ms
branch 438 kB 109.63ms - 116.09ms slower ❌
4% - 12%
4.58ms - 12.78ms
-

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 503 kB 69.37ms - 72.55ms - faster ✔
3% - 9%
1.93ms - 6.67ms
branch 492 kB 73.50ms - 77.02ms slower ❌
3% - 9%
1.93ms - 6.67ms
-

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 416 kB 88.67ms - 93.37ms - faster ✔
1% - 8%
0.79ms - 7.45ms
branch 405 kB 92.78ms - 97.50ms slower ❌
1% - 8%
0.79ms - 7.45ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 629 kB 192.33ms - 197.79ms - faster ✔
3% - 6%
6.19ms - 12.93ms
branch 618 kB 202.66ms - 206.58ms slower ❌
3% - 7%
6.19ms - 12.93ms
-

color-area permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 455 kB 181.45ms - 187.83ms - faster ✔
0% - 5%
0.43ms - 9.37ms
branch 444 kB 186.40ms - 192.68ms slower ❌
0% - 5%
0.43ms - 9.37ms
-

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 496 kB 77.30ms - 80.78ms - unsure 🔍
-5% - +0%
-3.68ms - +0.40ms
branch 485 kB 79.61ms - 81.75ms unsure 🔍
-1% - +5%
-0.40ms - +3.68ms
-

color-handle permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 373 kB 40.30ms - 43.18ms - unsure 🔍
-8% - +1%
-3.60ms - +0.32ms
branch 363 kB 42.06ms - 44.70ms unsure 🔍
-1% - +9%
-0.32ms - +3.60ms
-

color-loupe permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 365 kB 26.40ms - 27.44ms - unsure 🔍
-5% - +0%
-1.41ms - +0.01ms
branch 355 kB 27.14ms - 28.10ms unsure 🔍
-0% - +5%
-0.01ms - +1.41ms
-

color-slider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 457 kB 165.65ms - 171.99ms - faster ✔
0% - 5%
0.18ms - 8.98ms
branch 446 kB 170.36ms - 176.44ms slower ❌
0% - 5%
0.18ms - 8.98ms
-

color-wheel permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 458 kB 152.64ms - 157.76ms - unsure 🔍
-3% - +2%
-5.05ms - +2.49ms
branch 447 kB 153.71ms - 159.25ms unsure 🔍
-2% - +3%
-2.49ms - +5.05ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 709 kB 61.59ms - 64.49ms - unsure 🔍
-5% - +1%
-3.02ms - +0.66ms
branch 698 kB 63.08ms - 65.36ms unsure 🔍
-1% - +5%
-0.66ms - +3.02ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 709 kB 725.24ms - 748.84ms - slower ❌
1% - 5%
10.56ms - 35.32ms
branch 698 kB 710.37ms - 717.83ms faster ✔
1% - 5%
10.56ms - 35.32ms
-

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 508 kB 121.70ms - 132.02ms - unsure 🔍
-3% - +6%
-4.16ms - +7.16ms
branch 498 kB 123.02ms - 127.70ms unsure 🔍
-6% - +3%
-7.16ms - +4.16ms
-

divider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 362 kB 20.05ms - 22.47ms - unsure 🔍
-10% - +5%
-2.12ms - +1.00ms
branch 352 kB 20.84ms - 22.80ms unsure 🔍
-5% - +10%
-1.00ms - +2.12ms
-

dropzone permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 370 kB 24.40ms - 26.28ms - unsure 🔍
-2% - +6%
-0.61ms - +1.45ms
branch 360 kB 24.49ms - 25.35ms unsure 🔍
-6% - +2%
-1.45ms - +0.61ms
-

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 422 kB 104.04ms - 112.40ms - unsure 🔍
-8% - +2%
-9.22ms - +2.50ms
branch 411 kB 107.48ms - 115.68ms unsure 🔍
-2% - +9%
-2.50ms - +9.22ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 391 kB 53.41ms - 57.71ms - unsure 🔍
-9% - +4%
-5.16ms - +2.52ms
branch 381 kB 53.70ms - 60.06ms unsure 🔍
-5% - +9%
-2.52ms - +5.16ms
-

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 460 kB 86.41ms - 91.15ms - unsure 🔍
-1% - +7%
-0.88ms - +5.76ms
branch 430 kB 84.02ms - 88.66ms unsure 🔍
-6% - +1%
-5.76ms - +0.88ms
-

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 387 kB 20.17ms - 21.51ms - unsure 🔍
-7% - +1%
-1.43ms - +0.19ms
branch 377 kB 21.01ms - 21.91ms unsure 🔍
-1% - +7%
-0.19ms - +1.43ms
-

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 395 kB 24.97ms - 27.39ms - unsure 🔍
-6% - +5%
-1.59ms - +1.43ms
branch 384 kB 25.34ms - 27.18ms unsure 🔍
-5% - +6%
-1.43ms - +1.59ms
-

icons permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 374 kB 49.60ms - 51.40ms - unsure 🔍
-1% - +3%
-0.49ms - +1.57ms
branch 364 kB 49.46ms - 50.46ms unsure 🔍
-3% - +1%
-1.57ms - +0.49ms
-

illustrated-message permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 405 kB 25.40ms - 26.56ms - unsure 🔍
-4% - +2%
-0.92ms - +0.44ms
branch 395 kB 25.86ms - 26.58ms unsure 🔍
-2% - +4%
-0.44ms - +0.92ms
-

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 402 kB 33.18ms - 34.58ms - faster ✔
4% - 10%
1.52ms - 3.76ms
branch 391 kB 35.64ms - 37.40ms slower ❌
4% - 11%
1.52ms - 3.76ms
-

link permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 384 kB 26.27ms - 27.93ms - unsure 🔍
-6% - +0%
-1.80ms - +0.08ms
branch 374 kB 27.52ms - 28.40ms unsure 🔍
-0% - +7%
-0.08ms - +1.80ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 476 kB 437.01ms - 448.67ms - faster ✔
2% - 5%
7.46ms - 24.26ms
branch 465 kB 452.65ms - 464.75ms slower ❌
2% - 6%
7.46ms - 24.26ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 407 kB 81.97ms - 87.67ms - unsure 🔍
-8% - +1%
-7.24ms - +1.04ms
branch 396 kB 84.92ms - 90.92ms unsure 🔍
-1% - +9%
-1.04ms - +7.24ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 523 kB 147.02ms - 151.58ms - faster ✔
7% - 12%
11.86ms - 19.90ms
branch 512 kB 161.86ms - 168.50ms slower ❌
8% - 13%
11.86ms - 19.90ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 768 kB 649.82ms - 669.62ms - slower ❌
2% - 5%
12.33ms - 34.51ms
branch 757 kB 631.29ms - 641.31ms faster ✔
2% - 5%
12.33ms - 34.51ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 771 kB 46.15ms - 46.73ms - faster ✔
5% - 7%
2.41ms - 3.51ms
branch 760 kB 48.93ms - 49.87ms slower ❌
5% - 8%
2.41ms - 3.51ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 761 kB 661.59ms - 675.41ms - slower ❌
2% - 4%
10.92ms - 28.36ms
branch 750 kB 643.55ms - 654.17ms faster ✔
2% - 4%
10.92ms - 28.36ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 561 kB 91.52ms - 99.08ms - unsure 🔍
-5% - +3%
-5.11ms - +2.75ms
branch 550 kB 95.40ms - 97.56ms unsure 🔍
-3% - +5%
-2.75ms - +5.11ms
-

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 414 kB 55.45ms - 58.59ms - faster ✔
3% - 11%
1.44ms - 7.00ms
branch 403 kB 58.95ms - 63.53ms slower ❌
2% - 12%
1.44ms - 7.00ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 513 kB 1004.43ms - 1026.33ms - faster ✔
4% - 7%
46.46ms - 71.90ms
branch 502 kB 1068.10ms - 1081.02ms slower ❌
5% - 7%
46.46ms - 71.90ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 383 kB 28.85ms - 32.03ms - unsure 🔍
-9% - +8%
-2.88ms - +2.40ms
branch 373 kB 28.57ms - 32.79ms unsure 🔍
-8% - +9%
-2.40ms - +2.88ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 408 kB 62.71ms - 66.09ms - unsure 🔍
-4% - +2%
-2.66ms - +1.58ms
branch 397 kB 63.66ms - 66.22ms unsure 🔍
-2% - +4%
-1.58ms - +2.66ms
-

progress-circle permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 384 kB 34.89ms - 37.63ms - unsure 🔍
-8% - +2%
-3.20ms - +0.64ms
branch 374 kB 36.20ms - 38.88ms unsure 🔍
-2% - +9%
-0.64ms - +3.20ms
-

quick-actions permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 360 kB 19.82ms - 21.86ms - faster ✔
1% - 13%
0.10ms - 3.02ms
branch 350 kB 21.36ms - 23.44ms slower ❌
0% - 15%
0.10ms - 3.02ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 406 kB 73.00ms - 76.40ms - faster ✔
0% - 7%
0.17ms - 5.83ms
branch 395 kB 75.44ms - 79.96ms slower ❌
0% - 8%
0.17ms - 5.83ms
-

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 472 kB 66.38ms - 71.58ms - faster ✔
3% - 12%
1.96ms - 8.68ms
branch 461 kB 72.17ms - 76.43ms slower ❌
3% - 13%
1.96ms - 8.68ms
-

sidenav permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 428 kB 352.35ms - 362.85ms - faster ✔
6% - 10%
22.43ms - 39.13ms
branch 417 kB 381.89ms - 394.87ms slower ❌
6% - 11%
22.43ms - 39.13ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 480 kB 163.12ms - 168.96ms - faster ✔
1% - 6%
1.50ms - 9.94ms
branch 469 kB 168.71ms - 174.81ms slower ❌
1% - 6%
1.50ms - 9.94ms
-

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 722 kB 1878.17ms - 1881.47ms - unsure 🔍
-0% - -0%
-6.20ms - -0.88ms
branch 711 kB 1881.27ms - 1885.45ms unsure 🔍
+0% - +0%
+0.88ms - +6.20ms
-

split-view permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 395 kB 75.90ms - 82.78ms - unsure 🔍
-8% - +3%
-6.97ms - +2.57ms
branch 384 kB 78.25ms - 84.83ms unsure 🔍
-3% - +9%
-2.57ms - +6.97ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 408 kB 33.02ms - 35.54ms - faster ✔
2% - 12%
0.73ms - 4.39ms
branch 397 kB 35.51ms - 38.17ms slower ❌
2% - 13%
0.73ms - 4.39ms
-

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 400 kB 32.92ms - 35.24ms - faster ✔
3% - 14%
0.81ms - 5.19ms
branch 389 kB 35.22ms - 38.94ms slower ❌
2% - 15%
0.81ms - 5.19ms
-

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 531 kB 272.66ms - 281.94ms - faster ✔
0% - 5%
0.15ms - 12.97ms
branch 496 kB 279.44ms - 288.28ms slower ❌
0% - 5%
0.15ms - 12.97ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 424 kB 203.80ms - 212.56ms - unsure 🔍
-6% - -0%
-12.03ms - +0.07ms
branch 413 kB 209.99ms - 218.33ms unsure 🔍
-0% - +6%
-0.07ms - +12.03ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 449 kB 27.72ms - 30.48ms - unsure 🔍
-7% - +7%
-1.90ms - +1.90ms
branch 439 kB 27.80ms - 30.40ms unsure 🔍
-7% - +7%
-1.90ms - +1.90ms
-

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 433 kB 47.23ms - 51.33ms - faster ✔
0% - 11%
0.14ms - 5.54ms
branch 422 kB 50.36ms - 53.88ms slower ❌
0% - 11%
0.14ms - 5.54ms
-

thumbnail permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 761 kB 53.35ms - 54.73ms - faster ✔
0% - 4%
0.12ms - 2.04ms
branch 751 kB 54.45ms - 55.79ms slower ❌
0% - 4%
0.12ms - 2.04ms
-

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 431 kB 59.91ms - 65.21ms - unsure 🔍
-9% - +0%
-6.12ms - +0.36ms
branch 420 kB 63.57ms - 67.31ms unsure 🔍
-1% - +10%
-0.36ms - +6.12ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 654 kB 78.88ms - 81.92ms - slower ❌
8% - 13%
6.04ms - 9.60ms
branch 643 kB 71.65ms - 73.51ms faster ✔
8% - 12%
6.04ms - 9.60ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 533 kB 45.99ms - 47.37ms - faster ✔
21% - 28%
12.73ms - 18.11ms
branch 522 kB 59.50ms - 64.70ms slower ❌
27% - 39%
12.73ms - 18.11ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 654 kB 111.05ms - 116.67ms - faster ✔
5% - 11%
5.93ms - 13.47ms
branch 643 kB 121.05ms - 126.07ms slower ❌
5% - 12%
5.93ms - 13.47ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 631 kB 91.97ms - 95.95ms - faster ✔
6% - 12%
6.47ms - 12.37ms
branch 620 kB 101.20ms - 105.56ms slower ❌
7% - 13%
6.47ms - 12.37ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 430 kB 86.60ms - 93.28ms - faster ✔
2% - 11%
1.69ms - 11.03ms
branch 419 kB 93.04ms - 99.56ms slower ❌
2% - 12%
1.69ms - 11.03ms
-

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 522 kB 171.84ms - 179.72ms - unsure 🔍
-5% - +1%
-8.97ms - +2.29ms
branch 512 kB 175.10ms - 183.14ms unsure 🔍
-1% - +5%
-2.29ms - +8.97ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 527 kB 104.31ms - 109.77ms - unsure 🔍
-7% - +1%
-7.26ms - +0.74ms
branch 516 kB 107.38ms - 113.22ms unsure 🔍
-1% - +7%
-0.74ms - +7.26ms
-

underlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 361 kB 24.19ms - 26.97ms - unsure 🔍
-9% - +4%
-2.34ms - +1.14ms
branch 351 kB 25.13ms - 27.23ms unsure 🔍
-5% - +9%
-1.14ms - +2.34ms
-

github-actions[bot] avatar Apr 05 '24 13:04 github-actions[bot]

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 221.192 kB 210.356 kB 🏆 210.87 kB
Scripts 53.605 kB 48.142 kB 🏆 48.628 kB
Stylesheet 34.893 kB 30.422 kB 🏆 30.44 kB
Document 5.904 kB 5.186 kB 🏆 5.196 kB
Font 126.79 kB 126.606 kB 126.606 kB

Request Count

Category Latest Main Branch
Total 45 45 44 🏆
Scripts 37 37 36 🏆
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

github-actions[bot] avatar Apr 08 '24 13:04 github-actions[bot]

@adobe/spectrum-css spectrum-button.css is overridden with logic to hide icon in pending state of button. An issue is raised on the S2 button implementation to fix this. We would need to test this fix in this PR by upgrading to the next release of button

Rajdeepc avatar Apr 08 '24 15:04 Rajdeepc

@Rajdeepc Since we're not adopting any S2 css in this PR we're probably good to go here. However on the #4241 where we are adopting those styles, we need to workout the custom css to support all the broken S1 VRTs after migration to S2 styles including but not limited to pending button. Thanks for pointing it out!

TarunAdobe avatar Apr 09 '24 04:04 TarunAdobe

@Rajdeepc Since we're not adopting any S2 css in this PR we're probably good to go here. However on the #4241 where we are adopting those styles, we need to workout the custom css to support all the broken S1 VRTs after migration to S2 styles including but not limited to pending button. Thanks for pointing it out!

Yes that's the plan! Thanks

Rajdeepc avatar Apr 09 '24 05:04 Rajdeepc

This PR only holds the downstate logic and the downstate activation of checkbox has been abstracted to #4368

Rajdeepc avatar May 01 '24 13:05 Rajdeepc